From patchwork Sun Sep 1 03:40:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13786246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D43E1CA101E for ; Sun, 1 Sep 2024 03:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5X+/CCCJdHsPQtIkli72FdNOUA83CpBm1xJ/DRLJla8=; b=b869+xC4a+E52SFM53H5xkgkNc N81HsHk+iZr+qzL/f5tEK0CYKKCVIu7rZ/o62PCqgVpirtzhBnuyyNhXlmfZv0bK/P4edy8WT9Bi2 xK1n5PNXtmzrcksWt9OhyWUPLnkLcmsHzEfyxWhAvLaiPItjjDbT8wOMHNt8Rrygg6ESuO5LtQeuv 5tiYhATa1ilC7i13uSl8r5Mkjtlhvhk75bn83/SVqEYkFSg84zRZ5wP2dxqIzahf8e03xfUtsLzQx yRWTwje6zjCmjoR05HLyU+eeLK58UvaFCCEGeroVdR+hEldXAHMY0A7lkpUXdVzYBdxxJnvrWtpBx XsVH4rGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skbWL-0000000Aknt-29Nm; Sun, 01 Sep 2024 03:44:57 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skbU9-0000000AkOY-3mWc for linux-arm-kernel@lists.infradead.org; Sun, 01 Sep 2024 03:42:43 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-714262f1bb4so2426808b3a.3 for ; Sat, 31 Aug 2024 20:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725162161; x=1725766961; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5X+/CCCJdHsPQtIkli72FdNOUA83CpBm1xJ/DRLJla8=; b=VGWk7+mt4U2mhTT+9EWlY6hQ+Qmx+stZBzW+GsqfDGmBKtLpxkQ4ruaEcVUMkg5zZ+ JQbdeZJGMZ3Lum1cmTU+qyyqpG+aj4DgKApovuYxqWvOq+1RIIeHGTC5Ke7G1DMr4UdZ bd7g5v2oz63SCUnUhS2LiVGfry7RKjAp36kjRmCCtyqHWb/kTo6H2ChUhiN9YnQMwsRF HFsTUHPKJWIqsnitq1BnP9hhtnZ1da0WlAUdwTzrGKe2AKNXFgyXALAcalV0AJPkPfah EO6GaT/eI8KP+6Mgy8uyvrMGn0+OpPguCfjaFSXVg+rMj5QTUhE2UXZqWUvS0I7teFd5 cPBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725162161; x=1725766961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5X+/CCCJdHsPQtIkli72FdNOUA83CpBm1xJ/DRLJla8=; b=wZPM0yF59OLNWMLNbzeeZILPAsQzLpLj9WlpBFcFniH98caWpHDOTsbjDuKLpgAyiJ fq8qLcgO9TI986OfPa7ZMXgR+iod+zZNmlxhZHNuegn49w6EpxY+Tu5JLKD2k03Q3MVQ orcbNBI24nX7gC/xFEvT46pxKo2t5OqmarfugiC3hF3Y2TIo9yTloOHXj+CnFzsxrqrJ uraL47LbYpOSm+/aa/ic+O82kb+DckaIdUDr++ux7OCOTEoNDqJhcs5hipl6ZNsnzmXS hkxowUbGkDKClY3pKiXlEPMiAUJvZa/yjXkayXNKCF/BC4CXxtOTpn3FgDmVMFi8QfTo 7+yg== X-Forwarded-Encrypted: i=1; AJvYcCVvuYLY7KOcqf+8VbqnCJ79VhqzTyProgOnR/qtjyMQpQO9qSerLf2oX100w3hl2ACQYkwtL23BKSBxUGsRrkzF@lists.infradead.org X-Gm-Message-State: AOJu0YzTkchIDIUSlzUM+bf5IEtw0Kb6mtXvX9wLbN+1wDANVCFSK/tG cVRcGJHYFcGvYivWUE0GF7ynYhljkqg3sZWt9RqBzBSLEys/j8rV X-Google-Smtp-Source: AGHT+IErgWsZXv7smRglnCflkeOjudhULFolSyci/zrSk+ZWtbqCA1BERr3NORnUsdJcn5DSCwfNaw== X-Received: by 2002:a05:6a00:1786:b0:714:1d96:e6bd with SMTP id d2e1a72fcca58-7173fa7c84dmr2181901b3a.13.1725162160903; Sat, 31 Aug 2024 20:42:40 -0700 (PDT) Received: from localhost.localdomain ([49.130.72.113]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-715e55771ccsm4826767b3a.43.2024.08.31.20.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Aug 2024 20:42:40 -0700 (PDT) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, konrad.dybcio@somainline.org, Nick Chan Subject: [PATCH v3 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi Date: Sun, 1 Sep 2024 11:40:05 +0800 Message-ID: <20240901034143.12731-3-towinchenmi@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901034143.12731-1-towinchenmi@gmail.com> References: <20240901034143.12731-1-towinchenmi@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240831_204241_959333_299B72D8 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org use_fast_ipi is true by default and there is no need to "enable" it. Reviewed-by: Sven Peter Signed-off-by: Nick Chan --- drivers/irqchip/irq-apple-aic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 5c534d9fd2b0..8d81d5fb3c50 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */ off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */ - if (irqc->info.fast_ipi) - static_branch_enable(&use_fast_ipi); - else + if (!irqc->info.fast_ipi) static_branch_disable(&use_fast_ipi); irqc->info.die_stride = off - start_off;