| Message ID | 20240903-imx95-dts-new-v2-1-8ed795d61358@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: freescale: imx95: add various nodes | expand |
On Tue, Sep 03, 2024 at 03:17:46PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > With 'max-rx-timeout-ms' property added in 'Documentation/devicetree/ > indings/firmware/arm,scmi.yaml', set the value for i.MX95. > > NXP i.MX95 SCMI Firmware designation does not allow timeout, it will not > recover if the Agents use timeout design. So set a large value (5000ms) > here. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx95.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi > index ecdc6b7b5129..7880d3efbd7e 100644 > --- a/arch/arm64/boot/dts/freescale/imx95.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi > @@ -294,6 +294,8 @@ scmi { > #address-cells = <1>; > #size-cells = <0>; > Can we drop this newline? > + max-rx-timeout-ms = <5000>; max-rx-timeout-ms is an optional property. As i.MX95 SCMI firmware does not allow timeout, I wonder if absence of the property will just do the right thing? Shawn > + > scmi_devpd: protocol@11 { > reg = <0x11>; > #power-domain-cells = <1>; > > -- > 2.37.1 >
> Subject: Re: [PATCH v2 1/7] arm64: dts: freescale: imx95: set max-rx- > timeout-ms > > On Tue, Sep 03, 2024 at 03:17:46PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > With 'max-rx-timeout-ms' property added in > 'Documentation/devicetree/ > > indings/firmware/arm,scmi.yaml', set the value for i.MX95. > > > > NXP i.MX95 SCMI Firmware designation does not allow timeout, it > will > > not recover if the Agents use timeout design. So set a large value > > (5000ms) here. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx95.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi > > b/arch/arm64/boot/dts/freescale/imx95.dtsi > > index ecdc6b7b5129..7880d3efbd7e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx95.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi > > @@ -294,6 +294,8 @@ scmi { > > #address-cells = <1>; > > #size-cells = <0>; > > > > Can we drop this newline? > > > + max-rx-timeout-ms = <5000>; > > max-rx-timeout-ms is an optional property. As i.MX95 SCMI firmware > does not allow timeout, I wonder if absence of the property will just do > the right thing? The default value in driver is 30ms, this is not enough in some cases. Thanks, Peng. > > Shawn > > > + > > scmi_devpd: protocol@11 { > > reg = <0x11>; > > #power-domain-cells = <1>; > > > > -- > > 2.37.1 > >
diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi index ecdc6b7b5129..7880d3efbd7e 100644 --- a/arch/arm64/boot/dts/freescale/imx95.dtsi +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi @@ -294,6 +294,8 @@ scmi { #address-cells = <1>; #size-cells = <0>; + max-rx-timeout-ms = <5000>; + scmi_devpd: protocol@11 { reg = <0x11>; #power-domain-cells = <1>;