diff mbox series

[v2,6/7] arm64: dts: freescale: imx95-19x19-evk: add nxp,ctrl-ids property

Message ID 20240903-imx95-dts-new-v2-6-8ed795d61358@nxp.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: freescale: imx95: add various nodes | expand

Commit Message

Peng Fan (OSS) Sept. 3, 2024, 7:17 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Add 'nxp,ctrl-ids' for SCMI firmware to confirm the board ctrls as
wakeup sources.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Shawn Guo Oct. 8, 2024, 1:01 p.m. UTC | #1 
On Tue, Sep 03, 2024 at 03:17:51PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add 'nxp,ctrl-ids' for SCMI firmware to confirm the board ctrls as

s/confirm/configure?

> wakeup sources.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> index 37a1d4ca1b20..5101cd171e09 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> @@ -8,6 +8,15 @@
>  #include <dt-bindings/pwm/pwm.h>
>  #include "imx95.dtsi"
>  
> +#define FALLING_EDGE			1
> +#define RISING_EDGE			2
> +
> +#define BRD_SM_CTRL_SD3_WAKE		0x8000	/* PCAL6408A-0 */
> +#define BRD_SM_CTRL_PCIE1_WAKE		0x8001	/* PCAL6408A-4 */
> +#define BRD_SM_CTRL_BT_WAKE		0x8002	/* PCAL6408A-5 */
> +#define BRD_SM_CTRL_PCIE2_WAKE		0x8003	/* PCAL6408A-6 */
> +#define BRD_SM_CTRL_BUTTON		0x8004	/* PCAL6408A-7 */

Are these defines board specific?

Shawn

> +
>  / {
>  	model = "NXP i.MX95 19X19 board";
>  	compatible = "fsl,imx95-19x19-evk", "fsl,imx95";
> @@ -357,6 +366,14 @@ &usdhc2 {
>  	status = "okay";
>  };
>  
> +&scmi_misc {
> +	nxp,ctrl-ids = <BRD_SM_CTRL_SD3_WAKE	FALLING_EDGE
> +			BRD_SM_CTRL_PCIE1_WAKE	FALLING_EDGE
> +			BRD_SM_CTRL_BT_WAKE	FALLING_EDGE
> +			BRD_SM_CTRL_PCIE2_WAKE	FALLING_EDGE
> +			BRD_SM_CTRL_BUTTON	FALLING_EDGE>;
> +};
> +
>  &wdog3 {
>  	fsl,ext-reset-output;
>  	status = "okay";
> 
> -- 
> 2.37.1
>
Peng Fan Oct. 10, 2024, 10:32 a.m. UTC | #2 
> Subject: Re: [PATCH v2 6/7] arm64: dts: freescale: imx95-19x19-evk:
> add nxp,ctrl-ids property
> 
> On Tue, Sep 03, 2024 at 03:17:51PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add 'nxp,ctrl-ids' for SCMI firmware to confirm the board ctrls as
> 
> s/confirm/configure?

Fix in v3.

> 
> > wakeup sources.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 17
> > +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > index 37a1d4ca1b20..5101cd171e09 100644
> > --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > @@ -8,6 +8,15 @@
> >  #include <dt-bindings/pwm/pwm.h>
> >  #include "imx95.dtsi"
> >
> > +#define FALLING_EDGE			1
> > +#define RISING_EDGE			2
> > +
> > +#define BRD_SM_CTRL_SD3_WAKE		0x8000	/*
> PCAL6408A-0 */
> > +#define BRD_SM_CTRL_PCIE1_WAKE		0x8001	/*
> PCAL6408A-4 */
> > +#define BRD_SM_CTRL_BT_WAKE		0x8002	/*
> PCAL6408A-5 */
> > +#define BRD_SM_CTRL_PCIE2_WAKE		0x8003	/*
> PCAL6408A-6 */
> > +#define BRD_SM_CTRL_BUTTON		0x8004	/*
> PCAL6408A-7 */
> 
> Are these defines board specific?

Yes, board specific.

Thanks,
Peng.

> 
> Shawn
> 
> > +
> >  / {
> >  	model = "NXP i.MX95 19X19 board";
> >  	compatible = "fsl,imx95-19x19-evk", "fsl,imx95"; @@ -357,6
> +366,14
> > @@ &usdhc2 {
> >  	status = "okay";
> >  };
> >
> > +&scmi_misc {
> > +	nxp,ctrl-ids = <BRD_SM_CTRL_SD3_WAKE	FALLING_EDGE
> > +			BRD_SM_CTRL_PCIE1_WAKE
> 	FALLING_EDGE
> > +			BRD_SM_CTRL_BT_WAKE
> 	FALLING_EDGE
> > +			BRD_SM_CTRL_PCIE2_WAKE
> 	FALLING_EDGE
> > +			BRD_SM_CTRL_BUTTON	FALLING_EDGE>;
> > +};
> > +
> >  &wdog3 {
> >  	fsl,ext-reset-output;
> >  	status = "okay";
> >
> > --
> > 2.37.1
> >
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
index 37a1d4ca1b20..5101cd171e09 100644
--- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
@@ -8,6 +8,15 @@ 
 #include <dt-bindings/pwm/pwm.h>
 #include "imx95.dtsi"
 
+#define FALLING_EDGE			1
+#define RISING_EDGE			2
+
+#define BRD_SM_CTRL_SD3_WAKE		0x8000	/* PCAL6408A-0 */
+#define BRD_SM_CTRL_PCIE1_WAKE		0x8001	/* PCAL6408A-4 */
+#define BRD_SM_CTRL_BT_WAKE		0x8002	/* PCAL6408A-5 */
+#define BRD_SM_CTRL_PCIE2_WAKE		0x8003	/* PCAL6408A-6 */
+#define BRD_SM_CTRL_BUTTON		0x8004	/* PCAL6408A-7 */
+
 / {
 	model = "NXP i.MX95 19X19 board";
 	compatible = "fsl,imx95-19x19-evk", "fsl,imx95";
@@ -357,6 +366,14 @@  &usdhc2 {
 	status = "okay";
 };
 
+&scmi_misc {
+	nxp,ctrl-ids = <BRD_SM_CTRL_SD3_WAKE	FALLING_EDGE
+			BRD_SM_CTRL_PCIE1_WAKE	FALLING_EDGE
+			BRD_SM_CTRL_BT_WAKE	FALLING_EDGE
+			BRD_SM_CTRL_PCIE2_WAKE	FALLING_EDGE
+			BRD_SM_CTRL_BUTTON	FALLING_EDGE>;
+};
+
 &wdog3 {
 	fsl,ext-reset-output;
 	status = "okay";