diff mbox series

[2/3] net: xilinx: axienet: Enable NETIF_F_HW_CSUM for partial tx checksumming

Message ID 20240903184334.4150843-3-sean.anderson@linux.dev (mailing list archive)
State New
Headers show
Series net: xilinx: axienet: Partial checksum offload improvements | expand

Commit Message

Sean Anderson Sept. 3, 2024, 6:43 p.m. UTC
Partial tx chechsumming is completely generic and does not depend on the
L3/L4 protocol. Signal this to the net subsystem by enabling the
more-generic offload feature (instead of restricting ourselves to
TCP/UDP over IPv4 checksumming only like is necessary with full
checksumming).

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---

 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Sept. 4, 2024, 4:20 p.m. UTC | #1
On Tue, Sep 03, 2024 at 02:43:33PM -0400, Sean Anderson wrote:
> Partial tx chechsumming is completely generic and does not depend on the
> L3/L4 protocol. Signal this to the net subsystem by enabling the
> more-generic offload feature (instead of restricting ourselves to
> TCP/UDP over IPv4 checksumming only like is necessary with full
> checksumming).
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Reviewed-by: Simon Horman <horms@kernel.org>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 60ec430f3eb0..74fade5a95c2 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -2632,8 +2632,8 @@  static int axienet_probe(struct platform_device *pdev)
 		switch (value) {
 		case 1:
 			lp->features |= XAE_FEATURE_PARTIAL_TX_CSUM;
-			/* Can checksum TCP/UDP over IPv4. */
-			ndev->features |= NETIF_F_IP_CSUM;
+			/* Can checksum any contiguous range */
+			ndev->features |= NETIF_F_HW_CSUM;
 			break;
 		case 2:
 			lp->features |= XAE_FEATURE_FULL_TX_CSUM;