From patchwork Thu Sep 5 10:50:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 13792158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0212CD5BA9 for ; Thu, 5 Sep 2024 11:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MnGEReYZbV5wa8QJ65oYyeLT0QeGyCwvGtl5g2ahPgo=; b=zwpGOoWEbz96WcKkeDZQ+t61lH /8+/3ShUOdb+PtoDmEl14KlJott3LW/Sk/FXWp/jFJfglXGH7FbrIB2f4oX/qIL03It4e7MMRbVlF Hvv2jKkVrlkVFd+q3pHsGZi1rbPZld2rEDCmihlVTVLDpfkOok+w2KJ6UGF8pkZd0Pcq+pM43wEQX 47/pW6pGosDpfbiHX3eSYf8M9dpWzoU3s7nvv7tUcWnZiU/J8s59Ny7W3n7AlBypdTJe1me42m/Kd Ohzcvyup178foWsTol5dYbVnsnbTFrmlcUrCfHmHhM8uQ2FFSQiXrMWnLOUg78889aX8J+Ji1CtEN EwtSMFGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smAEb-000000083an-2O0V; Thu, 05 Sep 2024 11:01:05 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smA5d-000000081ZR-49IJ for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 10:51:51 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-42bbc70caa4so4764695e9.0 for ; Thu, 05 Sep 2024 03:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725533508; x=1726138308; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MnGEReYZbV5wa8QJ65oYyeLT0QeGyCwvGtl5g2ahPgo=; b=fvW9hJ8P3l+sjXlMPNfe7S6tPcvUGccCv96bPb5EN/nciKMJE+eJ3IPHftW5xF+RNb 9FLHmU4XzDeLUCylO74NzZEcISDZVEzkagBe6ACC5GHtBAAnGymEzvdy2by/EWLEQWSz zxTbiEyx2fIBgixZhjzd9lGj3sfo/yv0Df7e18HRSeaF8SGdy6EzznVOP7RhuBK1s6LM Q7VgCTyoboxsF4HFpUhxsRlVWMRfPn1P+Uiw3qeGet0awsNXiU2yURKkEUbG3KLMPgjW ZT4rzlcEATX/mSkEbjaKEamLnCPiMAWmiuEIr3a0lMB3u4xgzdX/aNAUnw/tdFHJebx+ ogBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725533508; x=1726138308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MnGEReYZbV5wa8QJ65oYyeLT0QeGyCwvGtl5g2ahPgo=; b=Rf8VCEE/BrA/wSPqpqRBTp6fjCzrqGCJDeEToWvvZ3xeTbdO9oaK0frAEnn1zaJCPJ TYWJS0yB6515JF0LylacLx0dBWL+TBEdJNBZFynsGTpPTqGA9yHDTtVqCGC4poZjDVtB kFW/FIv9TRDb32fesUDBh09j/botMKlIk800ru/DSkGPiH+095Fdjt517Rb9iD0t299h kilEez+/mQsvI0yg0fD0Oc8FEu42ffrs9rM2D7p4WVp3NeuokS5Hl6pkzaZEoGXvJDBx KXpPxEdhfT0/D+xBM0Mo9zfkQNvkr4wQxI9XkZcKsSWg/YRoYHbFxsQn96gg0aWTWCqg EitQ== X-Forwarded-Encrypted: i=1; AJvYcCUiy/XUxPCfSZ2o0TfYJGCXs3Yazym7j70UW2pNAKv9h6EvvpGo0/nrh1DvGGyEVIV+QQT1QzynjqShwr7QylcC@lists.infradead.org X-Gm-Message-State: AOJu0Yyy2vn4xdLx4V6IyjcETQRLiYO2QjRbVVAdThv2owbl8AVXxz2V UOxMtRqAX4iIsD8eLver6RWdvmveWQHiviYwOcUL5Bl95bhcsSFPMbpzMNPVjEk= X-Google-Smtp-Source: AGHT+IFLXh3uz6cqXjbXRFB+ADKQOX2EZTgrK+sgT0hn+8Lnw3zLZAPRZF6rIycBh6dNiFzAE5OxVA== X-Received: by 2002:a05:600c:b4b:b0:42c:9999:4fb3 with SMTP id 5b1f17b1804b1-42c999952dcmr18219615e9.34.1725533508196; Thu, 05 Sep 2024 03:51:48 -0700 (PDT) Received: from localhost.localdomain ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df0dbcsm231089965e9.17.2024.09.05.03.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 03:51:47 -0700 (PDT) From: James Clark To: linux-perf-users@vger.kernel.org, gankulkarni@os.amperecomputing.com, coresight@lists.linaro.org, leo.yan@arm.com, scclevenger@os.amperecomputing.com Cc: James Clark , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan , Ben Gainey , Ruidong Tian , Benjamin Gray , Mathieu Poirier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 8/8] perf test: cs-etm: Test Coresight disassembly script Date: Thu, 5 Sep 2024 11:50:39 +0100 Message-Id: <20240905105043.160225-9-james.clark@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240905105043.160225-1-james.clark@linaro.org> References: <20240905105043.160225-1-james.clark@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_035150_041223_3C671ECF X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Run a few samples through the disassembly script and check to see that at least one branch instruction is printed. Signed-off-by: James Clark --- .../tests/shell/test_arm_coresight_disasm.sh | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100755 tools/perf/tests/shell/test_arm_coresight_disasm.sh diff --git a/tools/perf/tests/shell/test_arm_coresight_disasm.sh b/tools/perf/tests/shell/test_arm_coresight_disasm.sh new file mode 100755 index 000000000000..6d004bf29f80 --- /dev/null +++ b/tools/perf/tests/shell/test_arm_coresight_disasm.sh @@ -0,0 +1,63 @@ +#!/bin/sh +# Check Arm CoreSight disassembly script completes without errors +# SPDX-License-Identifier: GPL-2.0 + +# The disassembly script reconstructs ranges of instructions and gives these to objdump to +# decode. objdump doesn't like ranges that go backwards, but these are a good indication +# that decoding has gone wrong either in OpenCSD, Perf or in the range reconstruction in +# the script. Test all 3 parts are working correctly by running the script. + +skip_if_no_cs_etm_event() { + perf list | grep -q 'cs_etm//' && return 0 + + # cs_etm event doesn't exist + return 2 +} + +skip_if_no_cs_etm_event || exit 2 + +# Assume an error unless we reach the very end +set -e +glb_err=1 + +perfdata_dir=$(mktemp -d /tmp/__perf_test.perf.data.XXXXX) +perfdata=${perfdata_dir}/perf.data +file=$(mktemp /tmp/temporary_file.XXXXX) + +cleanup_files() +{ + set +e + rm -rf ${perfdata_dir} + rm -f ${file} + trap - EXIT TERM INT + exit $glb_err +} + +trap cleanup_files EXIT TERM INT + +# Ranges start and end on branches, so check for some likely branch instructions +sep="\s\|\s" +branch_search="\sbl${sep}b${sep}b.ne${sep}b.eq${sep}cbz\s" + +## Test kernel ## +if [ -e /proc/kcore ]; then + echo "Testing kernel disassembly" + perf record -o ${perfdata} -e cs_etm//k --kcore -- touch $file > /dev/null 2>&1 + perf script -i ${perfdata} -s python:tools/perf/scripts/python/arm-cs-trace-disasm.py -- \ + -d --stop-sample=30 2> /dev/null > ${file} + grep -q -e ${branch_search} ${file} + echo "Found kernel branches" +else + # kcore is required for correct kernel decode due to runtime code patching + echo "No kcore, skipping kernel test" +fi + +## Test user ## +echo "Testing userspace disassembly" +perf record -o ${perfdata} -e cs_etm//u -- touch $file > /dev/null 2>&1 +perf script -i ${perfdata} -s python:tools/perf/scripts/python/arm-cs-trace-disasm.py -- \ + -d --stop-sample=30 2> /dev/null > ${file} +grep -q -e ${branch_search} ${file} +echo "Found userspace branches" + +glb_err=0