| Message ID | 20240906062701.37088-31-Delphine_CC_Chiu@wiwynn.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add i2c-mux and eeprom devices for Meta Yosemite 4 | expand |
Hi Delphine, Thanks for your patch! On Fri, Sep 6, 2024 at 8:35 AM Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> wrote: > Add SQ52205 in yosemite4 DTS. Please explain. > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -1245,35 +1245,35 @@ adc@37 { > }; > > power-sensor@40 { > - compatible = "ti,ina233", "richtek,rtq6056"; > + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; At first sight, this looks wrong. However, these three all seem to be functionally equivalent power monitors. Are they software compatible too? There are also no DT bindings to guide us, except for the rtq6056 part. > reg = <0x40>; > resistor-calibration = /bits/ 16 <0x0400>; > current-lsb= /bits/ 16 <0x0001>; > }; Gr{oetje,eeting}s, Geert
On 06/09/2024 08:26, Delphine CC Chiu wrote: > Add SQ52205 in yosemite4 DTS. No, that's not what your commit is doing. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index d056f6d5ff6e..04aa428f94b7 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -1245,35 +1245,35 @@ adc@37 { > }; > > power-sensor@40 { > - compatible = "ti,ina233", "richtek,rtq6056"; > + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; Why are you changing same line multiple times? It does not make any sense. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index d056f6d5ff6e..04aa428f94b7 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -1245,35 +1245,35 @@ adc@37 { }; power-sensor@40 { - compatible = "ti,ina233", "richtek,rtq6056"; + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; reg = <0x40>; resistor-calibration = /bits/ 16 <0x0400>; current-lsb= /bits/ 16 <0x0001>; }; power-sensor@41 { - compatible = "ti,ina233", "richtek,rtq6056"; + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; reg = <0x41>; resistor-calibration = /bits/ 16 <0x0400>; current-lsb= /bits/ 16 <0x0001>; }; power-sensor@42 { - compatible = "ti,ina233", "richtek,rtq6056"; + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; reg = <0x42>; resistor-calibration = /bits/ 16 <0x0400>; current-lsb= /bits/ 16 <0x0001>; }; power-sensor@43 { - compatible = "ti,ina233", "richtek,rtq6056"; + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; reg = <0x43>; resistor-calibration = /bits/ 16 <0x0400>; current-lsb= /bits/ 16 <0x0001>; }; power-sensor@44 { - compatible = "ti,ina233", "richtek,rtq6056"; + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205"; reg = <0x44>; resistor-calibration = /bits/ 16 <0x0400>; current-lsb= /bits/ 16 <0x0001>;
Add SQ52205 in yosemite4 DTS. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)