From patchwork Fri Sep 6 08:23:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13793668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9862CE7AE6 for ; Fri, 6 Sep 2024 08:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxDICx00vfY2911n+vCONspv/9sxQx5IOKpiGzU6GX0=; b=OsupKWgxg+ljB0pwIFCRxWvATY eQOUcZXrSA8V7ka0MF7iYX/S8Y4fPC7xh4fYDreHWfmIYYMY6fhuBIN/sbAWUhN9Ukd5gpNHtMAKf BaZrEX82RhCrrBr0PBkAR2lnsLjZTF0b4oFauwdvVMdaxSCIJy0nR1ql426K1/Raa73g0rqaiMiwD ixsbidiykp8eqd+YAdkc2UzMnb0M6YThAmjthyHGFCflon81fEPS0H2eKvsWTTivLDmgsBTiYRvFd LVMGa4k5GO9iTYYsnKOrm72G8emLgmGiac/MrjSRcl68kiWviu0v2v00ahDx/tFdkt4K2/FgISwwX bqQavjGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smUCG-0000000BHcb-3Ocn; Fri, 06 Sep 2024 08:20:01 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smU7Q-0000000BFv4-17Hd for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2024 08:15:02 +0000 Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4X0TXh5DByz1j8D4; Fri, 6 Sep 2024 16:14:28 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 4E0BB1400DB; Fri, 6 Sep 2024 16:14:51 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 6 Sep 2024 16:14:50 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: Subject: [PATCH 4/5] drm/tegra: dpaux: Use IRQF_NO_AUTOEN flag in request_irq() Date: Fri, 6 Sep 2024 16:23:24 +0800 Message-ID: <20240906082325.2677621-5-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240906082325.2677621-1-ruanjinjie@huawei.com> References: <20240906082325.2677621-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemh500013.china.huawei.com (7.202.181.146) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240906_011500_596718_C681843B X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9e532b3ad9a7 ("drm/tegra: dpaux: Disable interrupt when detached") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/tegra/dpaux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index ae12d001a04b..9646dba950e0 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm/tegra/dpaux.c @@ -517,7 +517,7 @@ static int tegra_dpaux_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); pm_runtime_get_sync(&pdev->dev); - err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq, 0, + err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq, IRQF_NO_AUTOEN, dev_name(dpaux->dev), dpaux); if (err < 0) { dev_err(dpaux->dev, "failed to request IRQ#%u: %d\n", @@ -525,8 +525,6 @@ static int tegra_dpaux_probe(struct platform_device *pdev) goto err_pm_disable; } - disable_irq(dpaux->irq); - dpaux->aux.transfer = tegra_dpaux_transfer; dpaux->aux.dev = &pdev->dev;