From patchwork Sat Sep 7 11:06:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13795196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 075A9E71080 for ; Sat, 7 Sep 2024 11:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A3+BuB4FjLqD9bjbDGs2bz07cEq00t/CZQx8ir7y0gU=; b=iuYLLsTnEmcH4/xEs4uFYvYHRk ytFb1v27EO7ho7xVlkEnJwr/vnvrn2qv/Y/rRG9PcGYpKmw4EA31OcuQtRhZWFDoxCy0NeY53hO1a 0bPNF4XZCP+aFpioT5NR50CG82Ny/MQuIL45vBj7KjW96HZjUvj78PZiZk+wg5YDKHZnKrbyrmkqp 6qQ43BQMMKGR7RZdnVIilhuF58YMMvl2Vq+SlCxKNOD0v+PzpWCYfm+ZgSc0tuEoq0ceHc285cElE YEms6ZnLwSWPU6udsCN/I4mlwsMt56urF0U8rPM27PMMhwZMUVX5sSP/qAHslyng4PvpUpYEdmmNk inQ/vtQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smtQy-0000000Eu09-0bA5; Sat, 07 Sep 2024 11:16:52 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smtP4-0000000Etik-3wZh for linux-arm-kernel@lists.infradead.org; Sat, 07 Sep 2024 11:14:56 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2055a3f80a4so21688565ad.2 for ; Sat, 07 Sep 2024 04:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725707694; x=1726312494; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A3+BuB4FjLqD9bjbDGs2bz07cEq00t/CZQx8ir7y0gU=; b=GFXp/qqFcQZeSRLqFRopR6lolkaoTGR8HJrjM+pEd446kvOTwRWe540MOZ2sh0k851 Enln/TcziqYYDprFaUGnPXwZrGp50XK1vUdB2IN89mtZ/WNP0LqOwiVK1bosjDpJ/VnA 9ySdFvMV2m49VzcThM0DL/lDIOU+o6Nfs5ibR1tfvflviAu6Udjz7itEBrQn0ZKoEFfA MQEkj6P1rGa0AxhtJxdtQ1EWLII0Y1UdhtdP8YPb/PJSat+K2djfXMfU4omVcHGZqYck lcWeaj0i0Gnayjm2tVVgpUheYG5/Lh5wry+cHKe1pomCwWluXlynKRp7PnaAxuz+dpmD 04Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725707694; x=1726312494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A3+BuB4FjLqD9bjbDGs2bz07cEq00t/CZQx8ir7y0gU=; b=MBUcVD1myVMgGGDEbztjOrjjPXiqTyZWnLP/lQ402N5iwxLMW0wrWUNvwy1BiSV4TF g1Vob92sk/bnNmwx5SyV77vw6ywhJDUZYrMZAJTskQPFbUn7HDqnuCfqJWQEiaBdz0s7 /8lEq5HCSnYq9Ozipz084P9tqoAvxetR7JU3alz0rvnPToaxvTgTlxpQplsRlpKDOcSi 1BgKLCqZGunt4eSOq1c7BkgOY+X5M+6mhGb+2SGbZtpjzidvmQVCoeqxu6JdPrApFlUk X9yB98jQg0Qnc5ik4Ie18S1Bfq6ewfG9FJ4yXUFVm7d/pN2RHZISkT3pjZJO8TXWe5U1 hopA== X-Forwarded-Encrypted: i=1; AJvYcCW0Z4taMaaM81xVq9miGPx33GvpF01uDZnLKW7w3E3hY/vJc72b94JBxJHEkpKlbTzGHJJM7/yqeaFfGbh+fY6f@lists.infradead.org X-Gm-Message-State: AOJu0YyOcwuTzUIgJbgC96FSqVR7xeqdoVZROKnZi4+LG7jhvwMgxHoj mRJmKeIljzyN47Qw4NFQ5E+ukaywpF+50tR0nICVNiquVG84hFZLWZOTd0HMe90= X-Google-Smtp-Source: AGHT+IG+d/Ja+M6I/KKbLW1L9kR7tYcT+FpvaTcOzSQ8w/aHxuNDIEwCeGvjU3MYj7ZC8/xGYSOn0A== X-Received: by 2002:a17:902:ccce:b0:205:8bad:171c with SMTP id d9443c01a7336-206f04e1a7bmr65926405ad.12.1725707693732; Sat, 07 Sep 2024 04:14:53 -0700 (PDT) Received: from localhost.localdomain ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-20710e1addbsm7186955ad.58.2024.09.07.04.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Sep 2024 04:14:53 -0700 (PDT) From: Nick Chan To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: asahi@lists.linux.dev, Nick Chan Subject: [PATCH 1/2] tty: serial: samsung: Fix A7-A11 serial earlycon SError Date: Sat, 7 Sep 2024 19:06:44 +0800 Message-ID: <20240907111431.2970-2-towinchenmi@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240907111431.2970-1-towinchenmi@gmail.com> References: <20240907111431.2970-1-towinchenmi@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_041455_126943_803A43ED X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Apple's earlier SoCs, like A7-A11, requires 32-bit writes for the serial port. Otherwise, a SError happens when writing to UTXH (+0x20). This only manifested in earlycon as reg-io-width in the device tree is consulted for normal serial writes. Change the iotype of the port to UPIO_MEM32, to allow the serial port to function on A7-A11 SoCs. This change does not appear to affect Apple M1 and above. Signed-off-by: Nick Chan Reviewed-by: Krzysztof Kozlowski --- drivers/tty/serial/samsung_tty.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index c4f2ac9518aa..27b8a50bd3e7 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2536,7 +2536,7 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = { .name = "Apple S5L UART", .type = TYPE_APPLE_S5L, .port_type = PORT_8250, - .iotype = UPIO_MEM, + .iotype = UPIO_MEM32, .fifosize = 16, .rx_fifomask = S3C2410_UFSTAT_RXMASK, .rx_fifoshift = S3C2410_UFSTAT_RXSHIFT, @@ -2825,8 +2825,10 @@ static int __init apple_s5l_early_console_setup(struct earlycon_device *device, /* Close enough to S3C2410 for earlycon... */ device->port.private_data = &s3c2410_early_console_data; + /* ... however, we need to change the port iotype */ + device->port.iotype = UPIO_MEM32; #ifdef CONFIG_ARM64 - /* ... but we need to override the existing fixmap entry as nGnRnE */ + /* ... and also override the existing fixmap entry as nGnRnE */ __set_fixmap(FIX_EARLYCON_MEM_BASE, device->port.mapbase, __pgprot(PROT_DEVICE_nGnRnE)); #endif