From patchwork Mon Sep 9 06:14:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13795927 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CDADCD4F4C for ; Mon, 9 Sep 2024 06:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pDBROiWs+lKpZTVdIwf8Y1JW/xnZSzHUlUHGFZPuMDY=; b=B79/MfKHtt2KiEE5h6TK/6FRvE m/OMh9MZuE8pppruwHcuOOfpMdeBpKTq88iE5bLePhTp5jJbH4M5MxLvx4LAgh1FPOfhbm7wBaCXI QAvxrrBa3LdVW2SpkEY3k54dYjJNkjaVvLbvbeTGaKNZcimqacWmNq7HsYD4jVfA4pRaH9O5z8AyX KXg+0o7khrnM4pqVlOYO68i/0yhfC+UkPYG07rX42tyG2gWu119WSEVxqgIBdj9fVOabuvn9uqMCn cQjl5B+jPtx4E+90oqX18cm8BvfKSj+VWwnWQBZgIuCEhv2dR25lkjwKsAd/1KUg4CSje0F6CSQXg XDZNOngQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snXoP-00000000cSB-3ptF; Mon, 09 Sep 2024 06:23:45 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snXgO-00000000bNj-2OFc; Mon, 09 Sep 2024 06:15:29 +0000 Received: from localhost.localdomain (unknown [IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 107F2890; Mon, 9 Sep 2024 08:14:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1725862451; bh=ujNT/+9sjUT3Wg0kRSIVEZGaFnbYwTMPEIpDs6npcnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lgtuorkVEVvDPc0/hMUoq9gz5q25cJpx9423sVI1xOmvF64GMzJN+FjEyxa82ku4c jClzQZtBJKNYpZIQxqMnTY+cf2Uw6pu4FeCX31OOST1LeHeg6TdeCnCv/j3R9CuCW8 2472WMJR281WJqrqyyctgdaL9T99t9vIJVpA98b0= From: Umang Jain To: Broadcom internal kernel review list , Greg Kroah-Hartman Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Kieran Bingham , Arnd Bergmann , Stefan Wahren , Laurent Pinchart , Umang Jain Subject: [PATCH v5 7/7] staging: vchiq_core: Pass enumerated flag instead of int Date: Mon, 9 Sep 2024 11:44:57 +0530 Message-ID: <20240909061457.255452-8-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240909061457.255452-1-umang.jain@ideasonboard.com> References: <20240909061457.255452-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240908_231528_765299_66921F77 X-CRM114-Status: UNSURE ( 7.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pass proper enumerated flag which exists, instead of an integer while calling queue_message(). It helps with readability of the code. Signed-off-by: Umang Jain Reviewed-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 85b6f413d3e4..b3b0f8235670 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -3126,7 +3126,8 @@ vchiq_queue_message(struct vchiq_instance *instance, unsigned int handle, switch (service->srvstate) { case VCHIQ_SRVSTATE_OPEN: status = queue_message(service->state, service, data_id, - copy_callback, context, size, 1); + copy_callback, context, size, + QMFLAGS_IS_BLOCKING); break; case VCHIQ_SRVSTATE_OPENSYNC: status = queue_message_sync(service->state, service, data_id,