diff mbox series

[v4,1/5] dt-bindings: arm: airoha: Add the chip-scu node for EN7581 SoC

Message ID 20240911-en7581-pinctrl-v4-1-60ac93d760bb@kernel.org (mailing list archive)
State New
Headers show
Series Add mfd, pinctrl and pwm support to EN7581 SoC | expand

Commit Message

Lorenzo Bianconi Sept. 11, 2024, 7:50 p.m. UTC
This patch adds the chip-scu document bindings for EN7581 SoC.
The airoha chip-scu block provides a configuration interface for clock,
io-muxing and other functionalities used by multiple controllers (e.g.
clock, pinctrl, ecc.) on EN7581 SoC.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 .../bindings/arm/airoha,en7581-chip-scu.yaml       | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)

Comments

Rob Herring (Arm) Sept. 11, 2024, 9:12 p.m. UTC | #1
On Wed, 11 Sep 2024 21:50:01 +0200, Lorenzo Bianconi wrote:
> This patch adds the chip-scu document bindings for EN7581 SoC.
> The airoha chip-scu block provides a configuration interface for clock,
> io-muxing and other functionalities used by multiple controllers (e.g.
> clock, pinctrl, ecc.) on EN7581 SoC.
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../bindings/arm/airoha,en7581-chip-scu.yaml       | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240911-en7581-pinctrl-v4-1-60ac93d760bb@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Lorenzo Bianconi Sept. 11, 2024, 9:46 p.m. UTC | #2
> 
> On Wed, 11 Sep 2024 21:50:01 +0200, Lorenzo Bianconi wrote:
> > This patch adds the chip-scu document bindings for EN7581 SoC.
> > The airoha chip-scu block provides a configuration interface for clock,
> > io-muxing and other functionalities used by multiple controllers (e.g.
> > clock, pinctrl, ecc.) on EN7581 SoC.
> > 
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../bindings/arm/airoha,en7581-chip-scu.yaml       | 42 ++++++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> 
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240911-en7581-pinctrl-v4-1-60ac93d760bb@kernel.org
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

Hi Rob,

before posting the series I run make dt_binding_check:

$ make dt_binding_check DT_SCHEMA_FILES=airoha
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  CHKDT   Documentation/devicetree/bindings
  LINT    Documentation/devicetree/bindings
  DTC_CHK Documentation/devicetree/bindings/arm/airoha.example.dtb
  DTEX    Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.example.dts
  DTC_CHK Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.example.dtb
  DTC_CHK Documentation/devicetree/bindings/clock/airoha,en7523-scu.example.dtb
  DTC_CHK Documentation/devicetree/bindings/net/airoha,en7581-eth.example.dtb
  DTC_CHK Documentation/devicetree/bindings/net/airoha,en8811h.example.dtb
  DTC_CHK Documentation/devicetree/bindings/gpio/airoha,en7523-gpio.example.dtb
  DTC_CHK Documentation/devicetree/bindings/spi/airoha,en7581-snand.example.dtb
  DTC_CHK Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.example.dtb

$yamllint --version
yamllint 1.35.1

dtschema is at the latest version.
Is it a false positive or am I missing something?

Regards,
Lorenzo
Rob Herring (Arm) Sept. 12, 2024, 4:43 p.m. UTC | #3
On Wed, Sep 11, 2024 at 11:46:11PM +0200, Lorenzo Bianconi wrote:
> > 
> > On Wed, 11 Sep 2024 21:50:01 +0200, Lorenzo Bianconi wrote:
> > > This patch adds the chip-scu document bindings for EN7581 SoC.
> > > The airoha chip-scu block provides a configuration interface for clock,
> > > io-muxing and other functionalities used by multiple controllers (e.g.
> > > clock, pinctrl, ecc.) on EN7581 SoC.
> > > 
> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > ---
> > >  .../bindings/arm/airoha,en7581-chip-scu.yaml       | 42 ++++++++++++++++++++++
> > >  1 file changed, 42 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > 
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240911-en7581-pinctrl-v4-1-60ac93d760bb@kernel.org
> > 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> > 
> 
> Hi Rob,
> 
> before posting the series I run make dt_binding_check:
> 
> $ make dt_binding_check DT_SCHEMA_FILES=airoha

Technically, you have to run it without DT_SCHEMA_FILES as sometimes 
there is interaction with other schemas.

>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   CHKDT   Documentation/devicetree/bindings
>   LINT    Documentation/devicetree/bindings
>   DTC_CHK Documentation/devicetree/bindings/arm/airoha.example.dtb
>   DTEX    Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.example.dts
>   DTC_CHK Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.example.dtb
>   DTC_CHK Documentation/devicetree/bindings/clock/airoha,en7523-scu.example.dtb
>   DTC_CHK Documentation/devicetree/bindings/net/airoha,en7581-eth.example.dtb
>   DTC_CHK Documentation/devicetree/bindings/net/airoha,en8811h.example.dtb
>   DTC_CHK Documentation/devicetree/bindings/gpio/airoha,en7523-gpio.example.dtb
>   DTC_CHK Documentation/devicetree/bindings/spi/airoha,en7581-snand.example.dtb
>   DTC_CHK Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.example.dtb
> 
> $yamllint --version
> yamllint 1.35.1
> 
> dtschema is at the latest version.
> Is it a false positive or am I missing something?

Looks like something went sideways. Will look into it. You can ignore 
this.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
new file mode 100644
index 000000000000..67c449d804c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
@@ -0,0 +1,42 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/airoha,en7581-chip-scu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha Chip SCU Controller for EN7581 SoC
+
+maintainers:
+  - Lorenzo Bianconi <lorenzo@kernel.org>
+
+description:
+  The airoha chip-scu block provides a configuration interface for clock,
+  io-muxing and other functionalities used by multiple controllers (e.g. clock,
+  pinctrl, ecc) on EN7581 SoC.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - airoha,en7581-chip-scu
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    soc {
+      #address-cells = <2>;
+      #size-cells = <2>;
+      syscon@1fa20000 {
+        compatible = "airoha,en7581-chip-scu", "syscon";
+        reg = <0x0 0x1fa20000 0x0 0x388>;
+      };
+    };