| Message ID | 20240911-topic-amlogic-arm32-upstream-bindings-fixes-v1-4-feaabb45916b@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: amlogic: first easy dtbs fixes | expand |
Hi Neil, On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6, > fixing the following check errors: > audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b'] > from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# > audio-controller@5400: compatible: ['amlogic,aiu'] is too short > from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# > /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm'] > /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm'] > phy@8800: compatible: 'oneOf' conditional failed, one must be fixed: > ['amlogic,meson-mx-usb2-phy'] is too short > 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] > 'amlogic,meson-gxbb-usb2-phy' was expected > from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# > phy@8820: compatible: 'oneOf' conditional failed, one must be fixed: > ['amlogic,meson-mx-usb2-phy'] is too short > 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] > 'amlogic,meson-gxbb-usb2-phy' was expected > from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# > /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio'] > mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc'] > from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# > mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short > from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# > remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc'] > from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# > remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short > from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Generally I'm fine with this. I'm wondering if we should go one step further by decommissioning Meson6 support? To be specific here, I'm thinking of removing MACH_MESON6 from arch/arm/mach-meson/Kconfig and deleting meson6{.dtsi,-atv1200.dts} I don't have any boards with Meson6 SoC, there's no upstream GPIO, pinctrl, clock, MMC, <you name it> driver for that SoC either. So all we have upstream is the ability to boot to initramfs and use serial console(s). If someone is interested in Meson6 support they should bring it back along with a few more patches for upstream support of further peripherals. Best regards, Martin
> On 15 Sep 2024, at 11:12 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hi Neil, > > On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong > <neil.armstrong@linaro.org> wrote: >> >> Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6, >> fixing the following check errors: >> audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b'] >> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# >> audio-controller@5400: compatible: ['amlogic,aiu'] is too short >> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# >> /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm'] >> /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm'] >> phy@8800: compatible: 'oneOf' conditional failed, one must be fixed: >> ['amlogic,meson-mx-usb2-phy'] is too short >> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] >> 'amlogic,meson-gxbb-usb2-phy' was expected >> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# >> phy@8820: compatible: 'oneOf' conditional failed, one must be fixed: >> ['amlogic,meson-mx-usb2-phy'] is too short >> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] >> 'amlogic,meson-gxbb-usb2-phy' was expected >> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# >> /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio'] >> mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc'] >> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# >> mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short >> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# >> remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc'] >> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# >> remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short >> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > Generally I'm fine with this. I'm wondering if we should go one step > further by decommissioning Meson6 support? > To be specific here, I'm thinking of removing MACH_MESON6 from > arch/arm/mach-meson/Kconfig and deleting meson6{.dtsi,-atv1200.dts} > > I don't have any boards with Meson6 SoC, there's no upstream GPIO, > pinctrl, clock, MMC, <you name it> driver for that SoC either. > So all we have upstream is the ability to boot to initramfs and use > serial console(s). > If someone is interested in Meson6 support they should bring it back > along with a few more patches for upstream support of further > peripherals. I think that’s a sensible move. LibreELEC was one of the few distros that supported Meson6 hardware in the past (via the vendor kernel) but we ended support in 2018. Meson6 devices are mostly/all? cheap Android boxes dating from 2011-2013 and these have either been been discarded by users through upgrades or the boxes died long ago. There is still community interest in supporting Meson8 boards (the 8x core devices are used for retro-gaming) but not the earlier Meson6 ones. Christian
On 16/09/2024 07:57, Christian Hewitt wrote: >> On 15 Sep 2024, at 11:12 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: >> >> Hi Neil, >> >> On Wed, Sep 11, 2024 at 12:19 PM Neil Armstrong >> <neil.armstrong@linaro.org> wrote: >>> >>> Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6, >>> fixing the following check errors: >>> audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b'] >>> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# >>> audio-controller@5400: compatible: ['amlogic,aiu'] is too short >>> from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# >>> /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm'] >>> /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm'] >>> phy@8800: compatible: 'oneOf' conditional failed, one must be fixed: >>> ['amlogic,meson-mx-usb2-phy'] is too short >>> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] >>> 'amlogic,meson-gxbb-usb2-phy' was expected >>> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# >>> phy@8820: compatible: 'oneOf' conditional failed, one must be fixed: >>> ['amlogic,meson-mx-usb2-phy'] is too short >>> 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] >>> 'amlogic,meson-gxbb-usb2-phy' was expected >>> from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# >>> /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio'] >>> mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc'] >>> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# >>> mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short >>> from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# >>> remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc'] >>> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# >>> remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short >>> from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# >>> >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> Generally I'm fine with this. I'm wondering if we should go one step >> further by decommissioning Meson6 support? >> To be specific here, I'm thinking of removing MACH_MESON6 from >> arch/arm/mach-meson/Kconfig and deleting meson6{.dtsi,-atv1200.dts} >> >> I don't have any boards with Meson6 SoC, there's no upstream GPIO, >> pinctrl, clock, MMC, <you name it> driver for that SoC either. >> So all we have upstream is the ability to boot to initramfs and use >> serial console(s). >> If someone is interested in Meson6 support they should bring it back >> along with a few more patches for upstream support of further >> peripherals. > > I think that’s a sensible move. LibreELEC was one of the few distros > that supported Meson6 hardware in the past (via the vendor kernel) > but we ended support in 2018. Meson6 devices are mostly/all? cheap > Android boxes dating from 2011-2013 and these have either been been > discarded by users through upgrades or the boxes died long ago. There > is still community interest in supporting Meson8 boards (the 8x core > devices are used for retro-gaming) but not the earlier Meson6 ones. Yeah let's remove meson6 dtsi for v6.13, I'll respin this serie but with the meson6 removal and some more dts fixes. Neil > > Christian
diff --git a/arch/arm/boot/dts/amlogic/meson6.dtsi b/arch/arm/boot/dts/amlogic/meson6.dtsi index 1c4ea7266f66..8952c086d069 100644 --- a/arch/arm/boot/dts/amlogic/meson6.dtsi +++ b/arch/arm/boot/dts/amlogic/meson6.dtsi @@ -43,6 +43,10 @@ clk81: clk81 { }; }; /* end of / */ +/delete-node/ &aiu; + +/delete-node/ &ao_arc_rproc; + &efuse { status = "disabled"; }; @@ -71,3 +75,15 @@ &uart_C { clocks = <&xtal>, <&clk81>, <&clk81>; clock-names = "xtal", "pclk", "baud"; }; + +/delete-node/ &pwm_ab; +/delete-node/ &pwm_cd; + +/delete-node/ &sdhc; +/delete-node/ &sdio; + +/delete-node/ &usb0; +/delete-node/ &usb1; + +/delete-node/ &usb0_phy; +/delete-node/ &usb1_phy;
Delete nodes in meson6.dtsi that are clearly undocumented & unused for meson6, fixing the following check errors: audio-controller@5400: compatible:0: 'amlogic,aiu' is not one of ['amlogic,aiu-gxbb', 'amlogic,aiu-gxl', 'amlogic,aiu-meson8', 'amlogic,aiu-meson8b'] from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# audio-controller@5400: compatible: ['amlogic,aiu'] is too short from schema $id: http://devicetree.org/schemas/sound/amlogic,aiu.yaml# /soc/bus@c1100000/pwm@8550: failed to match any schema with compatible: ['amlogic,meson-pwm'] /soc/bus@c1100000/pwm@8650: failed to match any schema with compatible: ['amlogic,meson-pwm'] phy@8800: compatible: 'oneOf' conditional failed, one must be fixed: ['amlogic,meson-mx-usb2-phy'] is too short 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] 'amlogic,meson-gxbb-usb2-phy' was expected from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# phy@8820: compatible: 'oneOf' conditional failed, one must be fixed: ['amlogic,meson-mx-usb2-phy'] is too short 'amlogic,meson-mx-usb2-phy' is not one of ['amlogic,meson8-usb2-phy', 'amlogic,meson8b-usb2-phy', 'amlogic,meson8m2-usb2-phy'] 'amlogic,meson-gxbb-usb2-phy' was expected from schema $id: http://devicetree.org/schemas/phy/amlogic,meson8b-usb2-phy.yaml# /soc/bus@c1100000/mmc@8c20: failed to match any schema with compatible: ['amlogic,meson-mx-sdio'] mmc@8e00: compatible:0: 'amlogic,meson-mx-sdhc' is not one of ['amlogic,meson8-sdhc', 'amlogic,meson8b-sdhc', 'amlogic,meson8m2-sdhc'] from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# mmc@8e00: compatible: ['amlogic,meson-mx-sdhc'] is too short from schema $id: http://devicetree.org/schemas/mmc/amlogic,meson-mx-sdhc.yaml# remoteproc@1c: compatible:0: 'amlogic,meson-mx-ao-arc' is not one of ['amlogic,meson8-ao-arc', 'amlogic,meson8b-ao-arc'] from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# remoteproc@1c: compatible: ['amlogic,meson-mx-ao-arc'] is too short from schema $id: http://devicetree.org/schemas/remoteproc/amlogic,meson-mx-ao-arc.yaml# Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm/boot/dts/amlogic/meson6.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)