diff mbox series

[v3,01/24] arm64: Drop SKL0/SKL1 from TCR2_EL2

Message ID 20240911135151.401193-2-maz@kernel.org (mailing list archive)
State New, archived
Headers show
Series KVM: arm64: Add EL2 support to FEAT_S1PIE | expand

Commit Message

Marc Zyngier Sept. 11, 2024, 1:51 p.m. UTC
Despite what the documentation says, TCR2_EL2.{SKL0,SKL1} do not exist,
and the corresponding information is in the respective TTBRx_EL2. This
is a leftover from a development version of the architecture.

This change makes TCR2_EL2 similar to TCR2_EL1 in that respect.

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 arch/arm64/tools/sysreg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Joey Gouly Sept. 12, 2024, 10:22 a.m. UTC | #1
On Wed, Sep 11, 2024 at 02:51:28PM +0100, Marc Zyngier wrote:
> Despite what the documentation says, TCR2_EL2.{SKL0,SKL1} do not exist,
> and the corresponding information is in the respective TTBRx_EL2. This
> is a leftover from a development version of the architecture.
> 
> This change makes TCR2_EL2 similar to TCR2_EL1 in that respect.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---

Confirmed this should eventually be part of the Known Issues doc.

Reviewed-by: Joey Gouly <joey.gouly@arm.com>

>  arch/arm64/tools/sysreg | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 7ceaa1e0b4bc2..27c71fe3952f1 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -2789,8 +2789,7 @@ Field	13	AMEC1
>  Field	12	AMEC0
>  Field	11	HAFT
>  Field	10	PTTWI
> -Field	9:8	SKL1
> -Field	7:6	SKL0
> +Res0	9:6
>  Field	5	D128
>  Field	4	AIE
>  Field	3	POE
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 7ceaa1e0b4bc2..27c71fe3952f1 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2789,8 +2789,7 @@  Field	13	AMEC1
 Field	12	AMEC0
 Field	11	HAFT
 Field	10	PTTWI
-Field	9:8	SKL1
-Field	7:6	SKL0
+Res0	9:6
 Field	5	D128
 Field	4	AIE
 Field	3	POE