From patchwork Wed Sep 11 21:27:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Chevallier X-Patchwork-Id: 13801146 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A800EE57D7 for ; Wed, 11 Sep 2024 21:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YpnVXCGpzg8hKqd/cYNHTq4PwBhP9+SSj5neYt5kd/M=; b=Rjt/uIqYCUUTaJuH9HMsaKU1qt bfxcbWzkGT8fd7st4UffpmWlrv79EiVsOlGgFSO4y6PW3FcdJ5+v21YIPo9ZhS4lk5XqgezlYYhrI //8w551mz43PdCJ3O/vlmV/3MivUm8vZTKl7+ojDFNoroZf2FlTBLP6wuzEhjp+R7nt3yHbxWwGAd 8lH78CJMySoJtoJqtAo1kIJYKnxW7VZqyhVhK9hF9Fz9VTk0Wp5QTUWUbWSYppjJKXKV4fMNOD/KM zPmqeps7lhdaxEor8ex1nbHiVJ+s04FghnXEgEoX0dYPeRbx+mBhU3T9/u7lwqQDBJ9TKHYaoNPrU ToPpN1pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soV07-0000000B4dG-1Um8; Wed, 11 Sep 2024 21:35:47 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soUs3-0000000B3Du-2Iut for linux-arm-kernel@bombadil.infradead.org; Wed, 11 Sep 2024 21:27:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=YpnVXCGpzg8hKqd/cYNHTq4PwBhP9+SSj5neYt5kd/M=; b=mL+uCMxgxpGTz+8pZOK95Qc/Xr vXZgHAG6qJixDLpV73OZHtpaeePEgP6YLyq89czscy/XDs3Cq4anxAEb/CGXFu+sbxFVf9tCEFWuR 7BwxL+7+nlEH+js56SUCMNhAB98JOM3OKSeCVYGFvTh41oqO61ZVxP8bSl5ByPtLCFAjubWgZHPrk GtD68oeiTK+Ae4wDTk57GxiOr8Wj7NA1rNVsKR1fXjge8wLFHrpfslRAcfkGNH1kCsSEW9ZxspujV aaURT2gwCoQQAlmHP9IhCD3f61SlcyTky7hsPKYbzaSV2F8mz7UtMXfVofOsgXbBCB6sqVY4ah1mi 0wu8/pCg==; Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1soUs0-00000000F6E-0xyo for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 21:27:26 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 40A321C0006; Wed, 11 Sep 2024 21:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1726090040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YpnVXCGpzg8hKqd/cYNHTq4PwBhP9+SSj5neYt5kd/M=; b=STJeG49ScfgmHR/SVqSBb4CbUMUsN9gDTA7yrzwfVGz9f8mnlIkqxkDWLLdngWBStaUMca Cy3nwPKET+P8w/V4d3nTDwDlbQJ88XKea6pOO/54KJqRw/890q9A22/3UGOGUoFl10RAvI CROGkPBaRgUBTmrDzKZWVhL+ubYZvBNc7lj1S4s5BsKUEEhRGD4X83OyKjY8oS2FwVYX9U gKweNOnmUQuTNH+OWmv0SVsaZaPZCuZHmybCKyZ96sNZuEbfCiQ6FKyxUmOjVm3iP9L66U UlGhSnYPSCks6hXq5pervRRW/6YkhA0/TQ9s85TcJQp7wjub5pK+srlYBNR7yQ== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?utf-8?q?Marek_Beh=C3=BAn?= , =?utf-8?q?K=C3=B6ry_Maince?= =?utf-8?q?nt?= , Oleksij Rempel Subject: [PATCH net-next 3/7] net: phy: lxt: Mark LXT973 PHYs as having a broken isolate mode Date: Wed, 11 Sep 2024 23:27:07 +0200 Message-ID: <20240911212713.2178943-4-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240911212713.2178943-1-maxime.chevallier@bootlin.com> References: <20240911212713.2178943-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_222724_455838_A5AF913B X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Testing showed that PHYs from the LXT973 family have a non-working isolate mode, where the MII lines aren't set in high-impedance as would be expected. Prevent isolating these PHYs. Signed-off-by: Maxime Chevallier --- drivers/net/phy/lxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c index e3bf827b7959..55cf67391533 100644 --- a/drivers/net/phy/lxt.c +++ b/drivers/net/phy/lxt.c @@ -334,6 +334,7 @@ static struct phy_driver lxt97x_driver[] = { .read_status = lxt973a2_read_status, .suspend = genphy_suspend, .resume = genphy_resume, + .flags = PHY_NO_ISOLATE, }, { .phy_id = 0x00137a10, .name = "LXT973", @@ -344,6 +345,7 @@ static struct phy_driver lxt97x_driver[] = { .config_aneg = lxt973_config_aneg, .suspend = genphy_suspend, .resume = genphy_resume, + .flags = PHY_NO_ISOLATE, } }; module_phy_driver(lxt97x_driver);