diff mbox series

[v2,4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver

Message ID 20240913082937.444367-5-andrei.stefanescu@oss.nxp.com (mailing list archive)
State New
Headers show
Series gpio: siul2-s32g2: add initial GPIO driver | expand

Commit Message

Andrei Stefanescu Sept. 13, 2024, 8:29 a.m. UTC 
Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg KH Sept. 13, 2024, 11:05 a.m. UTC | #1 
On Fri, Sep 13, 2024 at 11:29:35AM +0300, Andrei Stefanescu wrote:
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>

For obvious reasons, we can't take patches without any changelog text,
even for simple stuff.

thanks,

greg k-h
Andrei Stefanescu Sept. 13, 2024, 12:33 p.m. UTC | #2 
Hi Greg,

On 13/09/2024 14:05, Greg Kroah-Hartman wrote:
> On Fri, Sep 13, 2024 at 11:29:35AM +0300, Andrei Stefanescu wrote:
>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
> 
> For obvious reasons, we can't take patches without any changelog text,
> even for simple stuff.
> 
> thanks,
> 
> greg k-h


Thank you! I will fix it in v3.

Best regards,
Andrei
Krzysztof Kozlowski Sept. 17, 2024, 5:44 p.m. UTC | #3 
On 13/09/2024 10:29, Andrei Stefanescu wrote:
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 10430778c998..e23c4369b6e1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE
>  R:	Chester Lin <chester62515@gmail.com>
>  R:	Matthias Brugger <mbrugger@suse.com>
>  R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
> +R: 	Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>

That's another patch where NXP adds silently themself as platform
maintainer without explanation. Although here at least existing
maintainers are Cced.

This looks like some pattern, so maybe clarifications are needed.

You wanted to be maintainer of this driver alone, right? So separate entry.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 10430778c998..e23c4369b6e1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2689,10 +2689,12 @@  ARM/NXP S32G ARCHITECTURE
 R:	Chester Lin <chester62515@gmail.com>
 R:	Matthias Brugger <mbrugger@suse.com>
 R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
+R: 	Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
 L:	NXP S32 Linux Team <s32@nxp.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 F:	arch/arm64/boot/dts/freescale/s32g*.dts*
+F: 	drivers/gpio/gpio-siul2-s32g2.c
 F:	drivers/pinctrl/nxp/
 
 ARM/Orion SoC/Technologic Systems TS-78xx platform support