From patchwork Mon Sep 16 13:19:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Simion X-Patchwork-Id: 13805427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D20CAC3ABB2 for ; Mon, 16 Sep 2024 13:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nWD5ZQGvP94MR/80OiPgS34+FGGekQQHGBkPulPfXJU=; b=EOgY3f+PNJDE6mHiIJj5sf3tnb xa98xK664ZelT7DjWYdQ49gv3jY8vq2IsJNR/E74QaK+hQJ4WWHj4L5V/Ar64TCfCM/Gtj+NZ5/fT tZXEzQlesfjr4nu/rLPXLHbPCLih7/wBP4oYwHKVErCcCNogpDd+qF/GRsVP5rWB4XQvXMck9WEK7 DEogRHvw1qSfTwtP80y6YfElajPPQPEnu/rF5+yiuQH1PSYAnt/gQVR8sCCg1hXpMla0dVcPAP9/B 5U89jqZfjsx5gbxB62UlJ5wiONvAdDpRTVTauCU443R4gfRPsWPGV1vhghleP00PTw8Nr+DxBOTXO mRw7nfow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqBh4-000000044MZ-3tsa; Mon, 16 Sep 2024 13:23:06 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sqBeL-000000043x7-4AgV for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2024 13:20:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1726492818; x=1758028818; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LtyrK8rT+ddKnOKr4OAF9a6sJB7r1UWxYnOf39Qe6Bg=; b=kcX71byVbY/IlqtIsJvz1kIq84RL9nqkJTArdQKvBkOA+s0xSP5UeQ9M kk37k1OL+AibU6b53qmpNmrglT5hiQwV/2F34wYgTVSazXFmJuDaCT2Jt lTWNflch7KeTy9sxxCNZTUy5l83/Zvq3nWtHl0YORWCxMx2ruDpyitAE3 dJa/XtzQxuzuNlEUfTxVFszZZF0J5n3BRSbvY75FkuriNDpXgH4ksLGdc nv0q2wy3TrlJtaSoiuFJmeajDpkONILhZMQPayRdC1c2byCxm/jw/+RYI UDPNoXgancgHjTYu2XIBbDHGp7sQHnVMtlShlnaOIob2OGkMI8fFtQ98q g==; X-CSE-ConnectionGUID: 50Z/Q3YNQtGxx5+pLOGVZA== X-CSE-MsgGUID: UsZZD4kASkGvuL/uCyRMpQ== X-IronPort-AV: E=Sophos;i="6.10,233,1719903600"; d="scan'208";a="262829818" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2024 06:20:16 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 16 Sep 2024 06:19:35 -0700 Received: from ROB-ULT-M76677.microchip.com (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 16 Sep 2024 06:19:32 -0700 From: Andrei Simion To: , , , , , , CC: , , , , Codrin Ciubotariu , Andrei Simion Subject: [PATCH v2 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Date: Mon, 16 Sep 2024 16:19:10 +0300 Message-ID: <20240916131910.22680-3-andrei.simion@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240916131910.22680-1-andrei.simion@microchip.com> References: <20240916131910.22680-1-andrei.simion@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240916_062018_066555_0DBE336D X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Codrin Ciubotariu Drop S24_LE format because it is not supported if more than 2 channels (of TDM slots) are used. This limitation makes it impractical for use cases requiring more than 2 TDM slots, leading to potential issues in multi-channel configurations. [andrei.simion@microchip.com: Reword the commit title and the commit message. Add code comment to explain the removed code.] Signed-off-by: Codrin Ciubotariu Signed-off-by: Andrei Simion Reviewed-by: Alexandre Belloni --- v1 -> v2: - add code comment to explain why S24_LE is dropped. --- sound/soc/atmel/atmel_ssc_dai.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 7047f17fe7a8..89098f41679c 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component) return 0; } +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */ #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) + SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { .startup = atmel_ssc_startup,