diff mbox series

[v2,1/3] dt-bindings: trivial-devices: support pmbus compatible string

Message ID 20240918095438.1345886-2-Delphine_CC_Chiu@wiwynn.com (mailing list archive)
State New
Headers show
Series yosemite4: Add power module and ADC on Medusa Board | expand

Commit Message

Delphine CC Chiu Sept. 18, 2024, 9:54 a.m. UTC 
From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>

Add pmbus compatibale string for the Generic PMbus devices that could
be monitor by pmbus driver.

Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Sept. 18, 2024, 1:03 p.m. UTC | #1 
On 18/09/2024 11:54, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> 
> Add pmbus compatibale string for the Generic PMbus devices that could
> be monitor by pmbus driver.
> 

You need to explain more, provide background why we would like to accept
a generic compatible. And why a specific compatible cannot or should not
be used...

In general this is a no, you cannot have such compatibles for real hardware.

Best regards,
Krzysztof
Guenter Roeck Sept. 18, 2024, 4:53 p.m. UTC | #2 
On 9/18/24 06:03, Krzysztof Kozlowski wrote:
> On 18/09/2024 11:54, Delphine CC Chiu wrote:
>> From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
>>
>> Add pmbus compatibale string for the Generic PMbus devices that could
>> be monitor by pmbus driver.
>>
> 
> You need to explain more, provide background why we would like to accept
> a generic compatible. And why a specific compatible cannot or should not
> be used...
> 
> In general this is a no, you cannot have such compatibles for real hardware.
> 

Agreed; affected chips should be listed explicitly in drivers/hwmon/pmbus/pmbus.c.

Guenter
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 8a9a00705b23..cbb9b94e5b3b 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -320,6 +320,8 @@  properties:
           - oki,ml86v7667
             # 48-Lane, 12-Port PCI Express Gen 2 (5.0 GT/s) Switch
           - plx,pex8648
+            # Generic PMBus devices
+          - pmbus
             # Pulsedlight LIDAR range-finding sensor
           - pulsedlight,lidar-lite-v2
             # Renesas HS3001 Temperature and Relative Humidity Sensors