| Message ID | 20240920082122.6742-1-andyshrk@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | VOP Support for rk3576 | expand |
>Move rockchip_drm_drv.h in rockchip_drm_vop2.h to fix the follow >sparse warning: > >ARCH=arm64 LLVM=1 make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >mrproper defconfig all -j12 > >drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: >warning: symbol 'vop2_platform_driver' was not declared. Should it >be static? > >It is also beneficial for the upcoming support for rk3576. > >Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") >Signed-off-by: Andy Yan <andy.yan@rock-chips.com> >Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> Reviewed-by: Min-Hua Chen <minhuadotchen@gmail.com>
On Fri Sep 20, 2024 at 10:21 AM CEST, Andy Yan wrote: > From: Andy Yan <andy.yan@rock-chips.com> Maybe ``From: Min-Hua Chen <minhuadotchen@gmail.com>``? It's very minor and Min-Hua gave their 'Reviewed-by' tag to your patch, but they found the problem and I thought it was just for practical reasons you made it part of this patch set. > Move rockchip_drm_drv.h in rockchip_drm_vop2.h to fix the follow > sparse warning: > > ARCH=arm64 LLVM=1 make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > mrproper defconfig all -j12 > > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: > warning: symbol 'vop2_platform_driver' was not declared. Should it > be static? > > It is also beneficial for the upcoming support for rk3576. > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> > > --- > > Changes in v3: > - Split it from 10/15, as it fix a exiting compile warning. > > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 4776a227e62c..a7f9f88869a6 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -35,7 +35,6 @@ > #include <uapi/linux/videodev2.h> > #include <dt-bindings/soc/rockchip,vop2.h> > > -#include "rockchip_drm_drv.h" > #include "rockchip_drm_gem.h" > #include "rockchip_drm_vop2.h" > #include "rockchip_rgb.h" > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h > index 59cd6b933bfb..bc001f715847 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h > @@ -9,6 +9,7 @@ > > #include <linux/regmap.h> > #include <drm/drm_modes.h> > +#include "rockchip_drm_drv.h" > #include "rockchip_drm_vop.h" > > #define VOP2_VP_FEATURE_OUTPUT_10BIT BIT(0)
Hi, > Maybe ``From: Min-Hua Chen <minhuadotchen@gmail.com>``? > > It's very minor and Min-Hua gave their 'Reviewed-by' tag to your patch, > but they found the problem and I thought it was just for practical > reasons you made it part of this patch set. Yes, you're right. The reason I reply this patch is that I am not sure if I have to do this. Please ignore my mail and sorry about the noise. thanks, Min-Hua
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 4776a227e62c..a7f9f88869a6 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -35,7 +35,6 @@ #include <uapi/linux/videodev2.h> #include <dt-bindings/soc/rockchip,vop2.h> -#include "rockchip_drm_drv.h" #include "rockchip_drm_gem.h" #include "rockchip_drm_vop2.h" #include "rockchip_rgb.h" diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h index 59cd6b933bfb..bc001f715847 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h @@ -9,6 +9,7 @@ #include <linux/regmap.h> #include <drm/drm_modes.h> +#include "rockchip_drm_drv.h" #include "rockchip_drm_vop.h" #define VOP2_VP_FEATURE_OUTPUT_10BIT BIT(0)