diff mbox series

[v1,1/3] dt-bindings: mfd: mediatek: mt6397: Add start-year property to RTC

Message ID 20240923100010.97470-2-angelogioacchino.delregno@collabora.com (mailing list archive)
State New, archived
Headers show
Series rtc: mt6359: Cleanup and support start-year property | expand

Commit Message

AngeloGioacchino Del Regno Sept. 23, 2024, 10 a.m. UTC
Enable evaluating the start-year property to allow shifting the
RTC's HW range.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley Sept. 23, 2024, 9:21 p.m. UTC | #1
On Mon, Sep 23, 2024 at 12:00:08PM +0200, AngeloGioacchino Del Regno wrote:
> Enable evaluating the start-year property to allow shifting the
> RTC's HW range.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Lee Jones Oct. 9, 2024, 10:15 a.m. UTC | #2
On Mon, 23 Sep 2024, AngeloGioacchino Del Regno wrote:

> Enable evaluating the start-year property to allow shifting the
> RTC's HW range.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++

No such file.

>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> index 953358bc997a..a83cc35f51f1 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> @@ -71,6 +71,8 @@ properties:
>                    - mediatek,mt6366-rtc
>                - const: mediatek,mt6358-rtc
>  
> +      start-year: true
> +
>      required:
>        - compatible
>  
> -- 
> 2.46.0
>
AngeloGioacchino Del Regno Oct. 9, 2024, 10:17 a.m. UTC | #3
Il 09/10/24 12:15, Lee Jones ha scritto:
> On Mon, 23 Sep 2024, AngeloGioacchino Del Regno wrote:
> 
>> Enable evaluating the start-year property to allow shifting the
>> RTC's HW range.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++
> 
> No such file.
> 

In the cover letter, I wrote:


For the bindings commit, this series goes on top of the MT6397 schema
conversion from Macpaul Lin [1].

This series was tested on a MT8195 Cherry Tomato Chromebook.

[1]: https://lore.kernel.org/all/20240918064955.6518-1-macpaul.lin@mediatek.com/


So, that's why. :-)

Cheers,
Angelo

>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
>> index 953358bc997a..a83cc35f51f1 100644
>> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
>> @@ -71,6 +71,8 @@ properties:
>>                     - mediatek,mt6366-rtc
>>                 - const: mediatek,mt6358-rtc
>>   
>> +      start-year: true
>> +
>>       required:
>>         - compatible
>>   
>> -- 
>> 2.46.0
>>
>
Lee Jones Oct. 9, 2024, 10:33 a.m. UTC | #4
On Wed, 09 Oct 2024, AngeloGioacchino Del Regno wrote:

> Il 09/10/24 12:15, Lee Jones ha scritto:
> > On Mon, 23 Sep 2024, AngeloGioacchino Del Regno wrote:
> > 
> > > Enable evaluating the start-year property to allow shifting the
> > > RTC's HW range.
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > >   Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++
> > 
> > No such file.
> > 
> 
> In the cover letter, I wrote:
> 
> 
> For the bindings commit, this series goes on top of the MT6397 schema
> conversion from Macpaul Lin [1].
> 
> This series was tested on a MT8195 Cherry Tomato Chromebook.
> 
> [1]: https://lore.kernel.org/all/20240918064955.6518-1-macpaul.lin@mediatek.com/
> 
> 
> So, that's why. :-)

Nope, try again. :)
Lee Jones Oct. 9, 2024, 10:37 a.m. UTC | #5
On Wed, 09 Oct 2024, Lee Jones wrote:

> On Wed, 09 Oct 2024, AngeloGioacchino Del Regno wrote:
> 
> > Il 09/10/24 12:15, Lee Jones ha scritto:
> > > On Mon, 23 Sep 2024, AngeloGioacchino Del Regno wrote:
> > > 
> > > > Enable evaluating the start-year property to allow shifting the
> > > > RTC's HW range.
> > > > 
> > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > > ---
> > > >   Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++
> > > 
> > > No such file.
> > > 
> > 
> > In the cover letter, I wrote:
> > 
> > 
> > For the bindings commit, this series goes on top of the MT6397 schema
> > conversion from Macpaul Lin [1].
> > 
> > This series was tested on a MT8195 Cherry Tomato Chromebook.
> > 
> > [1]: https://lore.kernel.org/all/20240918064955.6518-1-macpaul.lin@mediatek.com/
> > 
> > 
> > So, that's why. :-)
> 
> Nope, try again. :)

I guess you actually mean:

  https://lore.kernel.org/all/20240918064955.6518-2-macpaul.lin@mediatek.com/

It's on my list.  I'll place yours behind it and see how we go.
Macpaul Lin Oct. 9, 2024, 10:48 a.m. UTC | #6
On 10/9/24 18:37, Lee Jones wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Wed, 09 Oct 2024, Lee Jones wrote:
> 
>> On Wed, 09 Oct 2024, AngeloGioacchino Del Regno wrote:
>> 
>> > Il 09/10/24 12:15, Lee Jones ha scritto:
>> > > On Mon, 23 Sep 2024, AngeloGioacchino Del Regno wrote:
>> > > 
>> > > > Enable evaluating the start-year property to allow shifting the
>> > > > RTC's HW range.
>> > > > 
>> > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> > > > ---
>> > > >   Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++
>> > > 
>> > > No such file.
>> > > 
>> > 
>> > In the cover letter, I wrote:
>> > 
>> > 
>> > For the bindings commit, this series goes on top of the MT6397 schema
>> > conversion from Macpaul Lin [1].
>> > 
>> > This series was tested on a MT8195 Cherry Tomato Chromebook.
>> > 
>> > [1]: https://lore.kernel.org/all/20240918064955.6518-1-macpaul.lin@mediatek.com/
>> > 
>> > 
>> > So, that's why. :-)
>> 
>> Nope, try again. :)
> 
> I guess you actually mean:
> 
>    https://lore.kernel.org/all/20240918064955.6518-2-macpaul.lin@mediatek.com/
> 
> It's on my list.  I'll place yours behind it and see how we go.

Just a reminder.
The last reviewed patch set should be 'v8' because of the update for

'Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml'

[1/3] 
https://lore.kernel.org/all/20241001104145.24054-1-macpaul.lin@mediatek.com/

The [2/3] and [3/3] patches are dependent.

> 
> -- 
> Lee Jones [李琼斯]
> 

Thanks
Macpaul Lin
AngeloGioacchino Del Regno Oct. 9, 2024, 11:05 a.m. UTC | #7
Il 09/10/24 12:37, Lee Jones ha scritto:
> On Wed, 09 Oct 2024, Lee Jones wrote:
> 
>> On Wed, 09 Oct 2024, AngeloGioacchino Del Regno wrote:
>>
>>> Il 09/10/24 12:15, Lee Jones ha scritto:
>>>> On Mon, 23 Sep 2024, AngeloGioacchino Del Regno wrote:
>>>>
>>>>> Enable evaluating the start-year property to allow shifting the
>>>>> RTC's HW range.
>>>>>
>>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>>>> ---
>>>>>    Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 2 ++
>>>>
>>>> No such file.
>>>>
>>>
>>> In the cover letter, I wrote:
>>>
>>>
>>> For the bindings commit, this series goes on top of the MT6397 schema
>>> conversion from Macpaul Lin [1].
>>>
>>> This series was tested on a MT8195 Cherry Tomato Chromebook.
>>>
>>> [1]: https://lore.kernel.org/all/20240918064955.6518-1-macpaul.lin@mediatek.com/
>>>
>>>
>>> So, that's why. :-)
>>
>> Nope, try again. :)
> 
> I guess you actually mean:
> 
>    https://lore.kernel.org/all/20240918064955.6518-2-macpaul.lin@mediatek.com/
> 
> It's on my list.  I'll place yours behind it and see how we go.
> 

Yes I actually mean that one.

That's because I use to paste links to the cover letter of a series, and that
one did actually miss it, so that's what happened there I guess.

Anyway, I'm happy that you figured it out - this reminds me that I actually want
to keep asking to add cover letters when I review series..... :-)

Btw, many thanks!
Angelo
Lee Jones Oct. 16, 2024, 8:04 a.m. UTC | #8
On Mon, 23 Sep 2024 12:00:08 +0200, AngeloGioacchino Del Regno wrote:
> Enable evaluating the start-year property to allow shifting the
> RTC's HW range.
> 
> 

Applied, thanks!

[1/3] dt-bindings: mfd: mediatek: mt6397: Add start-year property to RTC
      commit: 0a98b711db1345687df995495ee1d097bba5a958

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 953358bc997a..a83cc35f51f1 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -71,6 +71,8 @@  properties:
                   - mediatek,mt6366-rtc
               - const: mediatek,mt6358-rtc
 
+      start-year: true
+
     required:
       - compatible