| Message ID | 20240924103156.13119-6-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] arm64: dts: mt8195: Fix dtbs_check error for infracfg_ao node | expand |
Il 24/09/24 12:31, Macpaul Lin ha scritto: > Add power domain binding to the mediatek DPI controller for MT8185. > > The dpi node in mt8195.dtsi was triggering a dtbs_check error: > dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] > > Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index 3a82aec9021c..07acc8a76bfc 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -89,6 +89,7 @@ allOf: > - mediatek,mt6795-dpi > - mediatek,mt8173-dpi > - mediatek,mt8186-dpi > + - mediatek,mt8195-dp-intf The dp_intf1 block has a power domain (VDOSYS1)... so that will break the check for the other one. Besides, I'm fairly sure that the right fix is to actually add the missing VDOSYS0 power domain to dp_intf0 instead, as that block is indeed in VDO0. So.. for this patch: nak. Cheers, Angelo > then: > properties: > power-domains: false
On 9/24/24 19:48, AngeloGioacchino Del Regno wrote: > Il 24/09/24 12:31, Macpaul Lin ha scritto: >> Add power domain binding to the mediatek DPI controller for MT8185. >> >> The dpi node in mt8195.dtsi was triggering a dtbs_check error: >> dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] >> >> Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> index 3a82aec9021c..07acc8a76bfc 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> @@ -89,6 +89,7 @@ allOf: >> - mediatek,mt6795-dpi >> - mediatek,mt8173-dpi >> - mediatek,mt8186-dpi >> + - mediatek,mt8195-dp-intf > > The dp_intf1 block has a power domain (VDOSYS1)... so that will break the check > for the other one. > > Besides, I'm fairly sure that the right fix is to actually add the missing VDOSYS0 > power domain to dp_intf0 instead, as that block is indeed in VDO0. > > So.. for this patch: nak. > > Cheers, > Angelo Tommy and I was wondering why DP-INTF0 will work without power domain. After lookup others node in the mt8195.dtsi, I guess this is because the power domain VDOSYS0 has been enabled by other modules. However this patch is still required after adding power domain to DP-INTF0. Otherwise the dpi errors will become two. :~ dp-intf@1c015000: power-domains: False schema does not allow [[44, 16]] dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] I'll send a separate patch to add VDOSYS0 for DP-INTF0. Thanks Macpaul Lin
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 3a82aec9021c..07acc8a76bfc 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -89,6 +89,7 @@ allOf: - mediatek,mt6795-dpi - mediatek,mt8173-dpi - mediatek,mt8186-dpi + - mediatek,mt8195-dp-intf then: properties: power-domains: false
Add power domain binding to the mediatek DPI controller for MT8185. The dpi node in mt8195.dtsi was triggering a dtbs_check error: dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains") Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+)