diff mbox series

arm64: dts: mediatek: mt8195: Add power domain for dp_intf0

Message ID 20240925071514.17626-1-macpaul.lin@mediatek.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: mediatek: mt8195: Add power domain for dp_intf0 | expand

Commit Message

Macpaul Lin Sept. 25, 2024, 7:15 a.m. UTC 
During inspecting dtbs_check errors, we found the power domain
setting of DPI node "dp_intf0" is missing. Add power domain setting
to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"

Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 +
 1 file changed, 1 insertion(+)

Changes for v1:
 - This patch is related to adding mt8195-dp-intf to DT schema fix for
  - http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml 
  - patch: https://lore.kernel.org/all/20240924103156.13119-6-macpaul.lin@mediatek.com/

Comments

Macpaul Lin Sept. 25, 2024, 7:22 a.m. UTC | #1 
On 9/25/24 15:15, Macpaul Lin wrote:
> During inspecting dtbs_check errors, we found the power domain
> setting of DPI node "dp_intf0" is missing. Add power domain setting
> to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
> 
> Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>

[snip]

Sorry there is a typo in the Signed-off-by.
I'll send v2 to correct this.

Thanks
Macpaul Lin
AngeloGioacchino Del Regno Sept. 25, 2024, 7:54 a.m. UTC | #2 
Il 25/09/24 09:15, Macpaul Lin ha scritto:
> During inspecting dtbs_check errors, we found the power domain
> setting of DPI node "dp_intf0" is missing. Add power domain setting
> to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
> 
> Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>

You missed a Suggested-by tag here :-)

after which,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Macpaul Lin Sept. 25, 2024, 7:56 a.m. UTC | #3 
On 9/25/24 15:54, AngeloGioacchino Del Regno wrote:
> Il 25/09/24 09:15, Macpaul Lin ha scritto:
>> During inspecting dtbs_check errors, we found the power domain
>> setting of DPI node "dp_intf0" is missing. Add power domain setting
>> to "MT8195_POWER_DOMAIN_VDOSYS0" for "dp_intf0"
>>
>> Signed-off-by: Tommy Chen <tommytl.chen@mediatek.com>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> 
> You missed a Suggested-by tag here :-)
> 
> after which,
> 
> Reviewed-by: AngeloGioacchino Del Regno 
> <angelogioacchino.delregno@collabora.com>
> 

Got it! I'll send v3 update later.

Thanks
Macpaul Lin
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ade685ed2190..6218bd7abb05 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -3252,6 +3252,7 @@  dp_intf0: dp-intf@1c015000 {
 			compatible = "mediatek,mt8195-dp-intf";
 			reg = <0 0x1c015000 0 0x1000>;
 			interrupts = <GIC_SPI 657 IRQ_TYPE_LEVEL_HIGH 0>;
+			power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
 			clocks = <&vdosys0 CLK_VDO0_DP_INTF0_DP_INTF>,
 				 <&vdosys0  CLK_VDO0_DP_INTF0>,
 				 <&apmixedsys CLK_APMIXED_TVDPLL1>;