| Message ID | 20240927111744.3511373-6-billy_tsai@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Aspeed G7 gpio support | expand |
On Fri, 2024-09-27 at 19:17 +0800, Billy Tsai wrote: > Use module_platform_driver() to replace module_platform_driver_probe(). > The former utilizes platform_driver_register(), which allows the driver to > defer probing when it doesn't acquire the necessary resources due to probe > order. In contrast, the latter uses __platform_driver_probe(), which > includes the comment "Note that this is incompatible with deferred > probing." Since our GPIO driver requires access to the clock resource, the > former is more suitable. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Seems okay to make it less of a deviant, though maybe we should fix the sgpio drive as well? Anyway: Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au> Andrew
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 1be9a7aa9e8b..d6a35e230370 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -1313,7 +1313,7 @@ static const struct of_device_id aspeed_gpio_of_table[] = { }; MODULE_DEVICE_TABLE(of, aspeed_gpio_of_table); -static int __init aspeed_gpio_probe(struct platform_device *pdev) +static int aspeed_gpio_probe(struct platform_device *pdev) { const struct of_device_id *gpio_id; struct gpio_irq_chip *girq; @@ -1414,13 +1414,14 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev) } static struct platform_driver aspeed_gpio_driver = { + .probe = aspeed_gpio_probe, .driver = { .name = KBUILD_MODNAME, .of_match_table = aspeed_gpio_of_table, }, }; -module_platform_driver_probe(aspeed_gpio_driver, aspeed_gpio_probe); +module_platform_driver(aspeed_gpio_driver); MODULE_DESCRIPTION("Aspeed GPIO Driver"); MODULE_LICENSE("GPL");
Use module_platform_driver() to replace module_platform_driver_probe(). The former utilizes platform_driver_register(), which allows the driver to defer probing when it doesn't acquire the necessary resources due to probe order. In contrast, the latter uses __platform_driver_probe(), which includes the comment "Note that this is incompatible with deferred probing." Since our GPIO driver requires access to the clock resource, the former is more suitable. Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> --- drivers/gpio/gpio-aspeed.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)