From patchwork Sat Sep 28 01:43:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13814594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BF7ACF6494 for ; Sat, 28 Sep 2024 01:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=vu7FmJqwmK0upibpguVPBxeCH3pRk8VsOtdb0A5Iw5M=; b=igXhBt+KStE22pA+In0ghJUJiW TehnSMd0Jg+JuYNN07F2sXAPk6gvsoIIduyv8FzRkveBG9teJ7oDxJdOcWdadOvQD7cNCKejikW+F t1ELdb1KN/vuWQKpRcLrq3usHp6+EOEjib4s4fWFOxX8U9oCa1LfD+ze6OJustYRnuLeAzmP9Y1nP vPQ+wfSFDBsQNEYpb0O+TWaqJ/87jpAL3c8C734ErYK/WQ+yJjGlGxK4mdpRQeRKzmEIQT8JHMYs8 /XFikSJMg/KEAbdg/kcofEW/WdbjPqyFABQxTRGbIx38G7J3eFL/VV607E+nsf+TaUfYc2e4u6TLM taVMKmSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suMWp-0000000CRRL-0O7m; Sat, 28 Sep 2024 01:45:47 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1suMVd-0000000CRNW-3ODh for linux-arm-kernel@lists.infradead.org; Sat, 28 Sep 2024 01:44:35 +0000 Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 212F688A0E; Sat, 28 Sep 2024 03:44:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1727487872; bh=vu7FmJqwmK0upibpguVPBxeCH3pRk8VsOtdb0A5Iw5M=; h=From:To:Cc:Subject:Date:From; b=DexV4vXj+UlTW55BXfJrW/bC/Y9Ztf5mdE64kG/ApYcxINnVMbS59IxzaLjoX8+N7 b9t7DGQcOLITD0SN/QLhIAEkzFBgUQyMq6WUbhp680tq6v4l2MXOvQx9Tuyih/Kzig 4a03w+vcbbKzR6b64jhwGhy7yCj1rg2tUYeVHEZu/hoMsdzPOlAZr40YaaldMHkipJ ZtJAnHjUnJgdBcUW4mqtr1LeO4IHvPMUvWe3hwMb3HHXyaADjtGkx888nkNYJETxEE n1lVIjivBJLwdHW4V64HMPX+kprfTdgZDpS5qCBGjDnLVsov8Qg3uGnvY3PjjNuCGB 2yNyJWZvd2gsQ== From: Marek Vasut To: linux-i2c@vger.kernel.org Cc: Marek Vasut , Alain Volmat , Alexandre Torgue , Andi Shyti , Christoph Niedermaier , Maxime Coquelin , Pierre-Yves MORDRET , kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH] i2c: stm32f7: Do not prepare/unprepare clock during runtime suspend/resume Date: Sat, 28 Sep 2024 03:43:46 +0200 Message-ID: <20240928014409.633542-1-marex@denx.de> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_184434_024128_CEE1EB41 X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In case there is any sort of clock controller attached to this I2C bus controller, for example Versaclock or even an AIC32x4 I2C codec, then an I2C transfer triggered from the clock controller clk_ops .prepare callback may trigger a deadlock on drivers/clk/clk.c prepare_lock mutex. This is because the clock controller first grabs the prepare_lock mutex and then performs the prepare operation, including its I2C access. The I2C access resumes this I2C bus controller via .runtime_resume callback, which calls clk_prepare_enable(), which attempts to grab the prepare_lock mutex again and deadlocks. Since the clock are already prepared since probe() and unprepared in remove(), use simple clk_enable()/clk_disable() calls to enable and disable the clock on runtime suspend and resume, to avoid hitting the prepare_lock mutex. Signed-off-by: Marek Vasut --- Cc: Alain Volmat Cc: Alexandre Torgue Cc: Andi Shyti Cc: Christoph Niedermaier Cc: Maxime Coquelin Cc: Pierre-Yves MORDRET Cc: kernel@dh-electronics.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-i2c@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com --- drivers/i2c/busses/i2c-stm32f7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index cfee2d9c09de3..65c035728a4fa 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -2395,7 +2395,7 @@ static int __maybe_unused stm32f7_i2c_runtime_suspend(struct device *dev) struct stm32f7_i2c_dev *i2c_dev = dev_get_drvdata(dev); if (!stm32f7_i2c_is_slave_registered(i2c_dev)) - clk_disable_unprepare(i2c_dev->clk); + clk_disable(i2c_dev->clk); return 0; } @@ -2406,7 +2406,7 @@ static int __maybe_unused stm32f7_i2c_runtime_resume(struct device *dev) int ret; if (!stm32f7_i2c_is_slave_registered(i2c_dev)) { - ret = clk_prepare_enable(i2c_dev->clk); + ret = clk_enable(i2c_dev->clk); if (ret) { dev_err(dev, "failed to prepare_enable clock\n"); return ret;