From patchwork Mon Sep 30 12:04:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13816096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48ECECF6497 for ; Mon, 30 Sep 2024 12:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4IxOY0fJQbV1pYrixFE+l++vJW3v3+bYS5tnnmoYTEc=; b=CY4+Xfj/OfhUVUpEXDdIRTVjIn POz0VuwBFTADA/bXt2tKssH840goFhoUIB73+c7gpJRhZeWN6fFWbRj8vfFpSX+5xNnGwTzVPJbeo 4Q3/FUk9JWDN5UzAkeCZJIyc3fvk0TXgvzJFt44dAO6V2C4Ac8rHbp1TRzSpAkuZt203av4XgGoS6 ugSy7aFBS7QdbKZeWQxSWxUc1ox8hUbNvO9/O1M/Hxck+EXn5QV7QDLqOnr5N8mRT66RyceNOdig/ d1o6IU5QTJ8rNLSAMVY6kGTwUPXWQXRsDQq2izR4NSH+QEVWyS9S9TpzGQXDtNn0sZYrag+OMgVsN v79Ph9bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svFXX-0000000H3Qb-0wW2; Mon, 30 Sep 2024 12:30:11 +0000 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svF96-0000000GwVK-1H7v for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2024 12:04:57 +0000 Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-6cb27e974ceso26203916d6.1 for ; Mon, 30 Sep 2024 05:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727697895; x=1728302695; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4IxOY0fJQbV1pYrixFE+l++vJW3v3+bYS5tnnmoYTEc=; b=XsNqNidanekttKVUyuIN+tGVXscEyVxXDVKr7Pmo+vQyID9cJdTe6Jn8NxU2vePRfO Hsggrebff9EpR6JOprBEgokIGE82nS5aB18d8I+ycoWJrWDy+7iyeC/ePtJJEl9KNXY5 Gka4zdPxVR1TOfH+rHO5eSVFHeZq95ipX6a2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727697895; x=1728302695; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4IxOY0fJQbV1pYrixFE+l++vJW3v3+bYS5tnnmoYTEc=; b=Q2qZ5VTBtk34LU+3xzjMfqlMYns+kkRyrrzBtVy6433+LK0PFLiOwIc3spQHlia5Rx Pit7em8/6qd8gdRN0ZMKQkZrz4tmpX22GmMvjm+Llliy2ivzj4UfGjRiXlitfzN0sY3C tNIDJc0a5aLeBsWOtGRuG6T96qDPDRqKsG4waQxpopyiqa/Sx4RFc8SeARBLuDeEsrXn oaXYUzSo/Zh+1tWt03a9PtlJmDGd5DPb4XkGu1OBu02WCegRnKINjKtKQQKPUxOE2tYC wlZHaYUbRwojqQURVovi1e3loVP2ZwyidoAv93glR1e9pLd58iL0WLwVHKahwDJHKgek tvpA== X-Forwarded-Encrypted: i=1; AJvYcCXyu5XMOqNeHFbCgC+L+zIr5nply2Eg+qKCBuWn0NLSpdn6tq0WefQQS5ncPQrZ55oxLQuuBJPCoO29DulCI5cm@lists.infradead.org X-Gm-Message-State: AOJu0YwGxyEwsc8qGLlozN1u/SQmayFIg3rMAwoMjPYMlehPRnmAEA9q GCccY/uCGe/vFhjMzfCAkC5MWr4I4gNq/BLBPppDo8n3Pgd6NjvWzKeIpwAf2Q== X-Google-Smtp-Source: AGHT+IH66496SEOv3j8ygYtL4JJVB2nn5gkUmde7+6fS5LT2xRJFvFwOVG+MRgiMM8u5XXNXcxJVyg== X-Received: by 2002:a05:6214:5b07:b0:6cb:5dd3:a3ce with SMTP id 6a1803df08f44-6cb5dd3a78emr68541006d6.14.1727697895340; Mon, 30 Sep 2024 05:04:55 -0700 (PDT) Received: from denia.c.googlers.com (76.224.245.35.bc.googleusercontent.com. [35.245.224.76]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b694369sm38822536d6.144.2024.09.30.05.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 05:04:54 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 30 Sep 2024 12:04:20 +0000 Subject: [PATCH 25/45] media: cobalt: Use string_choices helpers MIME-Version: 1.0 Message-Id: <20240930-cocci-opportunity-v1-25-81e137456ce0@chromium.org> References: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> In-Reply-To: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> To: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Hans Verkuil , Mike Isely , Olli Salonen , Maxim Levitsky , Sean Young , Sergey Kozlov , Abylay Ospan , Jemma Denson , Patrick Boettcher , Ming Qian , Zhou Peng , Andy Walls , Laurent Pinchart , Michal Simek , Jean-Christophe Trotin , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Eddie James , Joel Stanley , Andrew Jeffery , Hans Verkuil , Tomasz Figa , Marek Szyprowski , Tim Harvey , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org, Ricardo Ribalda X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_050456_387447_5C5D2AAC X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The following cocci warning is fixed: drivers/media/pci/cobalt/cobalt-driver.c:263:25-33: opportunity for str_enable_disable(ctrl & 1) Signed-off-by: Ricardo Ribalda --- drivers/media/pci/cobalt/cobalt-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c index 6e1a0614e6d0..cff2d29410d4 100644 --- a/drivers/media/pci/cobalt/cobalt-driver.c +++ b/drivers/media/pci/cobalt/cobalt-driver.c @@ -260,7 +260,7 @@ static void msi_config_show(struct cobalt *cobalt, struct pci_dev *pci_dev) u32 adrs_l, adrs_h; pci_read_config_word(pci_dev, 0x52, &ctrl); - cobalt_info("MSI %s\n", ctrl & 1 ? "enable" : "disable"); + cobalt_info("MSI %s\n", str_enable_disable(ctrl & 1)); cobalt_info("MSI multiple message: Capable %u. Enable %u\n", (1 << ((ctrl >> 1) & 7)), (1 << ((ctrl >> 4) & 7))); if (ctrl & 0x80)