diff mbox series

[04/47] arm64/sysreg: Add register fields for ID_AA64DFR2_EL1

Message ID 20241001024356.1096072-5-anshuman.khandual@arm.com (mailing list archive)
State New
Headers show
Series KVM: arm64: Enable FGU (Fine Grained Undefined) for FEAT_FGT2 registers | expand

Commit Message

Anshuman Khandual Oct. 1, 2024, 2:43 a.m. UTC
This adds register fields for ID_AA64DFR2_EL1 as per the definitions based
on DDI0601 2024-06.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 arch/arm64/tools/sysreg | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Mark Brown Oct. 2, 2024, 3:48 p.m. UTC | #1
On Tue, Oct 01, 2024 at 08:13:13AM +0530, Anshuman Khandual wrote:

> This adds register fields for ID_AA64DFR2_EL1 as per the definitions based
> on DDI0601 2024-06.

DDI0601 2024-09 has now been released...

> +Sysreg	ID_AA64DFR2_EL1	3	0	0	5	2
> +Res0	63:8
> +UnsignedEnum	7:4	BWE
> +	0b0000	NI
> +	0b0001	IMP
> +	0b0010	IMP_WPT

Could equally name that BWE2 since this is for FEAT_BWE2.  I'm OK either
way I think, with a slight preference for BWE2 I think.  Either way:

Reviewed-by: Mark Brown <broonie@kernel.org>
Anshuman Khandual Oct. 3, 2024, 3:48 a.m. UTC | #2
On 10/2/24 21:18, Mark Brown wrote:
> On Tue, Oct 01, 2024 at 08:13:13AM +0530, Anshuman Khandual wrote:
> 
>> This adds register fields for ID_AA64DFR2_EL1 as per the definitions based
>> on DDI0601 2024-06.
> 
> DDI0601 2024-09 has now been released...
> 
>> +Sysreg	ID_AA64DFR2_EL1	3	0	0	5	2
>> +Res0	63:8
>> +UnsignedEnum	7:4	BWE
>> +	0b0000	NI
>> +	0b0001	IMP
>> +	0b0010	IMP_WPT
> 
> Could equally name that BWE2 since this is for FEAT_BWE2.  I'm OK either
> way I think, with a slight preference for BWE2 I think.  Either way:

Sure, will change this as s/IMP_WPT/BWE2 instead.

> 
> Reviewed-by: Mark Brown <broonie@kernel.org>
diff mbox series

Patch

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 6c0893d0204a..dbaa58be2e52 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1296,6 +1296,19 @@  Field	15:8	BRPs
 Field	7:0	SYSPMUID
 EndSysreg
 
+Sysreg	ID_AA64DFR2_EL1	3	0	0	5	2
+Res0	63:8
+UnsignedEnum	7:4	BWE
+	0b0000	NI
+	0b0001	IMP
+	0b0010	IMP_WPT
+EndEnum
+UnsignedEnum	3:0	STEP
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+EndSysreg
+
 Sysreg	ID_AA64AFR0_EL1	3	0	0	5	4
 Res0	63:32
 Field	31:28	IMPDEF7