From patchwork Wed Oct 2 07:19:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vignesh Raghavendra X-Patchwork-Id: 13819411 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A6C1CF3199 for ; Wed, 2 Oct 2024 07:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Y1BYUFdL9LXI9Zs7NApf3N2eDJem7pxZ/psQbpY6dic=; b=A2SrkQnqVu9E+d6JwXBmJPyKvE 8vn44sTVy4GTof3FG7LNvZx+tU7KKxQb6eyl/YeZg6S23sjW/U2Xz5Fq/x/v8LhI0gsByj/1taTT6 R5CDIue4tvzNWBSheHdu50q/HDOUZb5O5SNBrXtw5og1vayvC3lpeYWRCmmKqeemfnbBAw0RfEy6R F4rj4WBGajjmVL2h/I0/gW6306bEQ8FarmEnwU5gw0XIHTrh2dtn4ZtRBBERZbA2KQ3SXOBbo8Zb3 d6WTXHIaf6V3CXd3FREmmqfUNPiM5VWmPw8Xdfzox8JvcV6rQBQY8hdFWVjcjMsDmbrj+0IkcJuk1 F4aVZUyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svtfA-0000000514Q-3RV8; Wed, 02 Oct 2024 07:20:44 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svtdv-000000050xZ-2JIe for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 07:19:29 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4927JMoX109590; Wed, 2 Oct 2024 02:19:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1727853562; bh=Y1BYUFdL9LXI9Zs7NApf3N2eDJem7pxZ/psQbpY6dic=; h=From:To:CC:Subject:Date; b=QFATwWVUexB0tB+tQdfdXgXeuwVQZ0t0wngdnATkqmpUnIqhC0p2G7d14dD/BnLTH Dt+BzswgDJb7hS6DTKW9jVrbStjniGEi+3LvgKauOWTHfWBLhcEnqAvp4RfMn87wDs GuESshbotmNrTVtOjEjrku3m9tTJ8p5RQLS1anKY= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4927JMG6011123; Wed, 2 Oct 2024 02:19:22 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 2 Oct 2024 02:19:22 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 2 Oct 2024 02:19:22 -0500 Received: from uda0132425.dhcp.ti.com (uda0132425.dhcp.ti.com [172.24.227.94]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4927JJkP056939; Wed, 2 Oct 2024 02:19:20 -0500 From: Vignesh Raghavendra To: Keerthy , Linus Walleij , Bartosz Golaszewski CC: , , Vignesh Raghavendra , , Sabeeh Khan Subject: [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration Date: Wed, 2 Oct 2024 12:49:01 +0530 Message-ID: <20241002071901.2752757-1-vigneshr@ti.com> X-Mailer: git-send-email 2.46.2 MIME-Version: 1.0 X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_001927_754460_77FB9208 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since commit d29e741cad3f ("gpio: davinci: drop platform data support"), irqchip is no longer being registered on platforms what don't use unbanked gpios. Fix this. Reported-by: Sabeeh Khan Fixes: d29e741cad3f ("gpio: davinci: drop platform data support") Signed-off-by: Vignesh Raghavendra --- drivers/gpio/gpio-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 790595f3b949..76b58c70b257 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) return PTR_ERR(clk); } - if (chips->gpio_unbanked) { + if (!chips->gpio_unbanked) { irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0); if (irq < 0) { dev_err(dev, "Couldn't allocate IRQ numbers\n");