From patchwork Mon Oct 7 15:09:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Advait Dhamorikar X-Patchwork-Id: 13824922 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6289CCFB449 for ; Mon, 7 Oct 2024 15:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=U/+GSwCeOWRm/l1+CfEkkyplSY7a0N5EITYY7LFjoig=; b=mW226HIODhtUPrArYO0bzwwxI5 Trb87/Dw3MX3ka982JMzfi8tf3GwyvMsbvszenDpsAYceYrVYg6iABLmxfPMclF93f93HM0GyDDrk WV2GHrAsbTmVTcMVeX1Cq9bsT4ifJZvajO2UnMNG6sNwDNLz1PLnUWMtfSdWvme6gmhIwHlht4uVu Lg7gxRTgrQ6wnfvPluCb/Y+qvepha7+msTHMuo7ky82nLtt0EBaQNkDi0Lg9V4R+t1hPjz5DSi0Fv hi/C1pigypojgOkKudaIX02brPoQ8qVq0h5a5j+ZVovGdtQ/DWa5p0YNivfbrDslykTGBSwUraZO3 PFltefnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxpdd-00000002vs0-0GPC; Mon, 07 Oct 2024 15:27:09 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxpMN-00000002seo-0ksp for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 15:09:20 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-71e029efecdso946769b3a.3 for ; Mon, 07 Oct 2024 08:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728313757; x=1728918557; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U/+GSwCeOWRm/l1+CfEkkyplSY7a0N5EITYY7LFjoig=; b=l8QnWzyzf41UeuSMry0YqGrm2pRRwr0XlKY98htEbvo7Gl8Ee3oVuKOyAUj/9BGOGc SJZG3lTaM5nKhzU4+I8gA4MIZKElH5LdJLAl6XhnpTYLo8+rb098V4wI9lMQCZaC5Sfb IVUSlVx9ypqK461OQkNC7UDcI3K6jl5zzQ8C6hFD7DtAK4+CZrZs5CZ1qHIQvEyy9LVM Fp3jHeL5xb8x5UAKgq+TloGwdNomZqWEUm77gI0jPdooPbkmV4Yl2elT3hiWcM6PCzNp L4GnFrT3g3emAqI45FKbRTVlC0eoVD4DxkkxJUz2dJXCj8CPUV6kIfsFJZqFJQZR5SNK RPFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728313757; x=1728918557; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U/+GSwCeOWRm/l1+CfEkkyplSY7a0N5EITYY7LFjoig=; b=VzoNRH0+EwSlq0Pvdge5gU3KSwwHSiEjrwUd8s+uOXnot585/jILZTJNdE814IR0PW VrYXVql1P+OB423vJCV40mj80CYPjRuEZtT0nVELQURzXdPV5ISzoCO9ESnqiSg8rXpz Oa/LwdQYQKWWr+KoPrZ4BChwxE2zcoSRhfX40RgRkCuKJ01M1bFMc0/r4Ntv0TfSB8bA 9kTYyjsgs7st3ktEDgRWwAWqestyw+R5IQKAB3KTugYTOwQB7Olj/ZngtuY0GI3XxeAB NqccC/z2py1tvYFY/OjRLFex8DzR+013nVY7M4DEa8+9DdKbeWb6PBi4g1wpGEElBWMk spuQ== X-Forwarded-Encrypted: i=1; AJvYcCXrDHL5y9DJuOrUAqDL78sKpkUXyEjkoB2ydBi/qosyioSMUye5lnMkpz394WCfxH0VLEAZiRH14hgacpkWd7rJ@lists.infradead.org X-Gm-Message-State: AOJu0YwpL3yTJt20kaGilwjyPxF0/Wv1hZfst3IV5DoM+weJ9kWKUpG+ sI2QzCxV4mY/1ZbohvK7NZaajzR1EBkLucWDXRc8IzF6L+Tyz2q+pRqyuLfL X-Google-Smtp-Source: AGHT+IFyaIcmre3vkQABIM8yyNZlEuDS9Fnfn9Gk+ufQWVciOVuxyxkAe1vCDGKPdT/UvjtIoXMFog== X-Received: by 2002:a05:6a20:6f07:b0:1d3:2976:144 with SMTP id adf61e73a8af0-1d6dfafc08cmr16632114637.44.1728313757227; Mon, 07 Oct 2024 08:09:17 -0700 (PDT) Received: from advait-kdeneon.. ([2405:201:1e:f1d5:ffb9:ea:f539:1909]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f6c3411asm5011809a12.68.2024.10.07.08.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 08:09:16 -0700 (PDT) From: Advait Dhamorikar To: Sam Ravnborg , Boris Brezillon , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, anupnewsmail@gmail.com, Advait Dhamorikar , kernel test robot , Dan Carpenter Subject: [PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable Date: Mon, 7 Oct 2024 20:39:04 +0530 Message-Id: <20241007150904.9840-1-advaitdhamorikar@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_080919_247245_13B4524A X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org atmel_hlcdc_plane_update_buffers: may use an uninitialized sr variable when the if condition remains unsatisfied. The variable may contain an arbitrary value left from earlier computations. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202409240320.MZPgi3Up-lkp@intel.com/ Signed-off-by: Advait Dhamorikar Reviewed-by: Dmitry Baryshkov --- v1->v2: add reported by and closes labels drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c index 4a7ba0918eca..4150c4d0b4f2 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -559,7 +559,7 @@ static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane, const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc; struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private; struct drm_framebuffer *fb = state->base.fb; - u32 sr; + u32 sr = 0; int i; if (!dc->desc->is_xlcdc)