From patchwork Wed Oct 9 11:21:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13828232 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63C30CEDD8C for ; Wed, 9 Oct 2024 11:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2DpEnA3YplEcQFI6shVCtQMIfbctSRU8+HvPgo32UcY=; b=eaZY7q2I9p/isMJtNmpuzKveLq nsDNfgEmlkNrF+4v5m6AU76B706VixxBsozZTI+ahcdeZiTOzl5Fqee6YVNd7uUqt1126NkVuevus Z98RpUm8QM//+X9mJs+aHtQj6zq7sEEyZbWh4yPFfZcqI/wjA5OswyAl6LRAMiKohfw0Uqs6+VW5f fxHo3STWHIC4brG8w3lXRco7XcKm2tQOyJRKmYVQViRuvTXK+0UHYxpOD58BKq5VdXokIQdF5HcjI EUr1OVAuO2eN0PoH94O4luloUTCmCvwKbl83+px3HHKYTo6lFhjeXStf9L4i1lzJRFYhLzSSAuKev pz1HZfUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syVKB-000000097Vu-0DRb; Wed, 09 Oct 2024 11:57:51 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syUlY-000000092YP-3vuf for linux-arm-kernel@bombadil.infradead.org; Wed, 09 Oct 2024 11:22:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=2DpEnA3YplEcQFI6shVCtQMIfbctSRU8+HvPgo32UcY=; b=VssNtna7x7KTQZ4wVtmrwmYZSi 7E2bgKsOZRHsxE+OBs0YPa2oa8Duib61iHJs1e5x3W8ZIQdAq6QYxYAZp0gRO4d+QJXkS0cv+8NuP H0u2BzxBrPN9X+kZL20bvNVh0weNPngUwBVpH0D/bONfp/uXvMcGrLHXk+FyYKy56P4c4jdZCKeFV sAsDdtdBM0Cr3H6cdO/apWvuOFvCuPYhImO39KLKSfiU8BE8eX2wAS5rkpzGElhJbW7P9Q8wLoGZ9 2Mm22NiEw1uZ81YvDc3nXczQyuDaoif10OLZIGBvn09pPCghfGrHTc83iOI+0i74PZt6IhpRvT3Qc ph2nWoyQ==; Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syUlW-00000004vQt-0L3B for linux-arm-kernel@lists.infradead.org; Wed, 09 Oct 2024 11:22:03 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-42e82f7f36aso59542045e9.0 for ; Wed, 09 Oct 2024 04:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728472919; x=1729077719; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2DpEnA3YplEcQFI6shVCtQMIfbctSRU8+HvPgo32UcY=; b=JoLMxQgbRsYygzCrAHB/G23KbWW89HYte7mWi5ri0aVWczIPhHy50FFJUP8QDPTTAq 8Ms1Y9AsI/oToTlQiPPVGAychxn5cl2QrE9V46iZVmgZ5pn8rVkserLPPdnPF7rDo1sm EVhHmpQsuGtZSh80ZIrKLzDqAw+CyBsQ+Whnaan0uvIH666oDwG0BoaGh/MjF/LvA/R4 HUr7H3AS/yznkw6rz8sGnuztoP6tANAFkhiJy93X33h+s79xVZvsVdkVUCKsOL40yBXz 6Ur5SzLbdevTdtngWCoipeQxqmb7aAZ8Je6+j8CParESykofK8tGkF6rSOWF/e6WDtuV 3ZUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728472919; x=1729077719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2DpEnA3YplEcQFI6shVCtQMIfbctSRU8+HvPgo32UcY=; b=BnN0RRui6mBzZdfMk09XTj/egMvzjjHRNs9YS0TNYVfHZWo6806aFafwXVQZGJL4av DnHirEJQyk4kPPcRJu8PqqTd+NA2pz56GinJ7jcUCEBie7txqMqXZ0k7Lq801s1Ef6NA tDR55xTdfisgWWtnKfgW/rRVTtsZY0OSRMCaHPSfRfhyTiDEryZetC4qevr0e906Ptjd 3xnyKT3+rg4Biixqf1tBcu6R8UJWAiQGiS8CBBmPwwNcC7SxeVi5o4WqZRVOD2DkYXn4 fiTdbICe8+Q/4k4HiSjb2Uqku0UU/4cIR3H+kB3fvhdqXy2Qhy+Db/jGGhgESZCQS+hF J8bw== X-Forwarded-Encrypted: i=1; AJvYcCVHy2DN9Wej8osDzDDnBuHcB+UYC+BJbxmz1RQ8Zw3Kf8SoZeR3hLUpRFj2gz64wnBm2np68BGOf/6zW3WN0B7s@lists.infradead.org X-Gm-Message-State: AOJu0YwFHypXHvenz8u65hdUQRib6uvx+NlHe/LlhlhMajiuX+VJRv1c M4ItAqT9Hjb2AZh5iUKaSCk2ulPgcCnZPMSMEq9ety79JkKMKy+w5aD85xB0tHI= X-Google-Smtp-Source: AGHT+IGuNlqf0UjHLa+gCSHuJwmN6aEEWrwupvo8fc+pj3U1PFfl1qX4v/XDeaScMudS3KJA7vTNzg== X-Received: by 2002:a05:600c:4f48:b0:42c:bae0:f065 with SMTP id 5b1f17b1804b1-430ccf041a5mr15501335e9.5.1728472919068; Wed, 09 Oct 2024 04:21:59 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4310c3dcdcbsm12331445e9.0.2024.10.09.04.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:21:58 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH 6/7] scsi: ufs: exynos: remove tx_dif_p_nsec from exynosauto_ufs_drv_init() Date: Wed, 9 Oct 2024 12:21:40 +0100 Message-ID: <20241009112141.1771087-7-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.rc0.187.ge670bccf7e-goog In-Reply-To: <20241009112141.1771087-1-peter.griffin@linaro.org> References: <20241009112141.1771087-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_122202_234770_96344615 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Firstly exynosauto sets EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR so setting tx_dif_p_nsec has no effect. Secondly this assignment can't get executed as samsung,sysreg dt property is provided in for this platform. Meaning the execution flow will return on regmap_update_bits call above. Signed-off-by: Peter Griffin --- drivers/ufs/host/ufs-exynos.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 9d668d13fe94..d4e786afbbbc 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -205,8 +205,6 @@ static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) { - struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; - /* IO Coherency setting */ if (ufs->sysreg) { return regmap_update_bits(ufs->sysreg, @@ -214,8 +212,6 @@ static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) UFS_SHARABLE, UFS_SHARABLE); } - attr->tx_dif_p_nsec = 3200000; - return 0; }