diff mbox series

[4/5] staging: vchiq_core: Macros indentation fix

Message ID 20241010102250.236545-5-umang.jain@ideasonboard.com (mailing list archive)
State New, archived
Headers show
Series staging: vchiq_core: Improve indentation | expand

Commit Message

Umang Jain Oct. 10, 2024, 10:22 a.m. UTC 
Make sure that MAKE_* macros fit within 80 columns instead of spanning
in a single line.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 .../interface/vchiq_arm/vchiq_core.c          | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Stefan Wahren Oct. 10, 2024, 4:50 p.m. UTC | #1 
Hi Umang,

Am 10.10.24 um 12:22 schrieb Umang Jain:
> Make sure that MAKE_* macros fit within 80 columns instead of spanning
> in a single line.
honestly i'm not a fan of this change, because it just silence
checkpatch but doesn't improve readability.

Regards
Greg Kroah-Hartman Oct. 11, 2024, 4:36 a.m. UTC | #2 
On Thu, Oct 10, 2024 at 06:50:24PM +0200, Stefan Wahren wrote:
> Hi Umang,
> 
> Am 10.10.24 um 12:22 schrieb Umang Jain:
> > Make sure that MAKE_* macros fit within 80 columns instead of spanning
> > in a single line.
> honestly i'm not a fan of this change, because it just silence
> checkpatch but doesn't improve readability.

Agreed, this shouldn't be needed.
diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 8be2dcf3658c..d03b67f9cdb7 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -50,18 +50,19 @@ 
 	((unsigned short)(msgid) & 0xfff)
 
 #define MAKE_CONNECT			(VCHIQ_MSG_CONNECT << TYPE_SHIFT)
-#define MAKE_OPEN(srcport) \
-	((VCHIQ_MSG_OPEN << TYPE_SHIFT) | ((srcport) << 12))
-#define MAKE_OPENACK(srcport, dstport) \
-	((VCHIQ_MSG_OPENACK << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0))
-#define MAKE_CLOSE(srcport, dstport) \
-	((VCHIQ_MSG_CLOSE << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0))
-#define MAKE_DATA(srcport, dstport) \
-	((VCHIQ_MSG_DATA << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0))
+#define MAKE_OPEN(srcport)		((VCHIQ_MSG_OPEN << TYPE_SHIFT) | \
+					 ((srcport) << 12))
+#define MAKE_OPENACK(srcport, dstport)	((VCHIQ_MSG_OPENACK << TYPE_SHIFT) | \
+					 ((srcport) << 12) | ((dstport) << 0))
+#define MAKE_CLOSE(srcport, dstport)	((VCHIQ_MSG_CLOSE << TYPE_SHIFT) | \
+					 ((srcport) << 12) | ((dstport) << 0))
+#define MAKE_DATA(srcport, dstport)	((VCHIQ_MSG_DATA << TYPE_SHIFT) | \
+					 ((srcport) << 12) | ((dstport) << 0))
 #define MAKE_PAUSE			(VCHIQ_MSG_PAUSE << TYPE_SHIFT)
 #define MAKE_RESUME			(VCHIQ_MSG_RESUME << TYPE_SHIFT)
 #define MAKE_REMOTE_USE			(VCHIQ_MSG_REMOTE_USE << TYPE_SHIFT)
-#define MAKE_REMOTE_USE_ACTIVE		(VCHIQ_MSG_REMOTE_USE_ACTIVE << TYPE_SHIFT)
+#define MAKE_REMOTE_USE_ACTIVE		(VCHIQ_MSG_REMOTE_USE_ACTIVE \
+					 << TYPE_SHIFT)
 
 #define PAGELIST_WRITE			0
 #define PAGELIST_READ			1