From patchwork Fri Oct 11 15:04:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 13832643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91ED0D0D7B9 for ; Fri, 11 Oct 2024 15:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M6d2HEGva1FumwMFJbWr9u9NWQ5NOhQR6SBLNsRd724=; b=zPhceZy2mHWSMpuwnTe2hFFZcP Zh6hVN87AVg3JIG+NHEq1V+zgnMvL4QrxX8CKa/KDfCWo1F4uHlBqflMyaP06KL8LQeGMTJqak7nM xInBZk7jW+wyImQLBku6VVGsrBF8hgvmKO3J4EjdwuiegjPhTu9dSeDYfTQwzry2MjLE1woSZOvOe z2HWo7L6Z4t8dHYxKvId83pQikviv0+axbVT8s8sdAR/B7byPmy5RLYWuafwdNxnE5QSjjbpKO+EZ rruQpg/BE+HwOTh0QUCvnC7zhpEKYtE7g23Q742BUHMF5ctXjHnGDTVUSdOfSlAvADBC/EelTkuos pSi4Gn1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szHFp-0000000GjXF-0iPH; Fri, 11 Oct 2024 15:08:33 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szHDD-0000000Gj0p-07Dv for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 15:05:52 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-539e1543ab8so1113666e87.2 for ; Fri, 11 Oct 2024 08:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728659149; x=1729263949; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M6d2HEGva1FumwMFJbWr9u9NWQ5NOhQR6SBLNsRd724=; b=iQAtrCEtLkIFv5qzwCzPfDqZdNV7upXaQJG/GU0Zlz+3tnRfdtGqguRpdbkNr73D7m ZIvcA/p6rlzTqF2qxhnzwEYmuIyATJksKKS/4KsVBknDELH1QUpWURytrZRSYMJLB23Y zsUQcxP5RLXSz92mTbC8+3X8HrBczk0YSIyGS8gS9rnjsVJPKzBLMBkbUm/ix+Vg0DBH JhJbW47Rkqwfjl20W7w5am7lOybce0whxJ1Bm4igHbPmBr3D8yYLYyxPC4FoAWmq86Dh 0xV6L0EqCfBxgiqKqXIGYc/JIX7LooW0fY+blVEMbBEtUg7IFF5W9h3MFpzkBDPaovpw jJbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728659149; x=1729263949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M6d2HEGva1FumwMFJbWr9u9NWQ5NOhQR6SBLNsRd724=; b=rXRDIDYXifdqoX7C1SzGShs/pgF+TO4rXvOUOYeHTmN5J4cjg0Vjw7zOq1hpscdEuC 71qJWXp+JivTHItd/77yd10g1XikdqTq48NVXdKNduXQNyuY2vUElrzYAr6LXC3ac5tD yw49QtlN6ygjJHJ1ywmgS5s+ZufY9uFDIQzX75bhY2TwxTBl3R2lA8R+8a+AQHi8IiSI mXE/EJ95jwfIAbl/9A0zXr6YCCEESH5xwwgaz3qInfhDQ0ByOgWN2EThi1BC351c7yJ8 2DgkkDcoZL4JzKB0z3EE2sBXiexCbQa23Uqy2eLKCa+4YAtm3SCdc+soE+r4l8goZsMG 1lGw== X-Forwarded-Encrypted: i=1; AJvYcCV15q4FnSWCZRc97xO+0PDoaBnJdWPFijxgKolnmo+PEHAlW1Q88oysda2+jKLitHur7anRXaOtPIdaMCMLwUdS@lists.infradead.org X-Gm-Message-State: AOJu0Yy+N0GQu/8+kXIyr2n6oexn3mIDJuUyPXl3QHq0dPBoiOwRepFk /7eFogebyaP3JxSNDz9+5W/5YPV4Hab3oshxZvLCPh9E551qc2ah X-Google-Smtp-Source: AGHT+IGwGf+d6KP0pDSl5JptpFK3ku9j3zBqS2D7qrlBlzrhKGLUNO+lTF/x4nO5NF3hbj3e4pBmwQ== X-Received: by 2002:a05:6512:b17:b0:539:8fbd:5218 with SMTP id 2adb3069b0e04-539da5938a6mr2681944e87.56.1728659148651; Fri, 11 Oct 2024 08:05:48 -0700 (PDT) Received: from playground.localdomain ([86.127.146.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a7f5b0b5sm220879366b.94.2024.10.11.08.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 08:05:47 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , Tushar Khandelwal , Viresh Kumar , Frank Li Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/6] dt-bindings: dsp: fsl,dsp: fix power domain count Date: Fri, 11 Oct 2024 11:04:34 -0400 Message-Id: <20241011150439.4027-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241011150439.4027-1-laurentiumihalcea111@gmail.com> References: <20241011150439.4027-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_080551_097983_A3233E02 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Per the current binding, QM/QXP DSPs are supposed to have 4 power domains, while the rest just 1. For QM/QXP, the 4 power domains are: DSP, DSP_RAM, MU13A, MU13B. First off, drop MU13A from the count as its already attached to lsio_mu13. This decreases the count to 3. Secondly, drop DSP and DSP_RAM from the count for QXP. These are already attached to the DSP's LPCGs. Thirdly, a new power domain is required for DSP-SCU communication (MU2A). With this in mind, the number of required power domains for QXP is 2 (MU2A, MU13B), while for QM it's 4 (MU13B, DSP, DSP_RAM, MU2A). Update the fsl,dsp binding to reflect all of this information. Since the arm,mhuv2 binding has an example node using the fsl,imx8qxp-dsp compatible, remove two of the extra PDs to align with the required power domain count. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 31 +++++++++++++++---- .../bindings/mailbox/arm,mhuv2.yaml | 2 +- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index 9af40da5688e..ab93ffd3d2e5 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -99,14 +99,35 @@ allOf: contains: enum: - fsl,imx8qxp-dsp - - fsl,imx8qm-dsp - fsl,imx8qxp-hifi4 + then: + properties: + power-domains: + minItems: 2 + maxItems: 2 + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8qm-dsp - fsl,imx8qm-hifi4 then: properties: power-domains: minItems: 4 - else: + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mp-dsp + - fsl,imx8mp-hifi4 + - fsl,imx8ulp-dsp + - fsl,imx8ulp-hifi4 + then: properties: power-domains: maxItems: 1 @@ -157,10 +178,8 @@ examples: <&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>, <&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>; clock-names = "ipg", "ocram", "core"; - power-domains = <&pd IMX_SC_R_MU_13A>, - <&pd IMX_SC_R_MU_13B>, - <&pd IMX_SC_R_DSP>, - <&pd IMX_SC_R_DSP_RAM>; + power-domains = <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_MU_2A>; mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; memory-region = <&dsp_reserved>; diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml index a4f1fe63659a..02f06314d85f 100644 --- a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml +++ b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml @@ -197,7 +197,7 @@ examples: reg = <0 0x596e8000 0 0x88000>; clocks = <&adma_lpcg 0>, <&adma_lpcg 1>, <&adma_lpcg 2>; clock-names = "ipg", "ocram", "core"; - power-domains = <&pd 0>, <&pd 1>, <&pd 2>, <&pd 3>; + power-domains = <&pd 0>, <&pd 1>; mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; mboxes = <&mhu_tx 2 0>, //data-transfer protocol with 5 windows, mhu-tx <&mhu_tx 3 0>, //data-transfer protocol with 7 windows, mhu-tx