From patchwork Tue Oct 15 06:58:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13835798 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3C57CFC272 for ; Tue, 15 Oct 2024 07:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=3Rg9CafE1YGkVl9KvHL3hkpJVC1sI0hUFkBUJZbx7bE=; b=U5rgmNlES+nQ5hCrcAglBOR75c W+h6C/PI4R3Hay0AMxfpCzSDJsw5sRVV7b6M1q2IFQJ7e0TjqSCK6DLdZHjgMLBbqJSIEye6vu10p JNtfaaBvMhHRMAMvRyoUDR2AJFufOiEMz16RopQjV1f21QjcPcUzu+RGSuoksMv4JjTTOttKUVBqF 2Tt7LSV98pRABPNu1CU0pZeePdCPXI3s2PqT2fZvDYN2sluX7dtt8YdnKNiC8BfiP4VAac+1RrDBG ibFybaIqHzGONgXBdaA1HVKRcPepJlzN7Nc9dUfvH3M6xeQXDLBU7qR9/H1PgNwuLQUPpFYnPbvX+ AIJ+ZitQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0baL-00000007IRg-2AuU; Tue, 15 Oct 2024 07:03:13 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0bWK-00000007Hp6-0F6o for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Oct 2024 06:59:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=3Rg9CafE1YGkVl9KvHL3hkpJVC1sI0hUFkBUJZbx7bE=; b=DKn2ljSAq6wFOuwzVhmsaA4nV1 GdxYxSGRvSqwhwi0biqLpB7VkzCDHj1wGIKJHrbzfIDMZ2aAHkdwIRwMHw4lcN0dHgEIInH86Z31o 2Yg0CUXGz2MG7c6L51vDncVggG0k1992Hn3eSQxPHbmeiph3JA/o0RswtkX65WJ8ZXEK7/KvfjIGr ukZBpz35NItJURTC2HmgnwNqSuGnYfO0UsEd0KcnETt0ztdsZLZRHO74lo0RKGJRe8Qpn7bhLi1wi 2+oXvL3YPO2LwsT8DY39ZBv4HwqAetDg0PMSBW79oWpxh65+Updjn+/aViy6Lu3qt10oAvCAtV+QA pz9PyKBQ==; Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0bWF-00000006UsV-2UGX for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 06:59:02 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4311d4762daso4369055e9.2 for ; Mon, 14 Oct 2024 23:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728975534; x=1729580334; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3Rg9CafE1YGkVl9KvHL3hkpJVC1sI0hUFkBUJZbx7bE=; b=guogb0qnWtKwmhPWQ8AkO/7GH51BCaY1eXNrN5w0H7MU9rhFmi3d8BfQrYTurVQtAI g9TGt1DcsSK/bBhaw3MOdGT55FbstGZpgJS3Feks3ld53ke2qZ4cTx74ivPtOw7EgZdN Mp6A4ZHd+q5Ye3hZvr5lP0SaI1UJsVjxj3dFPRq2Ebry9izISyQa9BmlwqV1oecT4zpJ xAjCcRpqN8qnL1+CrpJd+Ht42/d8YZhu3j+toukzlUtUlcRqizyXRtuwR9g81EHcBP4N dymCp3/7uPO+Gplp6ORNhssfQ6JfucYW/xBaGUvF3EMIOyocy1AA2adRdodbG0I0URoM ZWMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728975534; x=1729580334; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Rg9CafE1YGkVl9KvHL3hkpJVC1sI0hUFkBUJZbx7bE=; b=fvt1fhCgjr4Rfmyrja5vhXJEhZonCX2JQ5ycLZBzQgYh0bAGDKg3RZutlzsSxh/Wga 6xWE0PNa0Y34Lep2EKh7lJYwMRkR+PB8Ba9G2SWaaDUgXUMXaTh4GPBJ8jubmBFDpHpH FryjvR1CjPXavjFix7nDm9Nl4wFf1DSAlbPDQczKR85dYdsML/ahXV3abWv4z+1lB0AY cDzuv0XLQ8OHune8qd62vWFXzfu0osiTK5iyr/dlve/K4+TcgS7PeuuUVXWokVEkJaou VhkkZiEoh6eDHhSQdNki/p90i9uwqXwosBZ5gZ721o+ZrjrH9k/O1Pk4DgD/DNUSDufH fqqQ== X-Forwarded-Encrypted: i=1; AJvYcCVO7yMw/7ZI51meh4atbC4UkxoO7QZ/XhgJa4BfefNuxgFi3YpfBQsoYk7cqueIz0EqE0MGQwR37Zp2bzkve1WJ@lists.infradead.org X-Gm-Message-State: AOJu0YwDpOpHbFNQ2Je+LWdBHA9G/ulu5tislSEyilbiOogQ8p3NxaOk ntoYATwL98amgZDGZSog3vTh1EVJwPehU5VIBFjYH1pUDAlgJEtX/thcTkpR1t4= X-Google-Smtp-Source: AGHT+IGbPMxgc3DOJjQs7sGqlYcjADDsKE8cdCECGo3sJ7ddzUzXMkKiJhT5InhJZ4au28jZv0tx4A== X-Received: by 2002:a05:600c:5122:b0:42c:b63d:df3 with SMTP id 5b1f17b1804b1-4311ddff73dmr55330175e9.0.1728975534141; Mon, 14 Oct 2024 23:58:54 -0700 (PDT) Received: from krzk-bin.. ([178.197.211.167]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4313f6c5d22sm8461645e9.40.2024.10.14.23.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 23:58:53 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , Rob Herring , Conor Dooley , Tomasz Figa , Jaewon Kim , Ivaylo Ivanov , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org, Igor Belwon Subject: [PATCH 1/2] dt-bindings: pinctrl: samsung: Fix interrupt constraint for variants with fallbacks Date: Tue, 15 Oct 2024 08:58:47 +0200 Message-ID: <20241015065848.29429-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_075900_805534_18DA831E X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") added samsung,exynos7-wakeup-eint fallback to some compatibles, so the intention in the if:then: conditions was to handle the cases: 1. Single Exynos7 compatible or Exynos5433+Exynos7 or Exynos7885+Exynos7: only one interrupt 2. Exynos850+Exynos7: no interrupts This was not implemented properly however and if:then: block matches only single Exynos5433 or Exynos7885 compatibles, which do not exist in DTS anymore, so basically is a no-op and no enforcement on number of interrupts is made by the binding. Fix the if:then: condition so interrupts in the Exynos5433 and Exynos7885 wake-up pin controller will be properly constrained. Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") Cc: Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring (Arm) Reviewed-by: Linus Walleij --- Cc: Igor Belwon --- .../samsung,pinctrl-wakeup-interrupt.yaml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml index 91516fedc872..49cb2b1a3d28 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml @@ -92,14 +92,17 @@ allOf: - if: properties: compatible: - # Match without "contains", to skip newer variants which are still - # compatible with samsung,exynos7-wakeup-eint - enum: - - samsung,s5pv210-wakeup-eint - - samsung,exynos4210-wakeup-eint - - samsung,exynos5433-wakeup-eint - - samsung,exynos7-wakeup-eint - - samsung,exynos7885-wakeup-eint + oneOf: + # Match without "contains", to skip newer variants which are still + # compatible with samsung,exynos7-wakeup-eint + - enum: + - samsung,exynos4210-wakeup-eint + - samsung,exynos7-wakeup-eint + - samsung,s5pv210-wakeup-eint + - contains: + enum: + - samsung,exynos5433-wakeup-eint + - samsung,exynos7885-wakeup-eint then: properties: interrupts: