diff mbox series

[v2,1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf syscon

Message ID 20241017025230.28752-1-frawang.cn@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf syscon | expand

Commit Message

Frank Wang Oct. 17, 2024, 2:52 a.m. UTC
From: Frank Wang <frank.wang@rock-chips.com>

Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
configured in usbdp phy driver.

Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
Changelog:
v2:
 - This is a new patch adds rk3576-vo1-grf syscon.

v1:
 - none

 Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Oct. 17, 2024, 8:25 a.m. UTC | #1
On Thu, Oct 17, 2024 at 10:52:28AM +0800, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
> 
> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
> configured in usbdp phy driver.
> 
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> ---
> Changelog:
> v2:
>  - This is a new patch adds rk3576-vo1-grf syscon.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Vinod Koul Oct. 17, 2024, 3:35 p.m. UTC | #2
On Thu, 17 Oct 2024 10:52:28 +0800, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
> 
> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
> configured in usbdp phy driver.
> 
> 

Applied, thanks!

[2/3] dt-bindings: phy: rockchip-usbdp: add rk3576
      commit: b3e804ab9aad465ba7285aa5daf83656d5efc59f
[3/3] phy: rockchip: usbdp: add rk3576 device match data
      commit: a76de028c619dd18f89786805bcc7bb4d379ea9f

Best regards,
Dragan Simic Oct. 18, 2024, 5:02 a.m. UTC | #3
Hello Frank,

On 2024-10-17 04:52, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
> 
> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
> configured in usbdp phy driver.
> 
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> ---
> Changelog:
> v2:
>  - This is a new patch adds rk3576-vo1-grf syscon.

Could you, please, clarify a bit why is this additional patch
needed in this series?

> v1:
>  - none
> 
>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 50d727f4b76c6..fd42217ab85e7 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -33,6 +33,7 @@ properties:
>                - rockchip,rk3576-usb-grf
>                - rockchip,rk3576-usbdpphy-grf
>                - rockchip,rk3576-vo0-grf
> +              - rockchip,rk3576-vo1-grf
>                - rockchip,rk3576-vop-grf
>                - rockchip,rk3588-bigcore0-grf
>                - rockchip,rk3588-bigcore1-grf
> @@ -283,6 +284,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - rockchip,rk3576-vo1-grf
>                - rockchip,rk3588-vo-grf
>                - rockchip,rk3588-vo0-grf
>                - rockchip,rk3588-vo1-grf
Frank Wang Oct. 18, 2024, 6:18 a.m. UTC | #4
Hi Dragan,

On 2024/10/18 13:02, Dragan Simic wrote:
> Hello Frank,
>
> On 2024-10-17 04:52, Frank Wang wrote:
>> From: Frank Wang <frank.wang@rock-chips.com>
>>
>> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
>> configured in usbdp phy driver.
>>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>> ---
>> Changelog:
>> v2:
>>  - This is a new patch adds rk3576-vo1-grf syscon.
>
> Could you, please, clarify a bit why is this additional patch
> needed in this series?
>

I mentioned in the commit content. The usbdp-phy driver select dp lanes 
via configuring the vo1-grf.

Best regards,
Frank

>> v1:
>>  - none
>>
>>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> index 50d727f4b76c6..fd42217ab85e7 100644
>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> @@ -33,6 +33,7 @@ properties:
>>                - rockchip,rk3576-usb-grf
>>                - rockchip,rk3576-usbdpphy-grf
>>                - rockchip,rk3576-vo0-grf
>> +              - rockchip,rk3576-vo1-grf
>>                - rockchip,rk3576-vop-grf
>>                - rockchip,rk3588-bigcore0-grf
>>                - rockchip,rk3588-bigcore1-grf
>> @@ -283,6 +284,7 @@ allOf:
>>          compatible:
>>            contains:
>>              enum:
>> +              - rockchip,rk3576-vo1-grf
>>                - rockchip,rk3588-vo-grf
>>                - rockchip,rk3588-vo0-grf
>>                - rockchip,rk3588-vo1-grf
Dragan Simic Oct. 18, 2024, 6:37 a.m. UTC | #5
Hello Frank,

On 2024-10-18 08:18, Frank Wang wrote:
> On 2024/10/18 13:02, Dragan Simic wrote:
>> On 2024-10-17 04:52, Frank Wang wrote:
>>> From: Frank Wang <frank.wang@rock-chips.com>
>>> 
>>> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
>>> configured in usbdp phy driver.
>>> 
>>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>>> ---
>>> Changelog:
>>> v2:
>>>  - This is a new patch adds rk3576-vo1-grf syscon.
>> 
>> Could you, please, clarify a bit why is this additional patch
>> needed in this series?
> 
> I mentioned in the commit content. The usbdp-phy driver select dp
> lanes via configuring the vo1-grf.

Yes, I already saw that in the patch description.  Though, and
I apologize if I'm missing something obvious, I can't see where
is it actually used in the code?  Is it yet to be used in the
dts(i) files?

I'd appreciate if you could clarify that just a bit further, so
I can hopefully understand it better.

>>> v1:
>>>  - none
>>> 
>>>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>>>  1 file changed, 2 insertions(+)
>>> 
>>> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>> index 50d727f4b76c6..fd42217ab85e7 100644
>>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>> @@ -33,6 +33,7 @@ properties:
>>>                - rockchip,rk3576-usb-grf
>>>                - rockchip,rk3576-usbdpphy-grf
>>>                - rockchip,rk3576-vo0-grf
>>> +              - rockchip,rk3576-vo1-grf
>>>                - rockchip,rk3576-vop-grf
>>>                - rockchip,rk3588-bigcore0-grf
>>>                - rockchip,rk3588-bigcore1-grf
>>> @@ -283,6 +284,7 @@ allOf:
>>>          compatible:
>>>            contains:
>>>              enum:
>>> +              - rockchip,rk3576-vo1-grf
>>>                - rockchip,rk3588-vo-grf
>>>                - rockchip,rk3588-vo0-grf
>>>                - rockchip,rk3588-vo1-grf
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
Frank Wang Oct. 18, 2024, 7:34 a.m. UTC | #6
Hi Dragan,

On 2024/10/18 14:37, Dragan Simic wrote:
> Hello Frank,
>
> On 2024-10-18 08:18, Frank Wang wrote:
>> On 2024/10/18 13:02, Dragan Simic wrote:
>>> On 2024-10-17 04:52, Frank Wang wrote:
>>>> From: Frank Wang <frank.wang@rock-chips.com>
>>>>
>>>> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
>>>> configured in usbdp phy driver.
>>>>
>>>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>>>> ---
>>>> Changelog:
>>>> v2:
>>>>  - This is a new patch adds rk3576-vo1-grf syscon.
>>>
>>> Could you, please, clarify a bit why is this additional patch
>>> needed in this series?
>>
>> I mentioned in the commit content. The usbdp-phy driver select dp
>> lanes via configuring the vo1-grf.
>
> Yes, I already saw that in the patch description.  Though, and
> I apologize if I'm missing something obvious, I can't see where
> is it actually used in the code?  Is it yet to be used in the
> dts(i) files?
>
> I'd appreciate if you could clarify that just a bit further, so
> I can hopefully understand it better.
>

Yes, the usbdp_phy node in dts(i) will assign the vo1-grf phandle like this:

usbdp_phy: phy@2b010000 {
         ...
         rockchip,vo-grf = <&vo1_grf>;
};

And the usbdp-phy driver parses it and assign to udphy->vogrf, it uses 
in rk_udphy_dplane_select().

The related codes have already existed in the current driver, so for 
RK3576, just only need to do a configuration.


Best regards,
Frank

>>>> v1:
>>>>  - none
>>>>
>>>>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>> index 50d727f4b76c6..fd42217ab85e7 100644
>>>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>> @@ -33,6 +33,7 @@ properties:
>>>>                - rockchip,rk3576-usb-grf
>>>>                - rockchip,rk3576-usbdpphy-grf
>>>>                - rockchip,rk3576-vo0-grf
>>>> +              - rockchip,rk3576-vo1-grf
>>>>                - rockchip,rk3576-vop-grf
>>>>                - rockchip,rk3588-bigcore0-grf
>>>>                - rockchip,rk3588-bigcore1-grf
>>>> @@ -283,6 +284,7 @@ allOf:
>>>>          compatible:
>>>>            contains:
>>>>              enum:
>>>> +              - rockchip,rk3576-vo1-grf
>>>>                - rockchip,rk3588-vo-grf
>>>>                - rockchip,rk3588-vo0-grf
>>>>                - rockchip,rk3588-vo1-grf
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
Dragan Simic Oct. 18, 2024, 10:52 a.m. UTC | #7
Hello Frank,

On 2024-10-18 09:34, Frank Wang wrote:
> On 2024/10/18 14:37, Dragan Simic wrote:
>> On 2024-10-18 08:18, Frank Wang wrote:
>>> On 2024/10/18 13:02, Dragan Simic wrote:
>>>> On 2024-10-17 04:52, Frank Wang wrote:
>>>>> From: Frank Wang <frank.wang@rock-chips.com>
>>>>> 
>>>>> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
>>>>> configured in usbdp phy driver.
>>>>> 
>>>>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>>>>> ---
>>>>> Changelog:
>>>>> v2:
>>>>>  - This is a new patch adds rk3576-vo1-grf syscon.
>>>> 
>>>> Could you, please, clarify a bit why is this additional patch
>>>> needed in this series?
>>> 
>>> I mentioned in the commit content. The usbdp-phy driver select dp
>>> lanes via configuring the vo1-grf.
>> 
>> Yes, I already saw that in the patch description.  Though, and
>> I apologize if I'm missing something obvious, I can't see where
>> is it actually used in the code?  Is it yet to be used in the
>> dts(i) files?
>> 
>> I'd appreciate if you could clarify that just a bit further, so
>> I can hopefully understand it better.
> 
> Yes, the usbdp_phy node in dts(i) will assign the vo1-grf phandle like 
> this:
> 
> usbdp_phy: phy@2b010000 {
>         ...
>         rockchip,vo-grf = <&vo1_grf>;
> };
> 
> And the usbdp-phy driver parses it and assign to udphy->vogrf, it uses
> in rk_udphy_dplane_select().
> 
> The related codes have already existed in the current driver, so for
> RK3576, just only need to do a configuration.

Great, thanks for the detailed explanation!  This confirms
my latest assumption and everything is looking good, so please
free to include:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

>>>>> v1:
>>>>>  - none
>>>>> 
>>>>>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>> 
>>>>> diff --git 
>>>>> a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> index 50d727f4b76c6..fd42217ab85e7 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>>>>> @@ -33,6 +33,7 @@ properties:
>>>>>                - rockchip,rk3576-usb-grf
>>>>>                - rockchip,rk3576-usbdpphy-grf
>>>>>                - rockchip,rk3576-vo0-grf
>>>>> +              - rockchip,rk3576-vo1-grf
>>>>>                - rockchip,rk3576-vop-grf
>>>>>                - rockchip,rk3588-bigcore0-grf
>>>>>                - rockchip,rk3588-bigcore1-grf
>>>>> @@ -283,6 +284,7 @@ allOf:
>>>>>          compatible:
>>>>>            contains:
>>>>>              enum:
>>>>> +              - rockchip,rk3576-vo1-grf
>>>>>                - rockchip,rk3588-vo-grf
>>>>>                - rockchip,rk3588-vo0-grf
>>>>>                - rockchip,rk3588-vo1-grf
Heiko Stübner Oct. 21, 2024, 3:44 p.m. UTC | #8
On Thu, 17 Oct 2024 10:52:28 +0800, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
> 
> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
> configured in usbdp phy driver.
> 
> 

Applied, thanks!

[1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf syscon
      commit: ab79914808df7163564bffbc9f79801898fa906d

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 50d727f4b76c6..fd42217ab85e7 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -33,6 +33,7 @@  properties:
               - rockchip,rk3576-usb-grf
               - rockchip,rk3576-usbdpphy-grf
               - rockchip,rk3576-vo0-grf
+              - rockchip,rk3576-vo1-grf
               - rockchip,rk3576-vop-grf
               - rockchip,rk3588-bigcore0-grf
               - rockchip,rk3588-bigcore1-grf
@@ -283,6 +284,7 @@  allOf:
         compatible:
           contains:
             enum:
+              - rockchip,rk3576-vo1-grf
               - rockchip,rk3588-vo-grf
               - rockchip,rk3588-vo0-grf
               - rockchip,rk3588-vo1-grf