From patchwork Fri Oct 18 13:13:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Te Yuan X-Patchwork-Id: 13841758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3020CD30008 for ; Fri, 18 Oct 2024 13:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=Yy6y3iLSDsv1fZFNlVMuNMbKmj 1Kq0HzFMmF5VxSRT2MVne4NxOb6+5l5G6xDR1Fya5mUC625is9/OM+XKJ22tt/pTBMULLjc3EgC04 2YYQMPK/KRMJ+y4TiluvfDz+5M8MG+t+molAmO0+AglPPqQzby/9ACkALIfpCK1RNKXpqp5UmGYnZ EuheCKD6P6rc/L05Lkp6P93o5/eqepSg3W9LFHZXBUXig4grr+7ac5NMSAm6tzFKXqD4r1zKDfgeD jlfFb3O4ktKFASduv2QHAAElPF4yqnRFxO/ndwmD8fEn/no5WJ4lbgZrEOZs8dUkR+ZqZ0HA1aISj jMQBfkdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1msf-00000000rDi-3JeS; Fri, 18 Oct 2024 13:19:01 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1mni-00000000qKY-3q32 for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 13:13:56 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-718e9c8bd83so2313091b3a.1 for ; Fri, 18 Oct 2024 06:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729257234; x=1729862034; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=iV/pDpPh1KE/kslSSzMUA9vGLbOt8DObpGfhk3mFfwnQVEMhOfQAXSohucdDJ8A73J 9Lf9mO0/JyiFcycGELZPJjEMAzwAbaUsTWdkBVfl78dnlS4Cn2vgfIbZes9LrL/C0ssR 7mfT/eTRsoIYXd7JkP1Na6XJFln6JBu38N0a8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729257234; x=1729862034; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pKGlVab4i7DHl/ffkFGpIlho3hvAo5V5WFM3UhTHe/o=; b=PuS6WV+IB2UDbtyPAZF7a5UCcrRei90wmeEe+cOtnBJ4Q8oy8i9XHRG6jk2/y+sANb T4jRGG2Ze6OcXwpd1KsJx48uxezcUljZ9cdjIoanzS98CSFbWN3UYdRFDTtKtSJbQis5 J/aF+rM9eOkdT1vw3C1CiWIApbZfWR2YiSoxsjwmYg7BKg7mp6Sp1uxmrXcU4CBdukVX fB9bAJ0bRuLJj+5nHRc7Uf2iBeQ7lXRAgCaL6B7QRTKhUeR+MJu2IPrxTGvtjrjd4gRa UbJSYp7QCeE894F4kI2Fq3cdGWtn1k2obsk1HRoOOm6sXImgOndX7sFT0qCRp3AnsvSw DOJg== X-Forwarded-Encrypted: i=1; AJvYcCVHVGEiwqef9zT1S+Xk7zL/MlsNBQtAtGWzi5G/HxKb+ZeOLnAAgOzXiUoTki4JmIgazrJ9NFrxqZyJqabLH9JL@lists.infradead.org X-Gm-Message-State: AOJu0Yz/yZlLxaIK1OCD4RZfUmfUaVgjXAnBIUiEOvStaVqIt9PpISxX FH/2mqtjyowHDSOBW5ci6mK6j5ayI2VZFhYN4bTkhnmsTzEOKcOhFHayNoC78g== X-Google-Smtp-Source: AGHT+IERpLhih0BRRVXV4tS4aKvV7xvMczqjv51K9VBdHc8nUJD47v5CIh7delZjIDSg9jy5PpQR0Q== X-Received: by 2002:a05:6a00:2d18:b0:71e:71ba:9056 with SMTP id d2e1a72fcca58-71ea425995dmr3282768b3a.10.1729257233739; Fri, 18 Oct 2024 06:13:53 -0700 (PDT) Received: from yuanhsinte.c.googlers.com (176.220.194.35.bc.googleusercontent.com. [35.194.220.176]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7eacc256cc8sm1120222a12.56.2024.10.18.06.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 06:13:53 -0700 (PDT) From: Hsin-Te Yuan Date: Fri, 18 Oct 2024 13:13:42 +0000 Subject: [PATCH v2 2/4] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver MIME-Version: 1.0 Message-Id: <20241018-post-reset-v2-2-28d539d79e18@chromium.org> References: <20241018-post-reset-v2-0-28d539d79e18@chromium.org> In-Reply-To: <20241018-post-reset-v2-0-28d539d79e18@chromium.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Hsin-Yi Wang , Benjamin Tissoires , Hans de Goede Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.15-dev-7be4f X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_061354_965271_2F4B1C87 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of"), the i2c-hid-of driver used by some mt8183 devices resets the touchscreen without having enough post-reset delay. This makes those touchscreen fail to get probed. Switch to Elan touchscreen driver, which has enough post-reset delay. Fixes: 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of") Signed-off-by: Hsin-Te Yuan --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 10 +++------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 9 ++------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 9 ++------- .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 9 ++------- 4 files changed, 9 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts index ebe6e161354c414d91859494ec9295db75a3baf9..b98a3530511e576347a4ed291d37d45dd42fec97 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts @@ -14,14 +14,10 @@ / { }; &touchscreen { - status = "okay"; + compatible = "elan,ekth6a12nay"; - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; + vccio-supply = <&pp1800_alw>; }; &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index 2dc64cc539f815b9848b8243e5b487f22d605a6d..9fb329626a82034e44fb5fbd2d0ad9675c0a5afa 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -27,14 +27,9 @@ &cros_ec_pwm { }; &touchscreen { - status = "okay"; - - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; + compatible = "elan,ekth6a12nay"; - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; }; &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts index 53e996f9c605dc36df03d4b0051a91e19fefb38d..6d547361fc4f9d2ab1f9b048af443495c9bed323 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts @@ -14,14 +14,9 @@ / { }; &touchscreen { - status = "okay"; + compatible = "elan,ekth6a12nay"; - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts index d7db621383c6b823af08ca07e0794758d062e211..39ab09ce28aa2ed4335d5279a965f23a8458688e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts @@ -14,14 +14,9 @@ / { }; &touchscreen { - status = "okay"; + compatible = "elan,ekth6a12nay"; - compatible = "hid-over-i2c"; - reg = <0x10>; - interrupts-extended = <&pio 155 IRQ_TYPE_LEVEL_LOW>; - - post-power-on-delay-ms = <10>; - hid-descr-addr = <0x0001>; + vcc33-supply = <&pp3300_alw>; };