From patchwork Mon Oct 21 15:52:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 13844373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E33C8D15DB4 for ; Mon, 21 Oct 2024 16:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LxDxKHmPqECT4R1a7bYe2JPLBE82BXjHNnePjstN3G8=; b=BeZ/hGpAwlJFxyOu/LbmUz5K7h 1dIgqjkIZSPuSnWNBZOHt5hz3chx7Pyl5v06DmnC6XP9K2cR3cpYMdg7XoV3q3RMPVjjzUT3jJZcx 4eOe3DmHSG+2V9g5h97Rwx6qFd5ckfubebtBM1XxBIuXoCZPO8xAzsffbd33LJ68pfOmELs6S8BKH 0rEUWDbmcAiPHzuC1mp8UbTu0erHp15v3It7PCKIWTOoYdW46wywpteph30EkfrCOI2XJJmUddo81 i2w+Ngw7YlTn1V+9JoPdZcqTa+A23UN8cNeAE93VFUuFk0lz+lTc2UkCKi1qgVMYFTThgsHFNGGdF QRthAS9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2uqW-00000007tUR-2rMJ; Mon, 21 Oct 2024 16:01:28 +0000 Received: from mail-lf1-f51.google.com ([209.85.167.51]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2uiO-00000007rzW-1804 for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 15:53:05 +0000 Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-539f7606199so5118181e87.0 for ; Mon, 21 Oct 2024 08:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729525981; x=1730130781; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LxDxKHmPqECT4R1a7bYe2JPLBE82BXjHNnePjstN3G8=; b=aK0p8IY39IR/8E8/6LgA9zCDgy3qH73XaVcPST8DXYpKCNNCVGgSi/ow+sHeNYRkD1 wgwPG3bQ3xiweqQRq1O3fQTpgVGaYkSPro++4mwHudaa26iXVaNcKYtbwImb1TxBs+jr 51AW3J5TvtOkhy+MtVZ1iVOeVP7e4Bu1zyd2ItmV5EaAG7qKXyuXh+JtbDBPhfbPV6Zy 2tnn0CB2yPKOtFcp4OPJN1rn8TSb+IZ7nZWYr3plsAJ51aHsGpNrgzx+NrUvw5M89lp9 YCcm2nZV35xSu7A2c5n+tRmYzB5gPiHMJJvpn/b5/uWbP4id3S4857wNvE/x7uI6FYVG Wsrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729525981; x=1730130781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LxDxKHmPqECT4R1a7bYe2JPLBE82BXjHNnePjstN3G8=; b=vcmg/0OuhuffLz6CMts+aB+D8DG5M+mV4HY1oalkv9bMP2OgRmGhdw1FmHgcHtGbq7 N6TiRwH6/vq08vVlw7jtZiRv53obEf1shFHbMh1XjMpJflcK0H+iNN6OR7UePK1hYlSn cHxB2H7F5f6wawTE5+2BCoe8P0mufOCEIWHIuaSd1/YlicStzW3GZKCOkcJBssWWf2yO YGBXCS0Ff462yQG9/9etpnUH3GdMJTgynVgIgbaLKwFPghs7ax4k3SvH3jxBIVNQk17p /UfNITCFugMSmhj9ZK1B6NF0XNrnM/iiS9GoeNiq0FZY107FuG12yXYArDw+ycEbsPVm G+Ow== X-Forwarded-Encrypted: i=1; AJvYcCUhuGpG6K0ExZFn7zlQSmbEeIwOeNBdRkz/5hINWWn4+Tdxx0nuzgCfu7nPvq5NQMPsYGnE2mCFJBzA58cJsOoS@lists.infradead.org X-Gm-Message-State: AOJu0Yz56T50jnxgcTWqK8TjPo7iNd4P7lCdCmX/Le7mAT4KjB1Zq7ut 6h1+Lfu8KIW5Fz79Rcp4HSX/IoI6FDoG3Z/wOWIon1G1pfSGR7U6 X-Google-Smtp-Source: AGHT+IEOvF+I3X7eV/ZzXFntHrBLK7yKO+DyOsij8aWog9rupEjDGCjyG3yo/YkcA/eyGDm3liIWaw== X-Received: by 2002:a05:6512:318c:b0:539:9490:7257 with SMTP id 2adb3069b0e04-53b12c04223mr241778e87.30.1729525980930; Mon, 21 Oct 2024 08:53:00 -0700 (PDT) Received: from playground.localdomain ([86.127.146.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912edfd0sm218614366b.67.2024.10.21.08.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 08:53:00 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , Tushar Khandelwal , Viresh Kumar , Frank Li Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/6] dt-bindings: dsp: fsl,dsp: fix power domain count Date: Mon, 21 Oct 2024 11:52:16 -0400 Message-Id: <20241021155221.112073-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241021155221.112073-1-laurentiumihalcea111@gmail.com> References: <20241021155221.112073-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_085304_339296_81561E26 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Per the current binding, QM/QXP DSPs are supposed to have 4 power domains, while the rest just 1. For QM/QXP, the 4 power domains are: DSP, DSP_RAM, MU13A, MU13B. First off, drop MU13A from the count as its already attached to lsio_mu13. This decreases the count to 3. Secondly, drop DSP and DSP_RAM from the count for QXP. These are already attached to the DSP's LPCGs. Thirdly, a new power domain is required for DSP-SCU communication (MU2A). With this in mind, the number of required power domains for QXP is 2 (MU2A, MU13B), while for QM it's 4 (MU13B, DSP, DSP_RAM, MU2A). Update the fsl,dsp binding to reflect all of this information. Since the arm,mhuv2 binding has an example node using the fsl,imx8qxp-dsp compatible, remove two of the extra PDs to align with the required power domain count. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 31 +++++++++++++++---- .../bindings/mailbox/arm,mhuv2.yaml | 2 +- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index 9af40da5688e..ab93ffd3d2e5 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -99,14 +99,35 @@ allOf: contains: enum: - fsl,imx8qxp-dsp - - fsl,imx8qm-dsp - fsl,imx8qxp-hifi4 + then: + properties: + power-domains: + minItems: 2 + maxItems: 2 + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8qm-dsp - fsl,imx8qm-hifi4 then: properties: power-domains: minItems: 4 - else: + + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mp-dsp + - fsl,imx8mp-hifi4 + - fsl,imx8ulp-dsp + - fsl,imx8ulp-hifi4 + then: properties: power-domains: maxItems: 1 @@ -157,10 +178,8 @@ examples: <&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>, <&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>; clock-names = "ipg", "ocram", "core"; - power-domains = <&pd IMX_SC_R_MU_13A>, - <&pd IMX_SC_R_MU_13B>, - <&pd IMX_SC_R_DSP>, - <&pd IMX_SC_R_DSP_RAM>; + power-domains = <&pd IMX_SC_R_MU_13B>, + <&pd IMX_SC_R_MU_2A>; mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; memory-region = <&dsp_reserved>; diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml index a4f1fe63659a..02f06314d85f 100644 --- a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml +++ b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml @@ -197,7 +197,7 @@ examples: reg = <0 0x596e8000 0 0x88000>; clocks = <&adma_lpcg 0>, <&adma_lpcg 1>, <&adma_lpcg 2>; clock-names = "ipg", "ocram", "core"; - power-domains = <&pd 0>, <&pd 1>, <&pd 2>, <&pd 3>; + power-domains = <&pd 0>, <&pd 1>; mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; mboxes = <&mhu_tx 2 0>, //data-transfer protocol with 5 windows, mhu-tx <&mhu_tx 3 0>, //data-transfer protocol with 7 windows, mhu-tx