From patchwork Mon Oct 28 19:06:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13853963 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 342AED3E2BA for ; Mon, 28 Oct 2024 19:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VMSng6Hkq1ZytcY3Ph/5wRTVWQF53XvR2y3i6XkNIAU=; b=Vtk8uupziHPqhpxpRUBDiX++XY Zlrdn7kl+Dud7NSeoGTdOV6BzBu7+EJBaOdcGpL+dozHCpmypkwagNbF5LknQ/6ggmpRrZRF48S6s UMonR7ZpigE3Vc/0p7zITMzv1nFpW0H7gu7JVRUwEBeuCpRZoj4bNBibI7V2qlAsSH9SclSq+szEt FjMpguMm6HcTZwHbj6XshjpCuqHTB/VILDKnIYIWoWdD6c20oVffgd965HH6GJyHfR5UmsLr7H+ld VvhATyyRR88yY9tEZIdeT3nsvN2Rgb1tdDbXaBwW6qBOvbXsG9sN7u3swclNE5WJ9H2h/m/TVodsP FZ4eUKcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t5VYB-0000000C1ge-47SM; Mon, 28 Oct 2024 19:37:15 +0000 Received: from mail-am7eur03on20609.outbound.protection.outlook.com ([2a01:111:f403:260e::609] helo=EUR03-AM7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t5V4a-0000000Bwju-2PZa for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2024 19:06:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rl8rssUPgB7EqAco+rWgN4AONyKlI2GMKHiLYpZ90bOPM5DX+oYY4jgl7tJvUYFHes/JwUJjwymV0Qqm+jxmSJd5BpirOtOYJjMXMSjbdEGOByFpUkX0JzqfQqU3zWLQ2mO44rn3mlV4tAZuKSd/7TL1nZtv1pt5dEVPN430gekYJM/pA92gyvh5kYUsOzYiBza0FeZ+gVbkW/xKg3Y2Dkze5LWz7TOiGUBDC18uUmtYOEoC31LE2pbrjI0jzEqWSH+I/JUrCPiBvuSOS9FI3ORAVljOLLU8MzFn491GFg19yAjuetmL++3ajntIFrG9XaGZp1MK2MMkUzzBsmRl9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMSng6Hkq1ZytcY3Ph/5wRTVWQF53XvR2y3i6XkNIAU=; b=hKFWGXSLsciIIHk9poOQIr90ZoUGJvTnc2LobhrrvIStDgvRmXYNspPkGhFtZjYblTYXSM2B5Pk2Cl231cu7Z1LJkgmna6glmFS0tu5BTgf9wGqEhjDQCSfseTS55F9eKxnMtexiL46kNcvnjrZyc36yPQ4YbZJxhcKhYBMA2XQV8US2x6fTZnZK6gEn90svbW5x5txUrn5TlzfcALo5DRzWAWVn6Kmj9BVrKDBuhC7JJAFVT4GIjUr5c2XawR1HzO/HX2ypuvwuJKQDOVxqETInVBoDr0jrIo4pdFVZ9QMFDVLXM59TlLaK/XBADmUp9lxIqxO2NH6sJWXMFJTvhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VMSng6Hkq1ZytcY3Ph/5wRTVWQF53XvR2y3i6XkNIAU=; b=kwSBa+XWWEKfv8Ow/I8Pq/QWeUkEWZuB5giKah165ILfxBvigkIIGdJQVbBj3/iQrHi02kcYjDz8t7ITK0pHWzoM/iN3ki10/xu8KgWhpQ4WRj0i4H5VraUAyOH/jjiDFrgHOLxRi9vIYvw4U4R8YYWutOzYB5TL82QP+ZMOejaklVhSGum5BBb7smLRQ5+ONfkvTSPXE3gLU1K1WHAHEPJi5NT4V6S8r7yEdIxO41M5ofm5YfLeHrMkxJHLrVn70qKrFJ5PeU8f06wwGd2wI3whICrVPTNbCh2KHZLC8ODKS6LeqwNtWc53cTTlwI/8tQaTP+QFD5AtBnPRQ5QBoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DBBPR04MB7946.eurprd04.prod.outlook.com (2603:10a6:10:1ec::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Mon, 28 Oct 2024 19:06:35 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8093.021; Mon, 28 Oct 2024 19:06:35 +0000 From: Frank Li Date: Mon, 28 Oct 2024 15:06:00 -0400 Subject: [PATCH v6 6/7] PCI: imx6: Pass correct sub mode when calling phy_set_mode_ext() Message-Id: <20241028-pci_fixup_addr-v6-6-ebebcd8fd4ff@nxp.com> References: <20241028-pci_fixup_addr-v6-0-ebebcd8fd4ff@nxp.com> In-Reply-To: <20241028-pci_fixup_addr-v6-0-ebebcd8fd4ff@nxp.com> To: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1730142363; l=1266; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=MHdl1pBB8ltbGON7gH0Psda0JXVx4MU6Xi578sObIvc=; b=7wUDVK/qc/0ISWrgJoCoXb3D5iiXVsBocxv53p37ZhxLt0LjJqo1X/hN5j1q0wzpE6MNwd8La s2ecKtb1BEPDqaXSP6/atN5z+Rz0exk3hLtpdmJKiRY6peboJCyfSQi X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR03CA0005.namprd03.prod.outlook.com (2603:10b6:a02:a8::18) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DBBPR04MB7946:EE_ X-MS-Office365-Filtering-Correlation-Id: 678cf69b-be54-4e49-c5ab-08dcf783a492 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?yq41CZCPsJIh7BxKueBsJPgXSFDXS9I?= =?utf-8?q?RuaMGzU7RJktYmjLFRUTuL5qr8HGE32dFuQlfRVjqGl8jeBmA3TVogPmx7Ea6hypV?= =?utf-8?q?9SyaqK02ihzDMFzUumHOFw3xStBUwgMZSJwdLFtJhJ8J2XvQBmpIukPUi30SPIyjz?= =?utf-8?q?Occ9hXRG1rtDdSRm04GHEwJK7tkT3lFQc/XcCngdpZWb/Qv9iwS/sdfgOh2QS/11v?= =?utf-8?q?yuOMm+u7b0md8jn1xX9QAFN+GPBfxtEn8sMilqu6bsTgAKwsA1QzN+EM9keJFvbx0?= =?utf-8?q?nSubQ4NetdPGxvzy5RH4ykqmnQ4kJIQdsMr5YBegaQi8fVIThK+5pYaDGrdD3zO5+?= =?utf-8?q?AKHmn6zAzYC32utFw9P5mt6hYZqq9OGY/fhjSgcdrVke873FNlir2tzhRO+YrU/tQ?= =?utf-8?q?EY/PnOedmMTUdNdXgEq2/HHoUV74/D+MFTonN4+q0lqGyhLeyTDWEsyGWrjf2QAzq?= =?utf-8?q?FcCqvRKM/koZp/v/PrjBl/ivhcbR8EJh+EuZAWGrCtY+C8eZ9/aP4aH6LASKcBKjF?= =?utf-8?q?6tAYYxLJ4V0DwBvPy5r7IsZbuIE8f1s3YVcF8wwv05qmHuIOBdYAXmvhBMCCiTyF9?= =?utf-8?q?mIJ/vgZRtjJhyzPlTiwQhRH6RT7mG6U0Bv3aHZ8BQenfw35kI1KTf3jVC8BflC7W9?= =?utf-8?q?5CgWdKkRNuSHDf0IF13+ivLvgfzyNuwownAF8ei2ugKNKpMq4Aa3I7u06YQotW4fg?= =?utf-8?q?a24qmPK5kKq7tWmd60SRypWz2sLgk4v+/izgyV8O+AMcORMSB9lGbeSpgaqLZVPRK?= =?utf-8?q?k1z66C5RFDkEhEGHNx+X+gORkVEQ1w3rqOR1NVXXEB/Ihas88YmmOaxHHcql9CxoQ?= =?utf-8?q?KfQ8nWkcQirVbkI4bmuHwlSf/Rv52Adww+VNaceUs7Liwnwoy2WVPM6Ld5jBEpq9G?= =?utf-8?q?/trwziscba2QeclpGwX36d8dgPZvuguWXRyDKMeF6BN0xahNZiYY5vI3YU5WWEBho?= =?utf-8?q?eQEbMcSMsj53ECD0fCAMWGM7Qs9Rmu9cN68FQ0CdeFweC4K0mA7J/MkcSXmWw1VBA?= =?utf-8?q?ZqTTPqk7oB8oJYqj8PDFdw8GPdYvZU934bUZCclztcnpehHOYD4aOdKaOsvuFoabl?= =?utf-8?q?8oaYJdDwMCoxIzmnADuNjO1LwcYd+hxS/7RFRQJf93jxG95LEOg+UPtTmcqMf79s+?= =?utf-8?q?Ut5Kw6MgavAEG/Sj0jKVlIs5youSCafJZgFH5BJAaCVfH4JzI39HC8J7IeCbJy2SO?= =?utf-8?q?j7F3TetuehMRvDwPi8vcmkmPZ+89xfaVlqy5zWA9u3k608iTgcrz37ggFcOuoIQcC?= =?utf-8?q?VSJq1BPAXTGOvnx8zdFCcZ97mUy3AAklRKJbM3/exOB/ejCwPhACV5BoztbV1WAPu?= =?utf-8?q?ICSiRfuaDJ8G?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xVHzBeg+XjXrl7dgR/ky+PBRCjK+?= =?utf-8?q?vAO7l0HzfyuFD3KsIVHmhVHtJtURjJYtNp+BCKd1Cb6gtO9SAlN+nmnvEU7K6R5rt?= =?utf-8?q?Vt0Xd1L67InT0m2uHaXlrdp/ey7MbAatpA7Q1MFlCgw0nt4skXL52kvFMPcPn2V5n?= =?utf-8?q?pYbcObEby3zO6de1xVbInTcQsEhoGefMvoAVZIbKsmD4nySpO906Bpx+ekV7Na5sE?= =?utf-8?q?lnOQOHjLCyb9H/TaWhGqyqpnpH5zK2T7gRUMS+LlmhcFMky+5A0/MWpDyLhMpRQfX?= =?utf-8?q?wHWgRlHSJ/KJpJ1IPmGf8KWdoPEWr5gdb922rhIPc7+W3kEwcR30Gx+Z7k1nW3i6p?= =?utf-8?q?WpNWMQEeLYCwu0/HzctFiJxlCNKiCSizl3NSmgXIExSBvn+nvUKTNZ6rtuA3QH6RY?= =?utf-8?q?t3XkwpDmAm+jxejQNlfckj728R3Qz0Fhduuoxy106mjLsCxyVtCADPpbW8yHhBB+j?= =?utf-8?q?m3Rh5AfcMYbPVQOk5zKBzltmtMWrA7B3HiiG0QZdV27vYJdPLNucQmaTpuNZ6PaaW?= =?utf-8?q?VoUo1fAsFUCexuuCpyjtms4qCTtd/oycMEwIIJ7HLL/22kC55ueAnjcYCE0/1lxhk?= =?utf-8?q?GpCme/JQcAoRmCDToZWk5mPp60O9Gn9Tw1q8jxc+UKGuLo7BfAzqJNJdgZZFUlsmu?= =?utf-8?q?k3MSBwS7V1+87gOMTr39CbEkFR2yZVmweW7GFlIeRvVy9qc3rii2QJwRtpbqnixdd?= =?utf-8?q?cJYIxTNdlBtT011u1cLwBKDLDAqHekDYDxpqt6uD3NOK8RL2n/7yW3rgTiI4uKmLe?= =?utf-8?q?9xIrcZzgBDyLSEENrCQ78RKQ0N6XK8Vszrwp5yymAuvc5dSMZ1Vhz1WBVrcDXzQ/O?= =?utf-8?q?AhNC55HdFse9/g5Ai0tPI8S7/Fgp3J9q5tjU6fMh7uqMMmPELKgwk7tw9nyYwclM1?= =?utf-8?q?kQNoIMlT4QGygi6P7Zo9gZu2HEYqDnywStMZUOlrZWOfdLeJlOyP1YrJnTywY4lt2?= =?utf-8?q?bw5tFe8ZcYvdriR4Sbt0ytknnDdkcq60owrRzhCfe68R86wMF6e602gpVE0cN2sYj?= =?utf-8?q?RjKTFo/fR7S7meOpXOb+GQMoFeMfdBz5AEQZDJRD4Rd5K4PBEyay/JTO/PzHKH+Ow?= =?utf-8?q?u6tw0MBBrorHhErYY78my32DwV3p5+hP7AtDO+ROzlaFQn9L48hf5+/No58OEjGgc?= =?utf-8?q?AaIb1SfED4QGNI9De4lX3F2kSASsZuBz79n3rpuxSsY3RiFxPD2w3ZjRFNFpIn4LD?= =?utf-8?q?CqApBbYjx5O3m6zEaKzfvtbPpHs7weD+fCf62uYodHmA5V+Pj8fQA984tWYZmzB+d?= =?utf-8?q?1lOOawvPxt1YRsldClpGrwNBQdcxhoHiXO6SCgRJX+uLzFvXfg7qXYr3RvahYG2qa?= =?utf-8?q?XY6ga8j9zcPs2fikwRvEAXvNS2WQaxwM7GBegOuB8707iw1QR4J2YyuPx5+b0amUJ?= =?utf-8?q?vEfMxwk0uFjF7VbqiH6/mxUxko7CtbFtOPecyHKXCK/pxFUsgYhLotS9710+DM2J1?= =?utf-8?q?FmbcYkqnCNc4AebyCEH7zBz2Yo2C6de2CsdBrPxLpxq2J7qA8ucN3ldZHoPczDFpX?= =?utf-8?q?kujVBO+C0BJB?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 678cf69b-be54-4e49-c5ab-08dcf783a492 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2024 19:06:35.4833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ApzZgWhIA5RqpgnstKTIqxBvurNVXszvXzdVw0om4KFMvkA+UApK3RvOGZSjwfT/JZrCFKjwsnWjY/UmBTyKQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7946 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241028_120640_661921_3ED90B30 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix hardcoding to Root Complex (RC) mode by adding a drvdata mode check. Pass PHY_MODE_PCIE_EP if the PCI controller operates in Endpoint (EP) mode. Fixes: 8026f2d8e8a9 ("PCI: imx6: Call common PHY API to set mode, speed, and submode") Reviewed-by: Manivannan Sadhasivam Reviewed-by: Richard Zhu Signed-off-by: Frank Li --- Change from v3->v6 - none Change from v2->v3 - Add mani's review tag --- drivers/pci/controller/dwc/pci-imx6.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 533905b3942a1..8102a02a00b38 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -960,7 +960,9 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) goto err_clk_disable; } - ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, PHY_MODE_PCIE_RC); + ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, + imx_pcie->drvdata->mode == DW_PCIE_EP_TYPE ? + PHY_MODE_PCIE_EP : PHY_MODE_PCIE_RC); if (ret) { dev_err(dev, "unable to set PCIe PHY mode\n"); goto err_phy_exit;