| Message ID | 20241109094623.37518-3-linux@fw-web.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fix some binding check errors for marvell | expand |
On Sat, Nov 09, 2024 at 10:46:20AM +0100, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Commit facbe7092f8a ("arm64: dts: marvell: Drop undocumented SATA phy names") > drops some phy-names from devicetrees but misses some. Drop them too. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 11/9/24 18:46, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Commit facbe7092f8a ("arm64: dts: marvell: Drop undocumented SATA phy names") Isn't a Fixes tag for the above commit desired here ? > drops some phy-names from devicetrees but misses some. Drop them too. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > arch/arm64/boot/dts/marvell/armada-8040-db.dts | 2 -- > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts > index fe5d6cb9d692..9d45e881a97d 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts > @@ -307,11 +307,9 @@ &cp1_sata0 { > > sata-port@0 { > phys = <&cp1_comphy1 0>; > - phy-names = "cp1-sata0-0-phy"; > }; > sata-port@1 { > phys = <&cp1_comphy3 1>; > - phy-names = "cp1-sata0-1-phy"; > }; > }; > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi > index 5043cf2eb33e..0d4a5fd9503f 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi > @@ -345,13 +345,11 @@ &cp1_sata0 { > /* CPS Lane 1 - U32 */ > sata-port@0 { > phys = <&cp1_comphy1 0>; > - phy-names = "cp1-sata0-0-phy"; > }; > > /* CPS Lane 3 - U31 */ > sata-port@1 { > phys = <&cp1_comphy3 1>; > - phy-names = "cp1-sata0-1-phy"; > }; > }; >
Hi Am 11. November 2024 01:05:48 MEZ schrieb Damien Le Moal <dlemoal@kernel.org>: >On 11/9/24 18:46, Frank Wunderlich wrote: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Commit facbe7092f8a ("arm64: dts: marvell: Drop undocumented SATA phy names") > >Isn't a Fixes tag for the above commit desired here ? I have not added one and deopped from first part because of this: <https://lore.kernel.org/linux-arm-kernel/20220315024952.3we7hiwrkskb4tsy@vireshk-i7/> >> drops some phy-names from devicetrees but misses some. Drop them too. >> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> regards Frank
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts index fe5d6cb9d692..9d45e881a97d 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts @@ -307,11 +307,9 @@ &cp1_sata0 { sata-port@0 { phys = <&cp1_comphy1 0>; - phy-names = "cp1-sata0-0-phy"; }; sata-port@1 { phys = <&cp1_comphy3 1>; - phy-names = "cp1-sata0-1-phy"; }; }; diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi index 5043cf2eb33e..0d4a5fd9503f 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -345,13 +345,11 @@ &cp1_sata0 { /* CPS Lane 1 - U32 */ sata-port@0 { phys = <&cp1_comphy1 0>; - phy-names = "cp1-sata0-0-phy"; }; /* CPS Lane 3 - U31 */ sata-port@1 { phys = <&cp1_comphy3 1>; - phy-names = "cp1-sata0-1-phy"; }; };