| Message ID | 20241111045408.1922-5-honyuenkwun@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Add Orange Pi 5 Max board | expand |
On Sun, Nov 10, 2024 at 10:53:25PM -0600, Jimmy Hon wrote: > Add devicetree binding for the Xunlong Orange Pi 5 Max board. > > The Orange Pi 5 Max is a single board computer powered by the Rockchip > RK3588 similar to the Orange Pi 5 Plus. > > Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Sun, 10 Nov 2024 22:53:25 -0600, Jimmy Hon wrote: > Add devicetree binding for the Xunlong Orange Pi 5 Max board. > > The Orange Pi 5 Max is a single board computer powered by the Rockchip > RK3588 similar to the Orange Pi 5 Plus. > > Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Missing tags: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On Mon, Nov 11, 2024 at 2:57 PM Rob Herring (Arm) <robh@kernel.org> wrote: > > > On Sun, 10 Nov 2024 22:53:25 -0600, Jimmy Hon wrote: > > Add devicetree binding for the Xunlong Orange Pi 5 Max board. > > > > The Orange Pi 5 Max is a single board computer powered by the Rockchip > > RK3588 similar to the Orange Pi 5 Plus. > > > > Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. This v3 version is now sharing a base dtsi with the Orange Pi 5 Plus. So it's not a separate entry in the dt-bindings like it was in v2. I'm eager to hear from the Orange Pi 5 Plus maintainer if this approach is good, or if the boards are considered two divergent and trying to share a dtsi is going to cause more headaches when enabling features that are unique to the Orange Pi 5 Plus. In this case, it's not as similar as the NanoPi R6C vs R6S or the Orange Pi 5 vs Pi 5B. So if we decide to use the common approach, I can use Conor's Ack. But if we decide to use the separate approach, I can use your Ack from v2. > > Missing tags: > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Jimmy
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index a5a8f8bb9e48..82fbb22de207 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -1070,9 +1070,11 @@ properties: - const: xunlong,orangepi-3b - const: rockchip,rk3566 - - description: Xunlong Orange Pi 5 Plus + - description: Xunlong Orange Pi 5 Max/Plus items: - - const: xunlong,orangepi-5-plus + - enum: + - xunlong,orangepi-5-max + - xunlong,orangepi-5-plus - const: rockchip,rk3588 - description: Xunlong Orange Pi R1 Plus / LTS
Add devicetree binding for the Xunlong Orange Pi 5 Max board. The Orange Pi 5 Max is a single board computer powered by the Rockchip RK3588 similar to the Orange Pi 5 Plus. Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)