| Message ID | 20241112105604.795809-1-james.clark@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | KVM: arm64: Pass on SVE mapping failures | expand |
On Tue, 12 Nov 2024 10:56:03 +0000, James Clark <james.clark@linaro.org> wrote: > > This function can fail but its return value isn't passed onto the > caller. Presumably this could result in a broken state. > > Fixes: 66d5b53e20a6 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM") > Signed-off-by: James Clark <james.clark@linaro.org> Acked-by: Marc Zyngier <maz@kernel.org> M.
On Tue, 12 Nov 2024 at 10:56, James Clark <james.clark@linaro.org> wrote: > > This function can fail but its return value isn't passed onto the > caller. Presumably this could result in a broken state. > > Fixes: 66d5b53e20a6 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM") > Signed-off-by: James Clark <james.clark@linaro.org> > --- > arch/arm64/kvm/hyp/nvhe/setup.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c > index 8fec099c2775..cbdd18cd3f98 100644 > --- a/arch/arm64/kvm/hyp/nvhe/setup.c > +++ b/arch/arm64/kvm/hyp/nvhe/setup.c > @@ -146,8 +146,7 @@ static int recreate_hyp_mappings(phys_addr_t phys, unsigned long size, > return ret; > } > > - pkvm_create_host_sve_mappings(); > - return 0; > + return pkvm_create_host_sve_mappings(); > } Reviewed-by: Fuad Tabba <tabba@google.com> Thanks, /fuad > > static void update_nvhe_init_params(void) > -- > 2.34.1 >
On Tue, 12 Nov 2024 10:56:03 +0000, James Clark wrote: > This function can fail but its return value isn't passed onto the > caller. Presumably this could result in a broken state. > > Applied to next, thanks! [1/1] KVM: arm64: Pass on SVE mapping failures https://git.kernel.org/kvmarm/kvmarm/c/60ad25e14ab5 -- Best, Oliver
diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c index 8fec099c2775..cbdd18cd3f98 100644 --- a/arch/arm64/kvm/hyp/nvhe/setup.c +++ b/arch/arm64/kvm/hyp/nvhe/setup.c @@ -146,8 +146,7 @@ static int recreate_hyp_mappings(phys_addr_t phys, unsigned long size, return ret; } - pkvm_create_host_sve_mappings(); - return 0; + return pkvm_create_host_sve_mappings(); } static void update_nvhe_init_params(void)
This function can fail but its return value isn't passed onto the caller. Presumably this could result in a broken state. Fixes: 66d5b53e20a6 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM") Signed-off-by: James Clark <james.clark@linaro.org> --- arch/arm64/kvm/hyp/nvhe/setup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)