| Message ID | 20241117052501.1138926-1-iwamatsu@nigauri.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | gnss: mtk: Simplify return variables in mtk_set_active and mtk_set_standby | expand |
Il 17/11/24 06:25, Nobuhiro Iwamatsu ha scritto: > Simply return directly instead of assign the return value. > > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/drivers/gnss/mtk.c b/drivers/gnss/mtk.c index c62b1211f4fe4e..be20f6d6470736 100644 --- a/drivers/gnss/mtk.c +++ b/drivers/gnss/mtk.c @@ -24,25 +24,15 @@ struct mtk_data { static int mtk_set_active(struct gnss_serial *gserial) { struct mtk_data *data = gnss_serial_get_drvdata(gserial); - int ret; - ret = regulator_enable(data->vcc); - if (ret) - return ret; - - return 0; + return regulator_enable(data->vcc); } static int mtk_set_standby(struct gnss_serial *gserial) { struct mtk_data *data = gnss_serial_get_drvdata(gserial); - int ret; - ret = regulator_disable(data->vcc); - if (ret) - return ret; - - return 0; + return regulator_disable(data->vcc); } static int mtk_set_power(struct gnss_serial *gserial,
Simply return directly instead of assign the return value. Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> --- drivers/gnss/mtk.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)