| Message ID | 20241118-sysfs-const-attribute_group-fixes-v1-1-48e0b0ad8cba@weissschuh.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | sysfs: treewide: Remove spurious NULL in attribute_group definition | expand |
On 2024-11-18 3:02 pm, Thomas Weißschuh wrote: > This NULL value is most-likely a copy-paste error from an array > definition. So far the NULL didn't have any effect. > As there will be a union in struct attribute_group at this location, > it will trigger a compiler warning. Acked-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > drivers/perf/arm-ni.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c > index 90fcfe693439ef3e18e23c6351433ac3c5ea78b5..fd7a5e60e96302fada29cd44e7bf9c582e93e4ce 100644 > --- a/drivers/perf/arm-ni.c > +++ b/drivers/perf/arm-ni.c > @@ -247,7 +247,6 @@ static struct attribute *arm_ni_other_attrs[] = { > > static const struct attribute_group arm_ni_other_attr_group = { > .attrs = arm_ni_other_attrs, > - NULL > }; > > static const struct attribute_group *arm_ni_attr_groups[] = { >
diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c index 90fcfe693439ef3e18e23c6351433ac3c5ea78b5..fd7a5e60e96302fada29cd44e7bf9c582e93e4ce 100644 --- a/drivers/perf/arm-ni.c +++ b/drivers/perf/arm-ni.c @@ -247,7 +247,6 @@ static struct attribute *arm_ni_other_attrs[] = { static const struct attribute_group arm_ni_other_attr_group = { .attrs = arm_ni_other_attrs, - NULL }; static const struct attribute_group *arm_ni_attr_groups[] = {
This NULL value is most-likely a copy-paste error from an array definition. So far the NULL didn't have any effect. As there will be a union in struct attribute_group at this location, it will trigger a compiler warning. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- drivers/perf/arm-ni.c | 1 - 1 file changed, 1 deletion(-)