| Message ID | 20241202045757.39244-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: soc: fsl: cpm_qe: Limit matching to nodes with "fsl,qe" | expand |
On Mon, Dec 02, 2024 at 12:57:55PM +0800, Chen-Yu Tsai wrote: > Otherwise the binding matches against random nodes with "simple-bus" > giving out all kinds of invalid warnings: > > $ make CHECK_DTBS=y mediatek/mt8188-evb.dtb > SYNC include/config/auto.conf.cmd > UPD include/config/kernel.release > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC [C] arch/arm64/boot/dts/mediatek/mt8188-evb.dtb > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible:0: 'fsl,qe' was expected > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible: ['simple-bus'] is too short > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:compatible:0: 'fsl,qe-ic' was expected > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:reg: [[0, 201326592, 0, 262144], [0, 201588736, 0, 2097152]] is too long > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:#interrupt-cells:0:0: 1 was expected > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000: '#redistributor-regions', 'ppi-partitions' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'bus-frequency' is a required property > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# I'm curious why this is only coming up now, Rob applied this apparently in July. > > Fixes: ecbfc6ff94a2 ("dt-bindings: soc: fsl: cpm_qe: convert to yaml format") > Cc: Frank Li <Frank.Li@nxp.com> > Cc: <stable@vger.kernel.org> # v6.11+ > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > .../devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > index 89cdf5e1d0a8..9e07a2c4d05b 100644 > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > @@ -21,6 +21,14 @@ description: | > The description below applies to the qe of MPC8360 and > more nodes and properties would be extended in the future. > > +select: > + properties: > + compatible: > + contains: > + const: fsl,qe > + required: > + - compatible > + > properties: > compatible: > items: > -- > 2.47.0.338.g60cca15819-goog >
On Mon, Dec 02, 2024 at 12:57:55PM +0800, Chen-Yu Tsai wrote: > Otherwise the binding matches against random nodes with "simple-bus" > giving out all kinds of invalid warnings: > > $ make CHECK_DTBS=y mediatek/mt8188-evb.dtb > SYNC include/config/auto.conf.cmd > UPD include/config/kernel.release > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC [C] arch/arm64/boot/dts/mediatek/mt8188-evb.dtb > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible:0: 'fsl,qe' was expected > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible: ['simple-bus'] is too short > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:compatible:0: 'fsl,qe-ic' was expected > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:reg: [[0, 201326592, 0, 262144], [0, 201588736, 0, 2097152]] is too long > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:#interrupt-cells:0:0: 1 was expected > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000: '#redistributor-regions', 'ppi-partitions' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'bus-frequency' is a required property > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > Fixes: ecbfc6ff94a2 ("dt-bindings: soc: fsl: cpm_qe: convert to yaml format") > Cc: Frank Li <Frank.Li@nxp.com> > Cc: <stable@vger.kernel.org> # v6.11+ > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > .../devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > index 89cdf5e1d0a8..9e07a2c4d05b 100644 > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > @@ -21,6 +21,14 @@ description: | > The description below applies to the qe of MPC8360 and > more nodes and properties would be extended in the future. > > +select: > + properties: > + compatible: > + contains: > + const: fsl,qe > + required: > + - compatible Update your dtschema. The select is no longer necessary. dtbs_check will also run 5x faster. Rob
On Wed, Dec 4, 2024 at 1:20 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, Dec 02, 2024 at 12:57:55PM +0800, Chen-Yu Tsai wrote: > > Otherwise the binding matches against random nodes with "simple-bus" > > giving out all kinds of invalid warnings: > > > > $ make CHECK_DTBS=y mediatek/mt8188-evb.dtb > > SYNC include/config/auto.conf.cmd > > UPD include/config/kernel.release > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > DTC [C] arch/arm64/boot/dts/mediatek/mt8188-evb.dtb > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible:0: 'fsl,qe' was expected > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible: ['simple-bus'] is too short > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:compatible:0: 'fsl,qe-ic' was expected > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:reg: [[0, 201326592, 0, 262144], [0, 201588736, 0, 2097152]] is too long > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:#interrupt-cells:0:0: 1 was expected > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000: '#redistributor-regions', 'ppi-partitions' do not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'reg' is a required property > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'bus-frequency' is a required property > > from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# > > > > Fixes: ecbfc6ff94a2 ("dt-bindings: soc: fsl: cpm_qe: convert to yaml format") > > Cc: Frank Li <Frank.Li@nxp.com> > > Cc: <stable@vger.kernel.org> # v6.11+ > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > .../devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > > index 89cdf5e1d0a8..9e07a2c4d05b 100644 > > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml > > @@ -21,6 +21,14 @@ description: | > > The description below applies to the qe of MPC8360 and > > more nodes and properties would be extended in the future. > > > > +select: > > + properties: > > + compatible: > > + contains: > > + const: fsl,qe > > + required: > > + - compatible > > Update your dtschema. The select is no longer necessary. dtbs_check will > also run 5x faster. That did the trick. Thanks Rob! And sorry for the noise. ChenYu
diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml index 89cdf5e1d0a8..9e07a2c4d05b 100644 --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml @@ -21,6 +21,14 @@ description: | The description below applies to the qe of MPC8360 and more nodes and properties would be extended in the future. +select: + properties: + compatible: + contains: + const: fsl,qe + required: + - compatible + properties: compatible: items:
Otherwise the binding matches against random nodes with "simple-bus" giving out all kinds of invalid warnings: $ make CHECK_DTBS=y mediatek/mt8188-evb.dtb SYNC include/config/auto.conf.cmd UPD include/config/kernel.release SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC [C] arch/arm64/boot/dts/mediatek/mt8188-evb.dtb arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible:0: 'fsl,qe' was expected from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: compatible: ['simple-bus'] is too short from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:compatible:0: 'fsl,qe-ic' was expected from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:reg: [[0, 201326592, 0, 262144], [0, 201588736, 0, 2097152]] is too long from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000:#interrupt-cells:0:0: 1 was expected from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: interrupt-controller@c000000: '#redistributor-regions', 'ppi-partitions' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'reg' is a required property from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: soc: 'bus-frequency' is a required property from schema $id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe.yaml# Fixes: ecbfc6ff94a2 ("dt-bindings: soc: fsl: cpm_qe: convert to yaml format") Cc: Frank Li <Frank.Li@nxp.com> Cc: <stable@vger.kernel.org> # v6.11+ Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- .../devicetree/bindings/soc/fsl/cpm_qe/fsl,qe.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)