| Message ID | 20241204021014.5083-3-mjchen0829@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for nuvoton ma35d1 keypad controller | expand |
On Wed, Dec 04, 2024 at 02:10:14AM +0000, Ming-Jen Chen wrote: > Add YAML bindings for MA35D1 SoC keypad. > > Signed-off-by: Ming-Jen Chen <mjchen0829@gmail.com> Repeating same comment third or fourth time is a waste of my time. NAK. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Best regards, Krzysztof
On 2024/12/4 下午 03:49, Krzysztof Kozlowski wrote: > On Wed, Dec 04, 2024 at 02:10:14AM +0000, Ming-Jen Chen wrote: >> Add YAML bindings for MA35D1 SoC keypad. >> >> Signed-off-by: Ming-Jen Chen <mjchen0829@gmail.com> > > > Repeating same comment third or fourth time is a waste of my time. > > NAK. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Best regards, > Krzysztof > I will carefully review the v3 discussion thread to ensure that all feedback is properly implemented. Once I’ve addressed the issues, I’d like to confirm the next steps with you: 1. Should I drop v4 entirely and submit a revised patch as v5? 2. Alternatively, would you prefer me to resend v4 with the necessary corrections? Please let me know your preference so I can proceed accordingly and ensure a smoother review process. Thank you again for your guidance and understanding. Best regards, Ming-Jen Chen
diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml new file mode 100644 index 000000000000..54a81583bf2b --- /dev/null +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/nuvoton,ma35d1-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35D1 Keypad + +maintainers: + - Ming-jen Chen <mjchen0829@gmail.com> + +allOf: + - $ref: /schemas/input/matrix-keymap.yaml# + +properties: + compatible: + const: nuvoton,ma35d1-kpi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + debounce-delay-ms: + description: Debounce delay time in milliseconds. + maxItems: 1 + + scan-interval-ms: + description: Scan interval time in milliseconds. + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - debounce-delay-ms + - scan-interval-ms + - linux,keymap + - keypad,num-rows + - keypad,num-columns + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/input/input.h> + keypad@404a0000 { + compatible = "nuvoton,ma35d1-kpi"; + reg = <0x404a0000 0x10000>; + interrupts = <79>; + clocks = <&clk>; + keypad,num-rows = <2>; + keypad,num-columns = <2>; + + linux,keymap = < + MATRIX_KEY(0, 0, KEY_ENTER) + MATRIX_KEY(0, 1, KEY_ENTER) + MATRIX_KEY(1, 0, KEY_SPACE) + MATRIX_KEY(1, 1, KEY_Z) + >; + + debounce-delay-ms = <1>; + scan-interval-ms = <20>; + };
Add YAML bindings for MA35D1 SoC keypad. Signed-off-by: Ming-Jen Chen <mjchen0829@gmail.com> --- .../bindings/input/nuvoton,ma35d1-keypad.yaml | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml