diff mbox series

coco: virt: arm64: Do not enable cca guest driver by default

Message ID 20241205143634.306114-1-suzuki.poulose@arm.com (mailing list archive)
State New
Headers show
Series coco: virt: arm64: Do not enable cca guest driver by default | expand

Commit Message

Suzuki K Poulose Dec. 5, 2024, 2:36 p.m. UTC
As per the guidelines, new drivers may not be set to default on.
An expert user can always select it.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Steven Price <steven.price@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Link: https://lkml.kernel.org/r/6750c695194cd_2508129427@dwillia2-xfh.jf.intel.com.notmuch
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/virt/coco/arm-cca-guest/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Steven Price Dec. 5, 2024, 2:39 p.m. UTC | #1
On 05/12/2024 14:36, Suzuki K Poulose wrote:
> As per the guidelines, new drivers may not be set to default on.
> An expert user can always select it.
> 
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Steven Price <steven.price@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Link: https://lkml.kernel.org/r/6750c695194cd_2508129427@dwillia2-xfh.jf.intel.com.notmuch
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Sorry about that oversight on my part.

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  drivers/virt/coco/arm-cca-guest/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/virt/coco/arm-cca-guest/Kconfig b/drivers/virt/coco/arm-cca-guest/Kconfig
> index 9dd27c3ee215..3f0f013f03f1 100644
> --- a/drivers/virt/coco/arm-cca-guest/Kconfig
> +++ b/drivers/virt/coco/arm-cca-guest/Kconfig
> @@ -1,7 +1,6 @@
>  config ARM_CCA_GUEST
>  	tristate "Arm CCA Guest driver"
>  	depends on ARM64
> -	default m
>  	select TSM_REPORTS
>  	help
>  	  The driver provides userspace interface to request and
Catalin Marinas Dec. 5, 2024, 6:23 p.m. UTC | #2
On Thu, 05 Dec 2024 14:36:34 +0000, Suzuki K Poulose wrote:
> As per the guidelines, new drivers may not be set to default on.
> An expert user can always select it.
> 
> 

Applied to arm64 (for-next/fixes), thanks!

[1/1] coco: virt: arm64: Do not enable cca guest driver by default
      https://git.kernel.org/arm64/c/16d5306629c0
diff mbox series

Patch

diff --git a/drivers/virt/coco/arm-cca-guest/Kconfig b/drivers/virt/coco/arm-cca-guest/Kconfig
index 9dd27c3ee215..3f0f013f03f1 100644
--- a/drivers/virt/coco/arm-cca-guest/Kconfig
+++ b/drivers/virt/coco/arm-cca-guest/Kconfig
@@ -1,7 +1,6 @@ 
 config ARM_CCA_GUEST
 	tristate "Arm CCA Guest driver"
 	depends on ARM64
-	default m
 	select TSM_REPORTS
 	help
 	  The driver provides userspace interface to request and