diff mbox series

arm64: cpufeature: Add HAFT to cpucap_is_possible()

Message ID 20241209155948.2124393-1-mark.rutland@arm.com (mailing list archive)
State New
Headers show
Series arm64: cpufeature: Add HAFT to cpucap_is_possible() | expand

Commit Message

Mark Rutland Dec. 9, 2024, 3:59 p.m. UTC 
For consistency with other cpucaps, handle the configuration check for
ARM64_HAFT in cpucap_is_possible() rather than this being explicit in
system_supports_haft(). The configuration check will now happen
implicitly as cpus_have_final_cap() uses cpucap_is_possible() via
alternative_has_cap_unlikely().

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
---
 arch/arm64/include/asm/cpucaps.h    | 2 ++
 arch/arm64/include/asm/cpufeature.h | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

This is a cleanup as with the recent GCS cpucap:

  https://lore.kernel.org/linux-arm-kernel/Z1G3Z9C9efBkVKjR@J2N7QTR9R3/

Mark.

Comments

Will Deacon Dec. 10, 2024, 6:34 p.m. UTC | #1 
On Mon, 09 Dec 2024 15:59:48 +0000, Mark Rutland wrote:
> For consistency with other cpucaps, handle the configuration check for
> ARM64_HAFT in cpucap_is_possible() rather than this being explicit in
> system_supports_haft(). The configuration check will now happen
> implicitly as cpus_have_final_cap() uses cpucap_is_possible() via
> alternative_has_cap_unlikely().
> 
> 
> [...]

A patch so good, you signed it off twice! I dropped one of them.

Applied to arm64 (for-next/cpufeature), thanks!

[1/1] arm64: cpufeature: Add HAFT to cpucap_is_possible()
      https://git.kernel.org/arm64/c/264a593da60b

Cheers,
diff mbox series

Patch

diff --git a/arch/arm64/include/asm/cpucaps.h b/arch/arm64/include/asm/cpucaps.h
index cbbf70e0f2048..0b5ca6e0eb093 100644
--- a/arch/arm64/include/asm/cpucaps.h
+++ b/arch/arm64/include/asm/cpucaps.h
@@ -46,6 +46,8 @@  cpucap_is_possible(const unsigned int cap)
 		return IS_ENABLED(CONFIG_ARM64_POE);
 	case ARM64_HAS_GCS:
 		return IS_ENABLED(CONFIG_ARM64_GCS);
+	case ARM64_HAFT:
+		return IS_ENABLED(CONFIG_ARM64_HAFT);
 	case ARM64_UNMAP_KERNEL_AT_EL0:
 		return IS_ENABLED(CONFIG_UNMAP_KERNEL_AT_EL0);
 	case ARM64_WORKAROUND_843419:
diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
index 8b4e5a3cd24c8..a4d0b77a68d95 100644
--- a/arch/arm64/include/asm/cpufeature.h
+++ b/arch/arm64/include/asm/cpufeature.h
@@ -852,8 +852,7 @@  static inline bool system_supports_gcs(void)
 
 static inline bool system_supports_haft(void)
 {
-	return IS_ENABLED(CONFIG_ARM64_HAFT) &&
-		cpus_have_final_cap(ARM64_HAFT);
+	return cpus_have_final_cap(ARM64_HAFT);
 }
 
 static __always_inline bool system_supports_mpam(void)