| Message ID | 20241212-dt-bcm2712-fixes-v3-2-44a7f3390331@raspberrypi.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/vc4: Fixup DT and DT binding issues from recent patchset | expand |
On Thu, Dec 12, 2024 at 06:36:29PM +0000, Dave Stevenson wrote: > Commit 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") > added the compatible string for BCM2712, but missed out that > the number of interrupts and clocks changed too. > > Update to validate clock and interrupts for the variants. > > Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > .../bindings/display/brcm,bcm2835-hvs.yaml | 83 ++++++++++++++++++---- > 1 file changed, 69 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml > index f91c9dce2a44..36bf8eec88a6 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml > @@ -20,11 +20,20 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > + > + interrupt-names: > + minItems: 1 > + maxItems: 3 > > clocks: > - maxItems: 1 > - description: Core Clock > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + maxItems: 2 > > required: > - compatible > @@ -33,17 +42,63 @@ required: > > additionalProperties: false > > -if: > - properties: > - compatible: > - contains: > - enum: > - - brcm,bcm2711-hvs > - - brcm,bcm2712-hvs > - > -then: > - required: > - - clocks > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm2711-hvs > + > + then: > + properties: > + clocks: > + items: > + - description: Core Clock > + interrupts: > + maxItems: 1 > + > + required: > + - clocks > + > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm2712-hvs > + > + then: > + properties: > + clocks: minItems: 2 > + maxItems: 2 > + clock-names: > + items: > + - const: core > + - const: disp > + interrupts: > + items: > + - description: Channel 0 End of frame > + - description: Channel 1 End of frame > + - description: Channel 2 End of frame > + interrupt-names: > + items: > + - const: ch0-eof > + - const: ch1-eof > + - const: ch2-eof > + required: > + - clocks > + - clock-names > + - interrupt-names Why requiring last two names? Commit msg does not explain that. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml index f91c9dce2a44..36bf8eec88a6 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml @@ -20,11 +20,20 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 3 + + interrupt-names: + minItems: 1 + maxItems: 3 clocks: - maxItems: 1 - description: Core Clock + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + maxItems: 2 required: - compatible @@ -33,17 +42,63 @@ required: additionalProperties: false -if: - properties: - compatible: - contains: - enum: - - brcm,bcm2711-hvs - - brcm,bcm2712-hvs - -then: - required: - - clocks +allOf: + - if: + properties: + compatible: + contains: + const: brcm,bcm2711-hvs + + then: + properties: + clocks: + items: + - description: Core Clock + interrupts: + maxItems: 1 + + required: + - clocks + + - if: + properties: + compatible: + contains: + const: brcm,bcm2712-hvs + + then: + properties: + clocks: + maxItems: 2 + clock-names: + items: + - const: core + - const: disp + interrupts: + items: + - description: Channel 0 End of frame + - description: Channel 1 End of frame + - description: Channel 2 End of frame + interrupt-names: + items: + - const: ch0-eof + - const: ch1-eof + - const: ch2-eof + required: + - clocks + - clock-names + - interrupt-names + + - if: + properties: + compatible: + contains: + const: brcm,bcm2835-hvs + + then: + properties: + interrupts: + maxItems: 1 examples: - |
Commit 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") added the compatible string for BCM2712, but missed out that the number of interrupts and clocks changed too. Update to validate clock and interrupts for the variants. Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- .../bindings/display/brcm,bcm2835-hvs.yaml | 83 ++++++++++++++++++---- 1 file changed, 69 insertions(+), 14 deletions(-)