| Message ID | 20241212-dt-bcm2712-fixes-v3-3-44a7f3390331@raspberrypi.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/vc4: Fixup DT and DT binding issues from recent patchset | expand |
On Thu, Dec 12, 2024 at 06:36:30PM +0000, Dave Stevenson wrote: > gpio-line-names is a generic property that can be supported by any > GPIO controller, so permit it through the binding. > > It is permitted to have a variable number of GPIOs per node based > on brcm,gpio-bank-widths, so define an arbitrary maximum number of > items based on current users. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Dec 12, 2024 at 7:36 PM Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > gpio-line-names is a generic property that can be supported by any > GPIO controller, so permit it through the binding. > > It is permitted to have a variable number of GPIOs per node based > on brcm,gpio-bank-widths, so define an arbitrary maximum number of > items based on current users. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Perhaps Bartosz can just apply this one patch separately? Yours, Linus Walleij
Hi Linus On Fri, 20 Dec 2024 at 12:50, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Thu, Dec 12, 2024 at 7:36 PM Dave Stevenson > <dave.stevenson@raspberrypi.com> wrote: > > > gpio-line-names is a generic property that can be supported by any > > GPIO controller, so permit it through the binding. > > > > It is permitted to have a variable number of GPIOs per node based > > on brcm,gpio-bank-widths, so define an arbitrary maximum number of > > items based on current users. > > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thank you. > Perhaps Bartosz can just apply this one patch separately? I believe he already has, but commented against the cover letter rather than this patch - https://lore.kernel.org/linux-arm-kernel/173434013318.38429.808413721248542013.b4-ty@linaro.org/ Dave > Yours, > Linus Walleij
On Fri, Dec 20, 2024 at 2:02 PM Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > > Hi Linus > > On Fri, 20 Dec 2024 at 12:50, Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Thu, Dec 12, 2024 at 7:36 PM Dave Stevenson > > <dave.stevenson@raspberrypi.com> wrote: > > > > > gpio-line-names is a generic property that can be supported by any > > > GPIO controller, so permit it through the binding. > > > > > > It is permitted to have a variable number of GPIOs per node based > > > on brcm,gpio-bank-widths, so define an arbitrary maximum number of > > > items based on current users. > > > > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Thank you. > > > Perhaps Bartosz can just apply this one patch separately? > > I believe he already has, but commented against the cover letter > rather than this patch - > https://lore.kernel.org/linux-arm-kernel/173434013318.38429.808413721248542013.b4-ty@linaro.org/ > Ah, this is how b4 works. Even if you apply a single patch, it responds to the cover letter (or the first patch in the series if there's no cover letter). Bart
diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml index f096f286da19..fbd69b4cecc7 100644 --- a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml @@ -64,6 +64,10 @@ properties: gpio-ranges: true + gpio-line-names: + minItems: 1 + maxItems: 128 + wakeup-source: type: boolean description: >
gpio-line-names is a generic property that can be supported by any GPIO controller, so permit it through the binding. It is permitted to have a variable number of GPIOs per node based on brcm,gpio-bank-widths, so define an arbitrary maximum number of items based on current users. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml | 4 ++++ 1 file changed, 4 insertions(+)