| Message ID | 20241227133420.169714-1-jagan@edgeble.ai (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] arm64: dts: rockchip: Add Rockchip RK3588M | expand |
Hello Jagan, Please see a comment below. On 2024-12-27 14:34, Jagan Teki wrote: > Rockchip RK3588M is the automotive-grade version of RK3588 SoC and > is operated with -40 °C to +85 °C temparature. > > Add rk3588m specific dtsi for adding rk3588m specific operating points > and other changes to be add in future. > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > --- > arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi > b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi > new file mode 100644 > index 000000000000..0bbeee399a63 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. > + * > + */ > + > +#include "rk3588-extra.dtsi" I don't think we need or want a separate rk3588m.dtsi file for this purpose, unless the RK3588M variant actually differs from the regular RK3588 variant from the software standpoint. The latter is already described in rk3588.dtsi, so it should just be included in the new board dts(i) file.
On 2024-12-27 14:48, Dragan Simic wrote: > Hello Jagan, > > Please see a comment below. > > On 2024-12-27 14:34, Jagan Teki wrote: >> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and >> is operated with -40 °C to +85 °C temparature. >> >> Add rk3588m specific dtsi for adding rk3588m specific operating points >> and other changes to be add in future. >> >> Signed-off-by: Jagan Teki <jagan@edgeble.ai> >> --- >> arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> new file mode 100644 >> index 000000000000..0bbeee399a63 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> @@ -0,0 +1,7 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. >> + * >> + */ >> + >> +#include "rk3588-extra.dtsi" > > I don't think we need or want a separate rk3588m.dtsi file for this > purpose, unless the RK3588M variant actually differs from the regular > RK3588 variant from the software standpoint. The latter is already > described in rk3588.dtsi, so it should just be included in the new > board dts(i) file. Actually, after having a look at the downstream code, it seems that the RK3588J and RK3588M variants share the same OPPs, so actually rk3588j.dtsi should be used for the RK3588M variant. Could you, please, confirm this? Alas, it seems we've got some serious issues in the OPPs currently defined in rk3588j.dtsi, which I'll double check to make sure I'm not going crazy, :) and submit a patch that fixes those OPPs. If you could confirm the RK3588M == RK3588J assumption above, I can add some additional clarification to the rk3588j.dtsi file in the above-mentioned fixes.
On Fri, 27 Dec 2024 at 19:37, Dragan Simic <dsimic@manjaro.org> wrote: > > On 2024-12-27 14:48, Dragan Simic wrote: > > Hello Jagan, > > > > Please see a comment below. > > > > On 2024-12-27 14:34, Jagan Teki wrote: > >> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and > >> is operated with -40 °C to +85 °C temparature. > >> > >> Add rk3588m specific dtsi for adding rk3588m specific operating points > >> and other changes to be add in future. > >> > >> Signed-off-by: Jagan Teki <jagan@edgeble.ai> > >> --- > >> arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi > >> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi > >> new file mode 100644 > >> index 000000000000..0bbeee399a63 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi > >> @@ -0,0 +1,7 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. > >> + * > >> + */ > >> + > >> +#include "rk3588-extra.dtsi" > > > > I don't think we need or want a separate rk3588m.dtsi file for this > > purpose, unless the RK3588M variant actually differs from the regular > > RK3588 variant from the software standpoint. The latter is already > > described in rk3588.dtsi, so it should just be included in the new > > board dts(i) file. > > Actually, after having a look at the downstream code, it seems that > the RK3588J and RK3588M variants share the same OPPs, so actually > rk3588j.dtsi should be used for the RK3588M variant. Could you, > please, confirm this? > > Alas, it seems we've got some serious issues in the OPPs currently > defined in rk3588j.dtsi, which I'll double check to make sure I'm not > going crazy, :) and submit a patch that fixes those OPPs. > > If you could confirm the RK3588M == RK3588J assumption above, I can > add some additional clarification to the rk3588j.dtsi file in the > above-mentioned fixes. As-far-as-i-know both OPPs were different due to computation grades J for Industrial and M for Automotive. What I saw from downstream linux-6.1-stan-rkr1 was a simple dtsi for M variant and might have changes to add OPPs which I cannot be sure at this point of time. I keep that dtsi as separate even though it is nothing as i was expecting some future changes on OPPs or so. Kever or Heiko can help here. Thanks, Jagan.
On 2024-12-27 15:13, Jagan Teki wrote: > On Fri, 27 Dec 2024 at 19:37, Dragan Simic <dsimic@manjaro.org> wrote: >> On 2024-12-27 14:48, Dragan Simic wrote: >> > Please see a comment below. >> > >> > On 2024-12-27 14:34, Jagan Teki wrote: >> >> Rockchip RK3588M is the automotive-grade version of RK3588 SoC and >> >> is operated with -40 °C to +85 °C temparature. >> >> >> >> Add rk3588m specific dtsi for adding rk3588m specific operating points >> >> and other changes to be add in future. >> >> >> >> Signed-off-by: Jagan Teki <jagan@edgeble.ai> >> >> --- >> >> arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> >> >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> >> b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> >> new file mode 100644 >> >> index 000000000000..0bbeee399a63 >> >> --- /dev/null >> >> +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi >> >> @@ -0,0 +1,7 @@ >> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> >> +/* >> >> + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. >> >> + * >> >> + */ >> >> + >> >> +#include "rk3588-extra.dtsi" >> > >> > I don't think we need or want a separate rk3588m.dtsi file for this >> > purpose, unless the RK3588M variant actually differs from the regular >> > RK3588 variant from the software standpoint. The latter is already >> > described in rk3588.dtsi, so it should just be included in the new >> > board dts(i) file. >> >> Actually, after having a look at the downstream code, it seems that >> the RK3588J and RK3588M variants share the same OPPs, so actually >> rk3588j.dtsi should be used for the RK3588M variant. Could you, >> please, confirm this? >> >> Alas, it seems we've got some serious issues in the OPPs currently >> defined in rk3588j.dtsi, which I'll double check to make sure I'm not >> going crazy, :) and submit a patch that fixes those OPPs. >> >> If you could confirm the RK3588M == RK3588J assumption above, I can >> add some additional clarification to the rk3588j.dtsi file in the >> above-mentioned fixes. > > As-far-as-i-know both OPPs were different due to computation grades J > for Industrial and M for Automotive. What I saw from downstream > linux-6.1-stan-rkr1 was a simple dtsi for M variant and might have > changes to add OPPs which I cannot be sure at this point of time. I > keep that dtsi as separate even though it is nothing as i was > expecting some future changes on OPPs or so. After checking the downstream code again, [*] it seems to me that the RK3588J and RK3588M variants share the same OPPs. Furthermore, if the OPPs for the RK3588M variant cannot be defined accurately at the moment, I'd suggest that the placeholder .dtsi is avoided and that a complete per-variant .dtsi is added later, when the OPPs are actually determined and defined. Regarding the assumed issues with the current OPPs in rk3588j.dtsi, it's all about the IPA complaining about the same-voltage, lower- frequency OPPs being inefficient, which I already argued against. I remain committed to proving that to be inaccurate, but until that materializes, the current OPPs are there to stay. [*] https://raw.githubusercontent.com/rockchip-linux/kernel/604cec4004abe5a96c734f2fab7b74809d2d742f/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
diff --git a/arch/arm64/boot/dts/rockchip/rk3588m.dtsi b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi new file mode 100644 index 000000000000..0bbeee399a63 --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3588m.dtsi @@ -0,0 +1,7 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. + * + */ + +#include "rk3588-extra.dtsi"
Rockchip RK3588M is the automotive-grade version of RK3588 SoC and is operated with -40 °C to +85 °C temparature. Add rk3588m specific dtsi for adding rk3588m specific operating points and other changes to be add in future. Signed-off-by: Jagan Teki <jagan@edgeble.ai> --- arch/arm64/boot/dts/rockchip/rk3588m.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588m.dtsi