From patchwork Sat Dec 28 01:14:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 13922228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8875DE7718F for ; Sat, 28 Dec 2024 01:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=s4iEz0ZASzilRD4KKfSUDFsUwf 80w+qLrcZSWIjP/rlHDwdUjrs/dx5vgW2GUUKpQdlCDkWDRh+NcUqBM6W0oZppVpl1wdQuLQHYGfm PIUl2XlxJiyMnS8rby5H/puA2XCbYwoBkipRcawZtkB9HRJMdG5RBdm0DT1wMPVDh6tXDko8an4hn 1HE8DZVylvDEQuyXQesDxqxYxqX2H9IAYcMimPEqzyIGjiUWlw2RFz12cFtkXWaTp37590jaiq6fR ASqvdmCuWlCsd0jfy4ZaPVQIMWCxieAuhgQ0joLkUaRR0HUFwk7KUEbq06BStckSoRP2YQsdjp8bU TaG3tGYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tRLV5-00000001CGk-2l5m; Sat, 28 Dec 2024 01:20:19 +0000 Received: from mail-am6eur05on20621.outbound.protection.outlook.com ([2a01:111:f403:2612::621] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tRLQU-00000001B7s-0sB2; Sat, 28 Dec 2024 01:15:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lWEDXFj1zRBZbCj4jTywAYgUog+kXOLJm/GyPFk4BSTFhuJ6sPkUZCGU3ydCnqnB6iTW7n1Z4/9NXpZfwQ3tHnVoaFj4aFhUkRmzyuOySq2eJV9vZCKrxTL36b8qJamFachTUDVUMhD4oNCGnYbpN5WRLwXNH+fTM+JZdpxP9IMpb7IhvS+W2GTn9fOEKZFAvB8GUZ1Y327P7wmHIzviAiQPir2qUPwokDZm40TRvp1Cbi5L1rqjUXJwOfEIeG+/kLKkeMl3laLpRPPxtVQRuZhE3SIVJuDWOsN62KJKHB2K4R/7QyczSoUXVl/UMkLVsUksW2tQP9nF6zvRO/TqqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=nMK61q1f3iv8IS8mVpJPXCLtlAMGuij5lngqJRXQktiudXn2LWPhNY6LhhpAfKb9LQmeo5gFoglFha9iQm9p8VnQ8t71mbHsNsh2EjLcQleHnAO2JIjR84eFB4rF6ei04jAHb57tPbjZHciTrBxetf5ioLSfC26O+d6cFt0qiiMuJVYi1HeCLjvtMjwiirnzrzbwXjV5eL0H/sp3N6nlGy/K1vlYuXdF4GgfBiqbaiWUSegs7MysJa1EuErwTMer3dJk24sVOC6TeYWactjcKZLhGpuo2P9CgIEkGhg5dzhD942c9u9rXAnD86EsVuldNQQ/WmvLGgx8WJqI9QJc7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=XBLE3//aEAKVbhEC+/BM1AxatOEnWwzsJqOyaIsZkYVospAzKoJsgqlZLWgRXL7KUD5PK/hIpFEOS6PEpveF2Rnyp2ax7gLzjHRNSIxSbY6LPsSJr8Ptm/uSSoIW+PQJ8rrcL2vp9CFLrt9yx0Sq6x+Q0vm/632nvRTeOwpWQOWGts6HjqExsCX7M/DbaCktVYgX+A03ied7ASJlyXGZvAHT3JmeqpT+c4A1mEoUEXmQUEAkDttlKj0VFXmTrlzy80R11Lf66lb44eMhz+QIm9hB3DUket3x0SUxHle97tYthqdDToK+kHU51yWEOkbdshFZ4wMOYmD6cXEXq7IIQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Sat, 28 Dec 2024 01:15:28 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 01:15:28 +0000 From: "Peng Fan (OSS)" Date: Sat, 28 Dec 2024 09:14:39 +0800 Subject: [PATCH 03/12] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq Message-Id: <20241228-wake_irq-v1-3-09cfca77cd47@nxp.com> References: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> In-Reply-To: <20241228-wake_irq-v1-0-09cfca77cd47@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735348488; l=1365; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=IYFb5BcVnaCb3uUN830r92UAprUHpPfeHJSpQKDJq+A=; b=ITPynXFen6NGI8Tv+l+31DPkuKOjZW+qKhVpYyrqEi1xXbuJiSLrF2YI2N0Bz1lh8BwJ5w4al wmUn6KOWVzGAMLjoeV1RPp2jYZsny3AhGb+XF2EJuPOEk3vDtyGfzq9 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR02CA0099.apcprd02.prod.outlook.com (2603:1096:4:92::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a463dc9-5b0f-4a17-510f-08dd26dd1dcd X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?5x1/iyif99YqyUC3jNzcQqvss3Pvijb?= =?utf-8?q?kdfKolf8vMAYEvSHjZEVOn82J4gs2978zUikI/2goAV7cN2tgpdtUZ4Eihcx4bceQ?= =?utf-8?q?stQ8iIW9WdwzANjqWniTGtygPo1qy1wPnq9XxqibOhh2poHPKJepaOmb2BWnje2VZ?= =?utf-8?q?IjI7LnTyKeaiVGZBDSpU6s5CwQGrch1VI6iZ6Va5F4MOjaVC147JeyKs6BcCJ0iDi?= =?utf-8?q?a8ROsddZhWIG5Vkplq1sW5f9vcvbkdTKB3/1luCOjktnitrQeyZAdigNHjSnlhmL9?= =?utf-8?q?1oZ6MirJkAZoBgVJINWfnWcwutGAynBitvt5gnWEg6TQ+qq3VYGbv/3f+Pu4eZ7sR?= =?utf-8?q?nXhXyf50Pc0Sl9aGPy8CuTIgOHHXtwBUmGEbNX6cclnyl4cHNZeGi/72eggKOXMUI?= =?utf-8?q?bz5fRW9z8CPW86wNnoWBee+RdQaSQ4qZEDzxqPCYpFVBAes7G4eE6IbtT6bOJDUh5?= =?utf-8?q?qsYLEtEVThFaDOyIR3yErh+ryXv+m+q+99nkpVklsLRSmue14+IeFnbkJxXK+CRQc?= =?utf-8?q?vh/JoXF06ORnc/Wr0y4BvnLMXxYEXS5Ltnf7upA3IUOc+vcH0OqYKIaoq5Fc+Z8+Q?= =?utf-8?q?NdlMJg2wx157ABhjJoM8jk38FhewXYOcDP3+raRGujYUZ/dpLnWFbJdfs+YsaGFI0?= =?utf-8?q?2IApYCayhFuT9hNaIhDyVCsgkhKsb2r2Nc54u9ZY38LF9Z/R8PGeD/euGIO4Fgh6R?= =?utf-8?q?fLStR0GP99L0sqm3R6Txi0fkD8YeHybM0tjieXGmZ5dsoiwlLQChg3dpsc50hJe0o?= =?utf-8?q?ICNAicuq/triyn66aCBt2ZnCUnZ9LcdbIGEYvBvp4YnuFdvYYruIgJUmbGlIXv16M?= =?utf-8?q?J76/+1iuzJ193RI8kSb22uSNDMccqgEFbSti6Qz1O7qSoaO/KEk9DlA7LRAhuNSzd?= =?utf-8?q?ipKgDQTM0kLhjcwpD7jqbZB7zWFtwogCK3TR+q3LTExTGcDtp67QqKXn9PxBYaA87?= =?utf-8?q?Pv+HJ1lV8eXdrQNjKOJWYVqyPjl0OfaTaXb1Kzg+ulqOpFCnbD+57Iq28pnItD/os?= =?utf-8?q?Wa9GTip5B+K3b0owLzUKI82628RalCdO8O/ndYkE7SHUX7+osshvBDvtU65leMuk0?= =?utf-8?q?vr5mgvAngnjo5wJuarxFArt2ARsS9sRluGedzISeh9leeIzm6LMsyqtz1begTNVdF?= =?utf-8?q?CpkFGK5v7LOezy2iZ8m169JgyOVYaVQBJcHtxqmBpooKxcEMI6R8NF3YnHu1aAPBB?= =?utf-8?q?4vXAoDxn8AYK2rgPOn7D7hVDi9Jrp0B4320zQNYKiEThKRVZwP5aN/SAE7vB78XUF?= =?utf-8?q?YPBAdExR2Jqn50syWYrAc3nNRH1LwF9fqgtaQktU7Vwersul7pXkZYi3ThKHZpWaA?= =?utf-8?q?FHPslaa7F6GwanlfSxY8iFE7Us43mE1y+im/vEU1y2lmM8dXsFsgnSd3o8cXjpMWy?= =?utf-8?q?mVwdZaCaoxz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Ee2tHoga4G5jfnUXCRlJJsIZbw6+?= =?utf-8?q?g/jGP0I90dCNM9pkD+TjBYb/vpqaUlAcz6QTGOoeIXfb/Aa/oIL7sG3rTHCkmn9OR?= =?utf-8?q?hhyowuBh9rfKbHjThoGsYEWmekV5FpmZ5DYxvcrh7yyjeo7SwYpGw/nU3Q5bHETOW?= =?utf-8?q?EiiYZq3atVy48LRiFvbT7SlKz1A3VkEipyQZtza1soGI+ku7LFBmyB+lOkZanP7eX?= =?utf-8?q?XUhBehHlcKxR7fh4t9kgNU35X2qF+5POjwxWCX0zrg1Ef4DenKziOArcRrpWf080C?= =?utf-8?q?/aJa0lf6dDBAgzjCzQs8uCCbwHZ3xGse2z87PgqQRGm8onM7X/ZEpCwhyY161HBWa?= =?utf-8?q?Ci1nWIMXMa8gDAOZUfctcf9MdqpwiuftxVdQFY/uwJV0RtvUKaXLd9PoaLp/8ZbbT?= =?utf-8?q?jJaWIwd+peQn8bS325ZmTPCpB3n30SAswGPINA1HYLExHmr46k21xI6Dr0lZ+/Xaf?= =?utf-8?q?RyDux8/1Y8P5dVaPLW7PiIHOutBFRWNrqXRp1UbFFmuf5BiPuHmxpUmPLCSXs33Ci?= =?utf-8?q?NUc6N5e6TShiDpemzcP1OKr9o5AUwAOwrrJUXnrQ4WwG6X3ihqyJDYexSFtLpXtCU?= =?utf-8?q?jU1zkTY/WaeGNncJ2DUUxIc5dyXpmhL6TwY7ce7JT93Ckl624TxKW35O31iNDlyvJ?= =?utf-8?q?OqNWqZYwbj2xVPOuDfWknVE8nfFWRjYxO1KSR7y1MsxQBJkON2Kmo0i3lHqPxKLYZ?= =?utf-8?q?4plsnZjkIDHhdFtcExy4w8XTDb5njs22133eKVogy3Sr7m03j2rmEeati1y6jBe5k?= =?utf-8?q?j37O8dZBIGFI5Wd5ecEOxUan9EMI3wZtHfwcWFLmRVN/J+oZQAebtSVnWoxqZVXlr?= =?utf-8?q?nWB6bKnHsMZbP0O4LCiMcgv5a+oph/Eq9HESXMAsZpwzoeVz50IMkTO/7ydeukVn9?= =?utf-8?q?884MMb9YY2FWVqKXcPt33SJ8YfCxyF/LnVEztSSE6K7IMzUbjv+VtggVEvugeoH1c?= =?utf-8?q?EeuSKx1F4mlUrNAtLGOywnsIkz4VG9de18Hp3XlvMwbm6H1bwWThMoxNxD/+vnqlK?= =?utf-8?q?YjuXyxJdX+TEoJJ/EPvps3LBWiDmW14zHnz1qmZ/QTfWIcj+fEC1B/uUY4L+VLlWG?= =?utf-8?q?zNYhwrzNpbqP3agHaNgwZW+R1u6HMqpZYExipy3HwcUB9GXlKsRKJPoVPRvzpcXr0?= =?utf-8?q?OC79pijG25sblKBv93Pu9AE74PvAsqoDnXdQRtqDXoTf+h0qhNzXRil6pTRZqdzzb?= =?utf-8?q?xUHsPuCPlUFmmL/dk7KOiY/lPSZSYE9Oih75JUMU6pjj06D1jd6J6fWhhI8V8Dttj?= =?utf-8?q?+Sihl8NKF6h0Gtbp9y/Vcc2uftpc7pwhmuZNfPN5C8ITgJQnvZJGwt5tj1NZ2FghF?= =?utf-8?q?5uP4O/qVr9OWjMq45Gfs7lCxGtCrOIbFlOVRvJ1Fj6NU8FpfuCHJZXZRPTRRYOdDC?= =?utf-8?q?APwKPaKqH+fV9TwYCKNN6RPQckLwYDimiKpKesMyVUkfqPhQ8Oz4wOR2W0xwf93wT?= =?utf-8?q?Ayy1GOj1bV1YnFsdVhTYGHJK7x7RypG09Nne6iuQnvcOT5luFPhVoLwomqfQPpvVd?= =?utf-8?q?/kLZQ6XstfZ3?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a463dc9-5b0f-4a17-510f-08dd26dd1dcd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2024 01:15:28.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LYtznAeGYIu8MZpOGd3NkS0oHP9D5N8RErVMSD/mWqkv2HpiJzDvALxM8prkBUt+znJIsOotmJXLljeiwbrM3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241227_171534_259788_220FFA03 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/omap4-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index bffe89c0717adf9ebe5b33892efa4dc30b158f83..b7bd649d1628a6bf10db4135f73778f62db92647 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -465,18 +465,13 @@ static int omap4_keypad_probe(struct platform_device *pdev) } device_init_wakeup(dev, true); - error = dev_pm_set_wake_irq(dev, keypad_data->irq); + error = devm_pm_set_wake_irq(dev, keypad_data->irq); if (error) dev_warn(dev, "failed to set up wakeup irq: %d\n", error); return 0; } -static void omap4_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id omap_keypad_dt_match[] = { { .compatible = "ti,omap4-keypad" }, {}, @@ -485,7 +480,6 @@ MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); static struct platform_driver omap4_keypad_driver = { .probe = omap4_keypad_probe, - .remove = omap4_keypad_remove, .driver = { .name = "omap4-keypad", .of_match_table = omap_keypad_dt_match,