| Message ID | 20241229184256.1870-8-honyuenkwun@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Orange Pi 5 Max board | expand |
On Sun, Dec 29, 2024 at 12:41:31PM -0600, Jimmy Hon wrote: > Add devicetree binding for the Xunlong Orange Pi 5 Ultra board. Why RFC? Looks fine to me. However, you should have 'v4' on every patch in the series if this is v4. > > The Orange Pi 5 Ultra is a single board computer powered by the Rockchip > RK3588 with similar board layout as the 5 Max but with the HDMI0 swapped > for HDMI IN. > > Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 2a141d99c533..9dd424265826 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -1075,11 +1075,12 @@ properties: > - const: xunlong,orangepi-3b > - const: rockchip,rk3566 > > - - description: Xunlong Orange Pi 5 Max/Plus > + - description: Xunlong Orange Pi 5 Max/Plus/Ultra > items: > - enum: > - xunlong,orangepi-5-max > - xunlong,orangepi-5-plus > + - xunlong,orangepi-5-ultra > - const: rockchip,rk3588 > > - description: Xunlong Orange Pi R1 Plus / LTS > -- > 2.47.1 >
On Thu, Jan 2, 2025 at 3:53 PM Rob Herring <robh@kernel.org> wrote: > > On Sun, Dec 29, 2024 at 12:41:31PM -0600, Jimmy Hon wrote: > > Add devicetree binding for the Xunlong Orange Pi 5 Ultra board. > > Why RFC? Looks fine to me. The DTS is only a RFC because the board schematic for the Ultra has not been released yet. So I haven't been able to confirm the pinouts. The 5 Ultra DTS is mainly a preview to show the similarities between the 5 Max and the 5 Ultra. > > However, you should have 'v4' on every patch in the series if this is > v4. Will do. > > > > > The Orange Pi 5 Ultra is a single board computer powered by the Rockchip > > RK3588 with similar board layout as the 5 Max but with the HDMI0 swapped > > for HDMI IN. > > > > Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index 2a141d99c533..9dd424265826 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -1075,11 +1075,12 @@ properties: > > - const: xunlong,orangepi-3b > > - const: rockchip,rk3566 > > > > - - description: Xunlong Orange Pi 5 Max/Plus > > + - description: Xunlong Orange Pi 5 Max/Plus/Ultra > > items: > > - enum: > > - xunlong,orangepi-5-max > > - xunlong,orangepi-5-plus > > + - xunlong,orangepi-5-ultra > > - const: rockchip,rk3588 > > > > - description: Xunlong Orange Pi R1 Plus / LTS > > -- > > 2.47.1 > >
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 2a141d99c533..9dd424265826 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -1075,11 +1075,12 @@ properties: - const: xunlong,orangepi-3b - const: rockchip,rk3566 - - description: Xunlong Orange Pi 5 Max/Plus + - description: Xunlong Orange Pi 5 Max/Plus/Ultra items: - enum: - xunlong,orangepi-5-max - xunlong,orangepi-5-plus + - xunlong,orangepi-5-ultra - const: rockchip,rk3588 - description: Xunlong Orange Pi R1 Plus / LTS
Add devicetree binding for the Xunlong Orange Pi 5 Ultra board. The Orange Pi 5 Ultra is a single board computer powered by the Rockchip RK3588 with similar board layout as the 5 Max but with the HDMI0 swapped for HDMI IN. Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)