| Message ID | 20250103204523.3779-2-lukas.schmid@netcube.li (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for NetCube Systems Kumquat | expand |
On Fri, 3 Jan 2025 20:45:17 +0000 Lukas Schmid <lukas.schmid@netcube.li> wrote: > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> double Signed-off-by: Also can please add a single line briefly saying what the company does or produce, maybe add an URL? In general some text in the body of the commit message is always appreciated, even if it repeats the subject line (check the other commits to that file). Cheers, Andre > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index da01616802c7..a30ed9547098 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -1027,6 +1027,8 @@ patternProperties: > description: Neofidelity Inc. > "^neonode,.*": > description: Neonode Inc. > + "^netcube,.*": > + description: NetCube Systems Austria > "^netgear,.*": > description: NETGEAR > "^netlogic,.*":
On Fri, Jan 03, 2025 at 08:45:17PM +0000, Lukas Schmid wrote: > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> Repeating again one of my comments: Please run scripts/checkpatch.pl and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please implement all comments. Best regards, Krzysztof
On 04/01/2025 10:30, Krzysztof Kozlowski wrote: > On Fri, Jan 03, 2025 at 08:45:17PM +0000, Lukas Schmid wrote: >> Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> > > > Repeating again one of my comments: > > Please run scripts/checkpatch.pl and fix reported warnings. After that, > run also 'scripts/checkpatch.pl --strict' and (probably) fix more > warnings. Some warnings can be ignored, especially from --strict run, > but the code here looks like it needs a fix. Feel free to get in touch > if the warning is not clear. > > Please implement all comments. My bad, I did not write that hint earlier. Anyway, your patchset - all four patches - has multiple issues so you need to fix all of them before posting next version. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index da01616802c7..a30ed9547098 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1027,6 +1027,8 @@ patternProperties: description: Neofidelity Inc. "^neonode,.*": description: Neonode Inc. + "^netcube,.*": + description: NetCube Systems Austria "^netgear,.*": description: NETGEAR "^netlogic,.*":