| Message ID | 20250107094943.518474-3-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | i.MX7 DT fixes | expand |
Hi Alexander, Thank you for the patch. On Tue, Jan 07, 2025 at 10:49:42AM +0100, Alexander Stein wrote: > This add a imx7(d) specific compatible which is compatible to imx8mm. > This silences the dtbs_check warning: > arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: dsi@30760000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx7d-mipi-dsim', 'fsl,imx8mm-mipi-dsim'] is too long > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > index 4ed7a799ba26b..e43fec5609417 100644 > --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > @@ -27,7 +27,9 @@ properties: > - fsl,imx8mm-mipi-dsim > - fsl,imx8mp-mipi-dsim > - items: > - - const: fsl,imx8mn-mipi-dsim > + - enum: > + - fsl,imx7d-mipi-dsim > + - fsl,imx8mn-mipi-dsim > - const: fsl,imx8mm-mipi-dsim > > reg:
Hi Alexander, On Tue, Jan 7, 2025 at 6:50 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > This add a imx7(d) specific compatible which is compatible to imx8mm. > This silences the dtbs_check warning: > arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: dsi@30760000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx7d-mipi-dsim', 'fsl,imx8mm-mipi-dsim'] is too long The warning here is about using fsl,imx8mm-mipi-dsim. > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > index 4ed7a799ba26b..e43fec5609417 100644 > --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > @@ -27,7 +27,9 @@ properties: > - fsl,imx8mm-mipi-dsim > - fsl,imx8mp-mipi-dsim > - items: > - - const: fsl,imx8mn-mipi-dsim > + - enum: > + - fsl,imx7d-mipi-dsim > + - fsl,imx8mn-mipi-dsim But you added a fallback to fsl,imx8mn-mipi-dsim, so this does not look right. I have already sent the following fix to address this issue: https://lore.kernel.org/all/20241217131431.1464983-1-festevam@gmail.com/T/
Hi Fabio, Am Dienstag, 7. Januar 2025, 11:35:48 CET schrieb Fabio Estevam: > Hi Alexander, > > On Tue, Jan 7, 2025 at 6:50 AM Alexander Stein > <alexander.stein@ew.tq-group.com> wrote: > > > > This add a imx7(d) specific compatible which is compatible to imx8mm. > > This silences the dtbs_check warning: > > arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: dsi@30760000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['fsl,imx7d-mipi-dsim', 'fsl,imx8mm-mipi-dsim'] is too long > > The warning here is about using fsl,imx8mm-mipi-dsim. I'm not sure what you exactly mean. The warning isn't about using fsl,imx8mm-mipi-dsim, instead fsl,imx7d-mipi-dsim does not match any compatibles listed in the schema. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > > index 4ed7a799ba26b..e43fec5609417 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > > @@ -27,7 +27,9 @@ properties: > > - fsl,imx8mm-mipi-dsim > > - fsl,imx8mp-mipi-dsim > > - items: > > - - const: fsl,imx8mn-mipi-dsim > > + - enum: > > + - fsl,imx7d-mipi-dsim > > + - fsl,imx8mn-mipi-dsim > > But you added a fallback to fsl,imx8mn-mipi-dsim, so this does not look right. Admittedly I'm having a hard time on DT schemas at times, but this change allows imx7d OR imx8mn to be used together with imx8mm. > I have already sent the following fix to address this issue: > > https://lore.kernel.org/all/20241217131431.1464983-1-festevam@gmail.com/T/ This patch essentially does the same but add a new entry to the oneOf. If you add fsl,imx8mn-mipi-dsim to that enum as we end up with the same solution. Best regards, Alexander
On Tue, 07 Jan 2025 10:49:42 +0100, Alexander Stein wrote: > This add a imx7(d) specific compatible which is compatible to imx8mm. > This silences the dtbs_check warning: > arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: dsi@30760000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx7d-mipi-dsim', 'fsl,imx8mm-mipi-dsim'] is too long > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Fabio is clearly confused, and I prefer this patch over his. As it is probably past the drm-misc cutoff, I applied it to DT tree. Thanks, Rob
On Tue, Jan 7, 2025 at 8:21 PM Rob Herring (Arm) <robh@kernel.org> wrote: > Fabio is clearly confused, and I prefer this patch over his. As > it is probably past the drm-misc cutoff, I applied it to DT tree. You are right. I am sorry for the confusion.
diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml index 4ed7a799ba26b..e43fec5609417 100644 --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml @@ -27,7 +27,9 @@ properties: - fsl,imx8mm-mipi-dsim - fsl,imx8mp-mipi-dsim - items: - - const: fsl,imx8mn-mipi-dsim + - enum: + - fsl,imx7d-mipi-dsim + - fsl,imx8mn-mipi-dsim - const: fsl,imx8mm-mipi-dsim reg:
This add a imx7(d) specific compatible which is compatible to imx8mm. This silences the dtbs_check warning: arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: dsi@30760000: compatible: 'oneOf' conditional failed, one must be fixed: ['fsl,imx7d-mipi-dsim', 'fsl,imx8mm-mipi-dsim'] is too long Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)